chore(studio): update metrics api banner events (#41232)

* chore: update keys for metrics api banner

* fix: correct keys in banner

apps/studio/components/ui/BannerStack/Banners/BannerMetricsAPI.tsx

@@ -24,7 +24,7 @@ export const BannerMetricsAPI = () => {
       onDismiss={() => {
         setIsDismissed(true)
         dismissBanner('metrics-api-banner')
-        track('observability_banner_dismiss_button_clicked')
+        track('metrics_api_banner_dismiss_button_clicked')
       }}
     >
       <div className="flex flex-col gap-y-4">
@@ -51,7 +51,7 @@ export const BannerMetricsAPI = () => {
             <Link
               href={`${DOCS_URL}/guides/telemetry/metrics`}
               target="_blank"
-              onClick={() => track('observability_banner_cta_button_clicked')}
+              onClick={() => track('metrics_api_banner_cta_button_clicked')}
             >
               Get started for free
             </Link>

packages/common/telemetry-constants.ts

@@ -1089,8 +1089,20 @@ export interface ReportsDatabaseGrafanaBannerClickedEvent {
  * @source studio
  * @page /observability/*
  */
-export interface ObservabilityBannerCtaButtonClickedEvent {
-  action: 'observability_banner_cta_button_clicked'
+export interface MetricsAPIBannerCtaButtonClickedEvent {
+  action: 'metrics_api_banner_cta_button_clicked'
+  groups: TelemetryGroups
+}
+
+/**
+ * User clicked the dismiss button on a banner in studio Observability pages.
+ *
+ * @group Events
+ * @source studio
+ * @page /observability/*
+ */
+export interface MetricsAPIBannerDismissButtonClickedEvent {
+  action: 'metrics_api_banner_dismiss_button_clicked'
   groups: TelemetryGroups
 }
 
@@ -1158,18 +1170,6 @@ export interface IndexAdvisorCreateIndexesButtonClickedEvent {
   groups: TelemetryGroups
 }
 
-/**
- * User clicked the dismiss button on a banner in studio Observability pages.
- *
- * @group Events
- * @source studio
- * @page /observability/*
- */
-export interface ObservabilityBannerDismissButtonClickedEvent {
-  action: 'observability_banner_dismiss_button_clicked'
-  groups: TelemetryGroups
-}
-
 /**
  * User clicked the deploy button for an Edge Function.
  *
@@ -2661,8 +2661,8 @@ export type TelemetryEvent =
   | StudioPricingPlanCtaClickedEvent
   | StudioPricingSidePanelOpenedEvent
   | ReportsDatabaseGrafanaBannerClickedEvent
-  | ObservabilityBannerCtaButtonClickedEvent
-  | ObservabilityBannerDismissButtonClickedEvent
+  | MetricsAPIBannerCtaButtonClickedEvent
+  | MetricsAPIBannerDismissButtonClickedEvent
   | IndexAdvisorBannerEnableButtonClickedEvent
   | IndexAdvisorBannerDismissButtonClickedEvent
   | IndexAdvisorDialogEnableButtonClickedEvent