From 0bfa1de2ff9fd230175885aa47306701194fa9e0 Mon Sep 17 00:00:00 2001 From: "kemal.earth" <606977+kemaldotearth@users.noreply.github.com> Date: Mon, 15 Dec 2025 09:31:34 +0000 Subject: [PATCH] chore(studio): update metrics api banner events (#41232) * chore: update keys for metrics api banner * fix: correct keys in banner --- .../BannerStack/Banners/BannerMetricsAPI.tsx | 4 +-- packages/common/telemetry-constants.ts | 32 +++++++++---------- 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a/apps/studio/components/ui/BannerStack/Banners/BannerMetricsAPI.tsx b/apps/studio/components/ui/BannerStack/Banners/BannerMetricsAPI.tsx index 3047e480f0a..9bf58bb446f 100644 --- a/apps/studio/components/ui/BannerStack/Banners/BannerMetricsAPI.tsx +++ b/apps/studio/components/ui/BannerStack/Banners/BannerMetricsAPI.tsx @@ -24,7 +24,7 @@ export const BannerMetricsAPI = () => { onDismiss={() => { setIsDismissed(true) dismissBanner('metrics-api-banner') - track('observability_banner_dismiss_button_clicked') + track('metrics_api_banner_dismiss_button_clicked') }} >
@@ -51,7 +51,7 @@ export const BannerMetricsAPI = () => { track('observability_banner_cta_button_clicked')} + onClick={() => track('metrics_api_banner_cta_button_clicked')} > Get started for free diff --git a/packages/common/telemetry-constants.ts b/packages/common/telemetry-constants.ts index 664b0a4f50e..b7bbe87a256 100644 --- a/packages/common/telemetry-constants.ts +++ b/packages/common/telemetry-constants.ts @@ -1089,8 +1089,20 @@ export interface ReportsDatabaseGrafanaBannerClickedEvent { * @source studio * @page /observability/* */ -export interface ObservabilityBannerCtaButtonClickedEvent { - action: 'observability_banner_cta_button_clicked' +export interface MetricsAPIBannerCtaButtonClickedEvent { + action: 'metrics_api_banner_cta_button_clicked' + groups: TelemetryGroups +} + +/** + * User clicked the dismiss button on a banner in studio Observability pages. + * + * @group Events + * @source studio + * @page /observability/* + */ +export interface MetricsAPIBannerDismissButtonClickedEvent { + action: 'metrics_api_banner_dismiss_button_clicked' groups: TelemetryGroups } @@ -1158,18 +1170,6 @@ export interface IndexAdvisorCreateIndexesButtonClickedEvent { groups: TelemetryGroups } -/** - * User clicked the dismiss button on a banner in studio Observability pages. - * - * @group Events - * @source studio - * @page /observability/* - */ -export interface ObservabilityBannerDismissButtonClickedEvent { - action: 'observability_banner_dismiss_button_clicked' - groups: TelemetryGroups -} - /** * User clicked the deploy button for an Edge Function. * @@ -2661,8 +2661,8 @@ export type TelemetryEvent = | StudioPricingPlanCtaClickedEvent | StudioPricingSidePanelOpenedEvent | ReportsDatabaseGrafanaBannerClickedEvent - | ObservabilityBannerCtaButtonClickedEvent - | ObservabilityBannerDismissButtonClickedEvent + | MetricsAPIBannerCtaButtonClickedEvent + | MetricsAPIBannerDismissButtonClickedEvent | IndexAdvisorBannerEnableButtonClickedEvent | IndexAdvisorBannerDismissButtonClickedEvent | IndexAdvisorDialogEnableButtonClickedEvent