Files
supabase/apps/studio/lib/sentry-client-options.test.ts
Jordi Enric 8984305b1e feat: sample non-crash sentry errors at one percent (#50339)
## Problem

Browser Sentry reporting sends ordinary application errors at full
volume even though full-page crashes are the highest-priority signal.

## Fix

Sample eligible browser errors without `globalErrorBoundary` at 1%
across Studio, www, and docs. Keep 100% of eligible errors tagged with
`globalErrorBoundary`, preserve consent and existing noise filters, and
record the applied rate in `codeSampleRate`.

## How to test

- Run `node node_modules/vitest/vitest.mjs run
../../packages/common/sentry.test.ts lib/sentry-capture.test.tsx` from
`apps/www`.
- Run `node node_modules/vitest/vitest.mjs run
lib/sentry-client-options.test.ts` from `apps/studio`.
- Expected result: tagged page crashes bypass sampling, ordinary errors
use the 1% cutoff, and Studio applies sampling once while preserving its
existing filters.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Bug Fixes**
- Improved error reporting reliability by ensuring page-crash errors are
captured without sampling.
- Non-crash application errors are now sampled at a low rate, with
sampling metadata retained for monitoring.
- Updated filtering behavior so relevant Studio errors continue to be
reported consistently, including errors previously affected by
client-side filtering.
- Preserved filtering for third-party-only errors that do not represent
application failures.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2026-09-15 11:43:24 +02:00

583 lines
19 KiB
TypeScript

import type { Event as SentryEvent, StackFrame } from '@sentry/react'
import { afterAll, beforeAll, beforeEach, describe, expect, it, vi } from 'vitest'
import {
buildSentryClientOptions,
isBrowserWalletExtensionError,
isCancellationRejection,
isChallengeExpiredError,
isUserAbortedOperation,
} from './sentry-client-options'
describe('Sentry beforeSend filtering functions', () => {
describe('isBrowserWalletExtensionError', () => {
it('returns true for Gate.io wallet extension error (gt-window-provider.js)', () => {
const event: SentryEvent = {
exception: {
values: [
{
type: 'TypeError',
value: 'en.shouldSetTallyForCurrentProvider is not a function',
stacktrace: {
frames: [
{ filename: 'app:///_next/static/chunks/main.js' } as StackFrame,
{ filename: 'app:///gt-window-provider.js' } as StackFrame,
],
},
},
],
},
}
expect(isBrowserWalletExtensionError(event)).toBe(true)
})
it('returns true for Gate.io BTC wallet extension error (gt-window-provider-btc.js)', () => {
const event: SentryEvent = {
exception: {
values: [
{
type: 'TypeError',
value: 'f.shouldSetTallyForCurrentProvider is not a function',
stacktrace: {
frames: [{ filename: 'app:///gt-window-provider-btc.js' } as StackFrame],
},
},
],
},
}
expect(isBrowserWalletExtensionError(event)).toBe(true)
})
it('returns true for wallet-provider in abs_path', () => {
const event: SentryEvent = {
exception: {
values: [
{
type: 'Error',
value: 'wallet error',
stacktrace: {
frames: [
{ abs_path: 'chrome-extension://abc123/wallet-provider.js' } as StackFrame,
],
},
},
],
},
}
expect(isBrowserWalletExtensionError(event)).toBe(true)
})
it('returns false for regular application errors', () => {
const event: SentryEvent = {
exception: {
values: [
{
type: 'Error',
value: 'Regular error',
stacktrace: {
frames: [
{ filename: 'app:///_next/static/chunks/main.js' } as StackFrame,
{ filename: 'app:///_next/static/chunks/pages/index.js' } as StackFrame,
],
},
},
],
},
}
expect(isBrowserWalletExtensionError(event)).toBe(false)
})
it('returns false for empty event', () => {
const event: SentryEvent = {}
expect(isBrowserWalletExtensionError(event)).toBe(false)
})
it('returns false when exception values are empty', () => {
const event: SentryEvent = {
exception: {
values: [],
},
}
expect(isBrowserWalletExtensionError(event)).toBe(false)
})
it('returns false when stacktrace frames are undefined', () => {
const event: SentryEvent = {
exception: {
values: [
{
type: 'Error',
value: 'Error without stacktrace',
},
],
},
}
expect(isBrowserWalletExtensionError(event)).toBe(false)
})
})
describe('isUserAbortedOperation', () => {
it('returns true for "operation was aborted" error', () => {
const error = new Error('The operation was aborted.')
const event: SentryEvent = {}
expect(isUserAbortedOperation(error, event)).toBe(true)
})
it('returns true for "signal is aborted" error', () => {
const error = new Error('signal is aborted without reason')
const event: SentryEvent = {}
expect(isUserAbortedOperation(error, event)).toBe(true)
})
it('returns true for "manually canceled" error', () => {
const error = new Error('operation is manually canceled')
const event: SentryEvent = {}
expect(isUserAbortedOperation(error, event)).toBe(true)
})
it('returns true for "AbortError" message', () => {
const error = new Error('AbortError: The operation was aborted')
const event: SentryEvent = {}
expect(isUserAbortedOperation(error, event)).toBe(true)
})
it('returns true when message is in event.message (no error object)', () => {
const error = null
const event: SentryEvent = {
message: '[CRITICAL][sign in via EP] Failed: The operation was aborted.',
}
expect(isUserAbortedOperation(error, event)).toBe(true)
})
it('returns true for event message with "signal is aborted"', () => {
const event: SentryEvent = {
message: '[CRITICAL][sign in via EP] Failed: signal is aborted without reason',
}
expect(isUserAbortedOperation(undefined, event)).toBe(true)
})
it('returns false for regular errors', () => {
const error = new Error('Something went wrong')
const event: SentryEvent = {}
expect(isUserAbortedOperation(error, event)).toBe(false)
})
it('returns false for empty inputs', () => {
expect(isUserAbortedOperation(null, {})).toBe(false)
expect(isUserAbortedOperation(undefined, {})).toBe(false)
})
it('handles non-Error objects gracefully', () => {
const error = { message: 'The operation was aborted.' }
const event: SentryEvent = {}
// Non-Error objects should not match since we check instanceof Error
expect(isUserAbortedOperation(error, event)).toBe(false)
})
})
describe('isCancellationRejection', () => {
it('returns true for cancellation type in extra.__serialized__', () => {
const event: SentryEvent = {
extra: {
__serialized__: {
msg: 'operation is manually canceled',
type: 'cancelation',
},
},
}
expect(isCancellationRejection(event)).toBe(true)
})
it('returns false when type is not cancelation', () => {
const event: SentryEvent = {
extra: {
__serialized__: {
msg: 'some error',
type: 'error',
},
},
}
expect(isCancellationRejection(event)).toBe(false)
})
it('returns false when __serialized__ is undefined', () => {
const event: SentryEvent = {
extra: {},
}
expect(isCancellationRejection(event)).toBe(false)
})
it('returns false when extra is undefined', () => {
const event: SentryEvent = {}
expect(isCancellationRejection(event)).toBe(false)
})
it('returns false when __serialized__ has no type property', () => {
const event: SentryEvent = {
extra: {
__serialized__: {
msg: 'some message',
},
},
}
expect(isCancellationRejection(event)).toBe(false)
})
})
describe('isChallengeExpiredError', () => {
it('returns true for challenge-expired error message', () => {
const error = new Error('Non-Error promise rejection captured with value: challenge-expired')
const event: SentryEvent = {}
expect(isChallengeExpiredError(error, event)).toBe(true)
})
it('returns true when challenge-expired is in event.message', () => {
const event: SentryEvent = {
message: 'challenge-expired',
}
expect(isChallengeExpiredError(null, event)).toBe(true)
})
it('returns false for regular errors', () => {
const error = new Error('Something went wrong')
const event: SentryEvent = {}
expect(isChallengeExpiredError(error, event)).toBe(false)
})
it('returns false for empty inputs', () => {
expect(isChallengeExpiredError(null, {})).toBe(false)
expect(isChallengeExpiredError(undefined, {})).toBe(false)
})
it('returns false for similar but different messages', () => {
const error = new Error('challenge expired') // No hyphen
const event: SentryEvent = {}
expect(isChallengeExpiredError(error, event)).toBe(false)
})
})
describe('integration scenarios', () => {
it('correctly identifies SUPABASE-APP-353 pattern (cancellation rejection)', () => {
// Based on actual Sentry issue SUPABASE-APP-353
const event: SentryEvent = {
exception: {
values: [
{
type: 'UnhandledRejection',
value: 'Object captured as promise rejection with keys: msg, type',
},
],
},
extra: {
__serialized__: {
msg: 'operation is manually canceled',
type: 'cancelation',
},
},
}
expect(isCancellationRejection(event)).toBe(true)
})
it('correctly identifies SUPABASE-APP-AFC pattern (wallet extension)', () => {
// Based on actual Sentry issue SUPABASE-APP-AFC
const event: SentryEvent = {
exception: {
values: [
{
type: 'TypeError',
value: 'f.shouldSetTallyForCurrentProvider is not a function',
stacktrace: {
frames: [
{
filename:
'node_modules/.pnpm/@sentry+browser@10.27.0/node_modules/@sentry/browser/src/helpers.ts',
function: 'n',
} as StackFrame,
{
filename: 'app:///gt-window-provider-btc.js',
function: 'GateWindowProvider.internalListener',
} as StackFrame,
],
},
},
],
},
}
expect(isBrowserWalletExtensionError(event)).toBe(true)
})
it('correctly identifies SUPABASE-APP-92A pattern (wallet extension)', () => {
// Based on actual Sentry issue SUPABASE-APP-92A
const event: SentryEvent = {
exception: {
values: [
{
type: 'TypeError',
value: 'en.shouldSetTallyForCurrentProvider is not a function',
stacktrace: {
frames: [
{
filename:
'node_modules/.pnpm/@sentry+browser@10.27.0/node_modules/@sentry/browser/src/helpers.ts',
function: 'n',
} as StackFrame,
{
filename: 'app:///gt-window-provider.js',
function: 'GateWindowProvider.internalListener',
} as StackFrame,
],
},
},
],
},
}
expect(isBrowserWalletExtensionError(event)).toBe(true)
})
it('correctly identifies SUPABASE-APP-BG6 pattern (user aborted)', () => {
// Based on actual Sentry issue SUPABASE-APP-BG6
const error = new Error('The operation was aborted.')
const event: SentryEvent = {
message: '[CRITICAL][sign in via EP] Failed: The operation was aborted.',
}
expect(isUserAbortedOperation(error, event)).toBe(true)
})
it('correctly identifies SUPABASE-APP-BG7 pattern (signal aborted)', () => {
// Based on actual Sentry issue SUPABASE-APP-BG7
const error = new Error('signal is aborted without reason')
const event: SentryEvent = {
message: '[CRITICAL][sign in via EP] Failed: signal is aborted without reason',
}
expect(isUserAbortedOperation(error, event)).toBe(true)
})
it('correctly identifies SUPABASE-APP-ACC pattern (challenge expired)', () => {
// Based on actual Sentry issue SUPABASE-APP-ACC
const error = new Error('Non-Error promise rejection captured with value: challenge-expired')
const event: SentryEvent = {
exception: {
values: [
{
type: 'UnhandledRejection',
value: 'Non-Error promise rejection captured with value: challenge-expired',
},
],
},
}
expect(isChallengeExpiredError(error, event)).toBe(true)
})
it('does not filter legitimate errors', () => {
const error = new Error('Cannot read property "foo" of undefined')
const event: SentryEvent = {
exception: {
values: [
{
type: 'TypeError',
value: 'Cannot read property "foo" of undefined',
stacktrace: {
frames: [{ filename: 'app:///_next/static/chunks/pages/index.js' } as StackFrame],
},
},
],
},
}
expect(isBrowserWalletExtensionError(event)).toBe(false)
expect(isUserAbortedOperation(error, event)).toBe(false)
expect(isCancellationRejection(event)).toBe(false)
expect(isChallengeExpiredError(error, event)).toBe(false)
})
})
})
describe('buildSentryClientOptions', () => {
// Representative subset of Sentry's default integrations. `integrations`
// is the function form: Sentry.init calls it with the defaults and installs
// whatever it returns, so dropping these here would disable session
// envelopes (BrowserSession) and window.onerror capture (GlobalHandlers).
const fakeDefaultIntegrations = [{ name: 'BrowserSession' }, { name: 'GlobalHandlers' }]
const getIntegrationNames = (options: ReturnType<typeof buildSentryClientOptions>) => {
const integrations = options.integrations
if (typeof integrations !== 'function') {
throw new Error('expected the function form of integrations')
}
return integrations(fakeDefaultIntegrations).map((integration) => integration.name)
}
it('preserves the default integrations passed in by Sentry.init', () => {
for (const includeThirdPartyErrorFilter of [true, false]) {
const names = getIntegrationNames(buildSentryClientOptions({ includeThirdPartyErrorFilter }))
// browserSessionIntegration is what sends the session envelope on every
// page load; globalHandlers is window.onerror / unhandledrejection.
expect(names).toContain('BrowserSession')
expect(names).toContain('GlobalHandlers')
}
})
it('sets the release only when one is provided', () => {
const withRelease = buildSentryClientOptions({
includeThirdPartyErrorFilter: false,
release: 'abc123',
})
expect(withRelease.release).toBe('abc123')
// The key must be ABSENT when no release is passed: on the Next build a
// `release: undefined` entry would override the release injected into
// @sentry/nextjs's init by withSentryConfig (options are spread last).
const withoutRelease = buildSentryClientOptions({ includeThirdPartyErrorFilter: true })
expect('release' in withoutRelease).toBe(false)
})
it('includes the third-party error filter only when the build annotates frames', () => {
// Next build: withSentryConfig injects the applicationKey metadata.
expect(
getIntegrationNames(buildSentryClientOptions({ includeThirdPartyErrorFilter: true }))
).toContain('ThirdPartyErrorsFilter')
// TanStack/Vite build: no bundler metadata — including the integration
// would tag every event third_party_code=true and beforeSend would drop
// them all.
expect(
getIntegrationNames(buildSentryClientOptions({ includeThirdPartyErrorFilter: false }))
).not.toContain('ThirdPartyErrorsFilter')
})
it('appends build-specific extra integrations', () => {
const options = buildSentryClientOptions({
includeThirdPartyErrorFilter: false,
extraIntegrations: [{ name: 'FakeRouterTracing' }],
})
expect(getIntegrationNames(options)).toContain('FakeRouterTracing')
})
it('builds the same shared options for both builds (parity)', () => {
const nextOptions = buildSentryClientOptions({ includeThirdPartyErrorFilter: true })
const tanstackOptions = buildSentryClientOptions({ includeThirdPartyErrorFilter: false })
// Everything except the integrations array must be identical between the
// two runtimes.
const { integrations: _next, ...nextRest } = nextOptions
const { integrations: _tanstack, ...tanstackRest } = tanstackOptions
expect(Object.keys(nextRest)).toEqual(Object.keys(tanstackRest))
expect(nextRest.tracesSampleRate).toBe(tanstackRest.tracesSampleRate)
expect(nextRest.allowUrls).toEqual(tanstackRest.allowUrls)
expect(nextRest.ignoreErrors).toEqual(tanstackRest.ignoreErrors)
})
})
describe('which errors Studio sends to Sentry', () => {
let beforeSend: NonNullable<ReturnType<typeof buildSentryClientOptions>['beforeSend']>
let restoreConsent: () => void
beforeAll(async () => {
vi.spyOn(Math, 'random').mockReturnValue(0)
vi.stubEnv('NEXT_PUBLIC_IS_PLATFORM', 'true')
vi.resetModules()
const { consentState } = await import('common')
const previousConsent = consentState.hasConsented
consentState.hasConsented = true
restoreConsent = () => {
consentState.hasConsented = previousConsent
}
const { buildSentryClientOptions } = await import('./sentry-client-options')
const options = buildSentryClientOptions({ includeThirdPartyErrorFilter: true })
if (!options.beforeSend) throw new Error('Missing Sentry beforeSend')
beforeSend = options.beforeSend
})
beforeEach(() => {
vi.clearAllMocks()
})
afterAll(() => {
vi.restoreAllMocks()
restoreConsent?.()
vi.unstubAllEnvs()
vi.resetModules()
})
it('drops errors from outside the app', async () => {
expect(await beforeSend({ type: undefined, tags: { third_party_code: true } }, {})).toBeNull()
})
it.each([true, 'true'])(
'sends page crashes even when the code location is missing: %s',
async (tag) => {
const event: Parameters<typeof beforeSend>[0] = {
type: undefined,
tags: { third_party_code: true, globalErrorBoundary: tag },
exception: { values: [{ value: 'Page crashed' }] },
}
expect(await beforeSend(event, {})).toBe(event)
}
)
it('samples errors that did not crash the page once', async () => {
const event: Parameters<typeof beforeSend>[0] = {
type: undefined,
exception: {
values: [{ value: 'Application error', stacktrace: { frames: [{ filename: 'app.js' }] } }],
},
}
expect(await beforeSend(event, {})).toBe(event)
expect(Math.random).toHaveBeenCalledOnce()
expect(event.tags?.codeSampleRate).toBe('0.01')
})
it('still applies Studio filters to page crashes', async () => {
const event: Parameters<typeof beforeSend>[0] = {
type: undefined,
tags: { globalErrorBoundary: true },
exception: {
values: [
{
value: 'captcha.render is not a function',
stacktrace: { frames: [{ filename: 'api.js' }] },
},
],
},
}
expect(await beforeSend(event, {})).toBeNull()
expect(Math.random).not.toHaveBeenCalled()
})
it('drops errors with no code location when they did not crash the page', async () => {
expect(
await beforeSend({ type: undefined, exception: { values: [{ value: 'No stack' }] } }, {})
).toBeNull()
})
})