dima/supabase
1
0 Fork 0
mirror of https://github.com/supabase/supabase.git synced 2026-10-06 09:55:06 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix: LogsPreviewer filter clear button values should not persist old values

Browse Source
This commit is contained in:
TzeYiing authored and Joshen Lim committed 2022-09-20 16:05:29 +08:00
1 parent e920f31f5b
commit 4489b73c6d
2 files changed
+23 -2
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

studio/hooks/analytics/useLogsPreview.tsx
+1 -1
View File
@@ -175,7 +175,7 @@ function useLogsPreview(
return { ...resolved, ...filterOverride }
})
} else {
setFilters((prev) => ({ ...prev, ...newFilters, ...filterOverride }))
setFilters({ ...newFilters, ...filterOverride })
}
}
return [
studio/tests/pages/projects/LogsPreviewer.test.js
+22 -1
View File
@@ -350,9 +350,30 @@ test('filters alter generated query', async () => {
userEvent.click(await screen.findByText(/Save/))
await waitFor(() => {
expect(get).toHaveBeenCalledWith(expect.stringContaining('select'))
expect(get).toHaveBeenCalledWith(expect.stringContaining('500'))
expect(get).toHaveBeenCalledWith(expect.stringContaining('599'))
expect(get).toHaveBeenCalledWith(expect.stringContaining('200'))
expect(get).toHaveBeenCalledWith(expect.stringContaining('299'))
expect(get).toHaveBeenCalledWith(expect.stringContaining('where'))
expect(get).toHaveBeenCalledWith(expect.stringContaining('and'))
})
// should be able to clear the filters
userEvent.click(await screen.findByRole('button', { name: 'Status' }))
userEvent.click(await screen.findByRole('button', { name: 'Clear' }))
get.mockClear()
userEvent.click(await screen.findByRole('button', { name: 'Status' }))
userEvent.click(await screen.findByText(/400 codes/))
userEvent.click(await screen.findByText(/Save/))
await waitFor(() => {
expect(get).not.toHaveBeenCalledWith(expect.stringContaining('500'))
expect(get).not.toHaveBeenCalledWith(expect.stringContaining('599'))
expect(get).not.toHaveBeenCalledWith(expect.stringContaining('200'))
expect(get).not.toHaveBeenCalledWith(expect.stringContaining('299'))
expect(get).toHaveBeenCalledWith(expect.stringContaining('400'))
expect(get).toHaveBeenCalledWith(expect.stringContaining('499'))
expect(get).toHaveBeenCalledWith(expect.stringContaining('where'))
expect(get).toHaveBeenCalledWith(expect.stringContaining('and'))
})