mirror of
https://github.com/supabase/supabase.git
synced 2026-10-05 17:35:10 +03:00
fix(www): correct broken product carousel and partner logo image paths (#48822)
## I have read the [CONTRIBUTING.md](https://github.com/supabase/supabase/blob/master/CONTRIBUTING.md) file. YES ## What kind of change does this PR introduce? Bug fix (broken images on the database product page and the agencies solutions page). ## What is the current behavior? Five image paths point at files that are not in the repo, so they 404 in production. Four of them are carousel slides on the database product page, which means those slides render with a broken image. | referenced | actually committed | | --- | --- | | `sql-view/manaco-editor.png` | `sql-view/monaco-editor.png` | | `table-view/spreadsheet-interface.png` | `table-view/spreadsheet.png` | | `table-view/create-table.png` | `table-view/create-tables.png` | | `table-view/export.png` | `table-view/export-csv.png` | | `logos/publicity/sj-innovation.svg` | `logos/publicity/sjinnovation.svg` | All five confirmed 404 on production, and all five replacements confirmed 200. ## What is the new behavior? Each path points at the file that is actually committed. No assets added, renamed or deleted. The mapping is not guesswork, each slide's own title and text names the image: - the `manaco-editor` slide is titled "Monaco editor" with the text "Built in Monaco editor, with rich validation and autocomplete", so that is a plain spelling slip for `monaco-editor.png` - the `create-table` slide is titled and labelled "Create tables", plural, matching `create-tables.png` - the `export` slide is "Select and Export" with the text "Pick the rows you want and export them into a CSV", matching `export-csv.png` - the `spreadsheet-interface` slide is "The simplicity of a spreadsheet", matching `spreadsheet.png` I also checked the dark and light convention before picking: every other slide in both carousels uses the plain filename rather than the `-light` variant, so I stayed consistent with that and did not switch any slide to a `-light` asset. ## Additional context Files: - `apps/www/data/products/database/sql-view-carousel.json` (1) - `apps/www/data/products/database/table-view-carousel.json` (3) - `apps/www/data/solutions/agencies.tsx` (1) How I found it: compared every `/images/...` reference across `apps/www` (2152 distinct paths) against `apps/www/public`, then for each miss looked for a near match in the same directory before deciding anything, and finally live-checked both the broken path and the proposed replacement. One in the same file I could not fix: `apps/www/data/solutions/agencies.tsx` also references `logos/publicity/imaginary-space.svg`, which 404s and has no similarly named asset anywhere in that directory. That one needs the actual logo, so it is not something I can resolve from the repo. Gates run locally: `test:prettier` passes repo wide, `typecheck` passes 16/16, and the www vitest suite passes (6 files, 73 tests). I did not run `pnpm build`, which cannot complete in my environment because the docs `build:federated-content` step needs `DOCS_GITHUB_APP_PRIVATE_KEY` and fails before Next compiles. Freshman contributor, found these with a local asset scan and verified every status code myself, with Claude Code's help along the way. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Corrected image references in the SQL view and table view carousels. * Updated illustration paths for spreadsheet editing, table creation, and CSV export content. * Fixed the SJ Innovation testimonial logo so it displays correctly. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: Pamela Chia <pamelachiamayyee@gmail.com>
This commit is contained in:
1 parent
810d292121
commit
279e577fac
3 files changed
+5
-5
No files matched your search
@@ -9,7 +9,7 @@
|
||||
{
|
||||
"title": "Monaco editor",
|
||||
"label": "Monaco editor",
|
||||
"img_url": "/images/product/database/sql-view/manaco-editor.png",
|
||||
"img_url": "/images/product/database/sql-view/monaco-editor.png",
|
||||
"text": "Built in Monaco editor, with rich validation and autocomplete.",
|
||||
"url": ""
|
||||
},
|
||||
|
||||
@@ -2,14 +2,14 @@
|
||||
{
|
||||
"title": "The simplicity of a spreadsheet",
|
||||
"label": "Spreadsheet like editing",
|
||||
"img_url": "/images/product/database/table-view/spreadsheet-interface.png",
|
||||
"img_url": "/images/product/database/table-view/spreadsheet.png",
|
||||
"text": "Add, edit, and update your data with the simplicity of a no-code tool.",
|
||||
"url": "/docs/guides/database/tables"
|
||||
},
|
||||
{
|
||||
"title": "Create tables",
|
||||
"label": "Create tables",
|
||||
"img_url": "/images/product/database/table-view/create-table.png",
|
||||
"img_url": "/images/product/database/table-view/create-tables.png",
|
||||
"text": "Add tables, columns and rows right in the dashboard. Without a single line SQL.",
|
||||
"url": "/docs/guides/database/tables#creating-tables"
|
||||
},
|
||||
@@ -23,7 +23,7 @@
|
||||
{
|
||||
"title": "Select and Export",
|
||||
"label": "Select and Export",
|
||||
"img_url": "/images/product/database/table-view/export.png",
|
||||
"img_url": "/images/product/database/table-view/export-csv.png",
|
||||
"text": "Pick the rows you want and export them into a CSV. ",
|
||||
"url": ""
|
||||
}
|
||||
|
||||
@@ -113,7 +113,7 @@ const data: {
|
||||
),
|
||||
},
|
||||
{
|
||||
icon: '/images/logos/publicity/sj-innovation.svg',
|
||||
icon: '/images/logos/publicity/sjinnovation.svg',
|
||||
avatar: '/images/avatars/shahed-islam.jpeg',
|
||||
author: 'Shahed Islam',
|
||||
authorTitle: 'CEO, SJ Innovation LLC',
|
||||
|
||||
Reference in new issue
Block a user