Marcel
bf6d1f6555
Fix interactive-auth.js lint
2020-04-07 13:26:27 +02:00
Marcel
9faeac4c83
Merge branch 'develop' into fix-register-auth-with-new-spec
2020-04-07 13:15:51 +02:00
Marcel
a863cf3d72
Fix auth linter error and tests
2020-04-07 13:13:49 +02:00
David Baker
66417e6742
Merge pull request #1305 from matrix-org/dbkr/uia_ignore_poll_after_success
...
Avoid creating two devices on registration
2020-04-07 10:32:08 +01:00
David Baker
6ad4d6dd62
also fix typo
2020-04-07 10:21:57 +01:00
David Baker
59607f8dbf
Clear resolve / reject function after rejecting too
2020-04-07 10:20:58 +01:00
David Baker
62380a48d5
Merge pull request #1306 from matrix-org/dbkr/max_warnings_81
...
Lower max-warnings to 81
2020-04-07 10:19:45 +01:00
David Baker
4245372495
Lower max-warnings to 81
...
We apparently fixed 11 warnings at some point. Let's keep it that way.
2020-04-07 10:06:23 +01:00
David Baker
964a448470
Avoid creating two devices on registration
...
Ignore poll requests after a UIA session has finished. Sometimes
the app calls poll() even after the registration has succeeded
which causes the API call to happen again which, in the case of
registration, creates a phantom device.
Fixes https://github.com/vector-im/riot-web/issues/13040
2020-04-06 19:45:18 +01:00
J. Ryan Stinnett
2151f28d4c
Merge pull request #1303 from matrix-org/jryans/backup-key-not-cached
...
Move key backup key creation before caching
2020-04-06 18:41:58 +01:00
Marcel
45a92bcf9c
Fix auth check as auth == {} not works
2020-04-06 17:30:32 +02:00
Marcel
0a0441756b
Fix auth check
2020-04-06 17:23:24 +02:00
Marcel
c1de2ebbf9
Fix authdata to only be null if nothing had been added.
2020-04-06 17:14:43 +02:00
J. Ryan Stinnett
060549656e
Move key backup key creation before caching
...
For some reason, we were trying to cache the key backup key before it was
created, and as a result we wouldn't cache the key until perhaps a second time
through bootstrapping.
Fixes https://github.com/vector-im/riot-web/issues/13023
2020-04-06 16:03:24 +01:00
Marcel
557c2db955
Handle Error during user-interactive auth: TypeError: "this._data is null"
2020-04-06 15:37:52 +02:00
Marcel
ed8d064a13
Replace {} with null to be compliant with newer specs. While older also accepted null for the auth part of the registration request object
2020-04-06 15:22:04 +02:00
Zoe
7dabf507a2
Merge pull request #1298 from matrix-org/foldleft/12843-resend-requests
...
Expose function to force-reset outgoing room key requests
2020-04-06 13:43:06 +01:00
Zoe
d69afa47a1
review feedback
2020-04-06 13:30:36 +01:00
Bruno Windels
275a8175aa
Merge pull request #1302 from matrix-org/bwindels/selfverifux
...
Add isSelfVerification property to VerificationRequest
2020-04-03 16:02:05 +00:00
Bruno Windels
40bebf4cbd
Merge pull request #1297 from matrix-org/bwindels/qr-reciprocate
...
QR code reciprocation
2020-04-03 12:28:34 +00:00
Zoe
b8bc323c03
add a crypto-level function for resending key requests
2020-04-03 11:47:13 +01:00
Zoe
c6d32ea2b0
Expose function to force-reset outgoing room key requests
2020-04-02 16:25:50 +01:00
Bruno Windels
2ace35ad6b
add isSelfVerification helper
2020-04-02 17:16:06 +02:00
Bruno Windels
b5ea8d3a78
Merge branch 'bwindels/qr-reciprocate' into bwindels/selfverifux
2020-04-02 17:15:32 +02:00
Bruno Windels
f3a05f6ed0
fix jsdoc
2020-04-02 13:37:15 +02:00
Bruno Windels
43eae4929b
remove ts annotations as I don't want to convert the whole file now
2020-04-02 13:31:17 +02:00
Bruno Windels
6144962c24
cancel with m.user code when user doesn't reciprocate
2020-04-02 12:53:52 +02:00
Bruno Windels
544cc36006
explain a bit why we're doing things here
2020-04-02 11:31:44 +02:00
Hubert Chathi
1834e6688f
Merge pull request #1294 from matrix-org/uhoreg/check_sssss_passphrase
...
Add ability to check symmetric SSSS key before we try to use it
2020-04-01 16:01:34 -04:00
David Baker
e1ee56aa43
Merge pull request #1296 from matrix-org/dbkr/debug_stuck_events
...
Add some debug logging for events stuck to bottom of timeline
2020-04-01 18:54:52 +01:00
David Baker
a1779719be
Add some debug logging for events stuck to bottom of timeline
2020-04-01 18:48:59 +01:00
Bruno Windels
0e464af627
Merge pull request #1295 from matrix-org/bwindels/fixdoublerequestexplosion
...
Fix: spontanous verification request cancellation under some circumstances
2020-04-01 17:17:24 +00:00
Bruno Windels
fd7f0c3b5a
Ignore phase while checking if other party supports scanning
...
(as the phase hasn't been set yet)
Also, set the qrCodeData in handleEvent as we need it to be async
2020-04-01 19:01:53 +02:00
Bruno Windels
ed210a4fb1
Use static constructor that can be async (as looking up device is async)
...
Also fix static methods not to use this
2020-04-01 19:00:57 +02:00
Bruno Windels
c2a0504980
update comments
2020-04-01 18:23:34 +02:00
Bruno Windels
b6708871d3
fix olmlib import
2020-04-01 18:23:34 +02:00
Bruno Windels
275ea6aacb
spec recommends 11 random bytes for shared secret
2020-04-01 18:23:34 +02:00
Bruno Windels
f97d413603
expose chosen method after request has started
...
so we can show a different ux now that it's not just SAS anymore,
but also reciprocate
2020-04-01 18:23:34 +02:00
Bruno Windels
2c7ea0606b
move shared secret to QRCodeData
2020-04-01 18:23:34 +02:00
Bruno Windels
d7a7100912
reuse keys from qr code data to sign
...
so we don't sign the wrong keys if a malicious HS admin
forged a cross-sign identity reset
2020-04-01 18:23:34 +02:00
Bruno Windels
2c54b8d77e
ask the user if the other user scanned the QR code
2020-04-01 18:23:34 +02:00
Bruno Windels
b30f278e03
checking the userid isn't a thing anymore AFAIK
2020-04-01 18:23:34 +02:00
Bruno Windels
b642030a34
keep a copy of the master/device key and mode, for use in reciprocate
2020-04-01 18:23:34 +02:00
Bruno Windels
725976d472
Add QR code buffer generation to VerificationRequest (from react-sdk)
...
Doing this so later we can keep the other user master signing key on it
so we can make sure we cross-sign that one once we decide to sign.
2020-04-01 18:23:34 +02:00
Bruno Windels
80d87e1bf1
prevent the same event being handled twice in the verification request, result in cancellation
2020-04-01 17:13:24 +02:00
Hubert Chathi
d01f527e71
only try to set keyInfo if it exists
2020-03-31 16:54:06 -04:00
Hubert Chathi
3e68c82171
apply changes from code review
2020-03-31 16:34:41 -04:00
Hubert Chathi
51bde23207
Merge branch 'develop' into uhoreg/check_sssss_passphrase
2020-03-31 10:41:39 -04:00
J. Ryan Stinnett
934ed37fdc
Merge pull request #1293 from matrix-org/jryans/4s-prompt-overload
...
Receive private key for caching from the app layer
2020-03-31 11:04:51 +01:00
J. Ryan Stinnett
4a965f5408
Convert secret storage key creation to object
2020-03-31 10:45:02 +01:00