dima/supabase

0 Fork 0

mirror of https://github.com/supabase/supabase.git synced 2026-10-05 17:35:10 +03:00

Files

T

Danny White 3a72b128de chore(studio): standardise key-value field array partial-row validation (#44411 )

## What kind of change does this PR introduce?

Design system and validation consistency update.

## What is the current behaviour?

`KeyValueFieldArray` already renders per-cell form messages, but each
consumer still decides its own validation rules. At the moment, some
consumers allow partially filled rows to submit silently, while Log
Drains now treats them as inline validation errors.

## What is the new behaviour?

This PR standardises the recommended partial-row behaviour for the
current `KeyValueFieldArray` consumers by introducing a shared
validation helper and using it from each form schema.

- adds `getKeyValueFieldArrayValidationIssues` alongside
`KeyValueFieldArray`
- keeps `KeyValueFieldArray` presentation-only and leaves validation in
consumer schemas
- shows inline errors when one side of a key/value row is filled and the
other is empty
- keeps fully empty rows as draft rows
- keeps duplicate-key validation in Log Drains, where it already applies
- updates the design-system docs and examples to describe the validation
pattern explicitly


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Added reusable key/value validation utilities and public export; forms
now trim header/key/value inputs, show inline errors for partially
filled rows, and remove fully empty draft rows on submit.

* **Documentation**
* Clarified the field-array is rendering-only and added guidance for
placing validation in form schemas and handling draft rows.

* **Tests**
* Added unit and integration tests covering validation rules, duplicate
keys, trimming, draft-row stripping, and payload behavior.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

2026-04-02 12:49:25 +11:00

scripts

chore: Migrate studio to use ui-patterns/shimmeringLoader (#41405 )

2025-12-17 14:54:07 +01:00

src

chore(studio): standardise key-value field array partial-row validation (#44411 )

2026-04-02 12:49:25 +11:00

index.tsx

chore: Clean the ui package from next imports (#44278 )

2026-03-30 10:58:37 +02:00

package.json

chore(studio): standardise key-value field array partial-row validation (#44411 )

2026-04-02 12:49:25 +11:00

README.md

feat: Move some components into ui-patterns (#20774 )

2024-02-12 12:44:00 +01:00

tailwind.config.js

SQL to REST translator (#25978 )

2024-05-22 12:37:01 -06:00

tsconfig.json

chore: Bump Typescript to v6 (#44204 )

2026-03-26 15:27:35 +01:00

vitest.config.ts

add coverage option to ui-patterns (#35669 )

2025-05-29 19:09:26 +02:00

vitest.setup.ts

chire: Sort imports in all packages, cms, design-system and ui-library apps (#41610 )

2026-02-05 13:54:10 +01:00

README.md

Supabase UI Patterns

This package should be used for components which are built using NPM libraries (react-markdown, reactflow for example), which make no sense to be included in all apps. It should also be used for components which are constructed using various components from the ui package.

This package does not have a barrel file - each component has to be imported from its index (ui-patterns/PrivacySettings, for example). This is intentional so that adding a new component which is used only in 1 or 2 apps doesn't burden the rest of the apps.