mirror of
https://github.com/supabase/supabase.git
synced 2026-10-08 10:55:06 +03:00
Ali Waseem
359c933e77
Extends the SQL editor's destructive query detection to catch dangerous operations (DROP, DELETE, TRUNCATE) hidden within dynamic SQL execution patterns like `EXECUTE`, `EXECUTE format()`, `OPEN cursor FOR EXECUTE`, and `RETURN QUERY EXECUTE`. Previously, only direct statements like `DROP TABLE users` triggered warnings. Dynamic SQL inside PL/pgSQL blocks bypassed detection entirely. Closes FE-3603 and https://github.com/supabase/supabase/issues/46876 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Improved detection of potentially destructive SQL across many execution styles, including DROP/DELETE/TRUNCATE, ALTER ... DROP COLUMN, and dynamic/executed or string-constructed queries to reduce missed destructive cases. * **Tests** * Expanded test coverage for SQL validation with extensive positive and negative scenarios covering dynamic execution patterns (EXECUTE variants, concatenation, dollar-quoted and escaped strings) to reduce false positives and negatives. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Writing components
Where to create your components
- For components that declare the general structure and layout of a page:
/components/layouts/xxx
- For components that are tightly coupled to a specific interface:
/components/interfaces/xxx
- For components that are meant to be reusable across multiple pages:
/components/ui/xxx
- Note: We're gradually moving files out of the
to-be-cleanedfolder into the respective folders as we refactor
Component structure
- If a component has constants and utility methods that are tightly coupled to itself, keep them close to the component and enclose them in a folder with an
index.tsxas an entry point - Otherwise it can just be a file on its own
- For example:
-
components/ui - SampleComponentA - SampleComponentA.tsx - SampleComponentA.constants.ts - SampleComponentA.utils.ts - SampleComponentA.types.ts - index.ts - SampleComponentB.tsx
-
Template for building components
// Declare the prop types of your component
interface ComponentAProps {
sampleProp: string
}
// Name your component accordingly
const ComponentA = ({ sampleProp }: ComponentAProps) => {
return <div>ComponentA: {sampleProp}</div>
}
export default ComponentA