mirror of
https://github.com/supabase/supabase.git
synced 2026-10-08 10:55:06 +03:00
Cemal Kılıç
ca5f8d66f1
## I have read the [CONTRIBUTING.md](https://github.com/supabase/supabase/blob/master/CONTRIBUTING.md) file. YES ## Summary - Fix `ToggleLegacyApiKeysPanel` being permanently hidden for users with project-level admin access but no org-level access - The `useAuthorizedAppsQuery` calls an org-level endpoint (`/platform/organizations/{slug}/oauth/apps`) which returns 403 for project-only admins, causing `isAuthorizedAppsSuccess` to never become `true` and the entire panel to never render - When the authorized apps query fails, show a fallback warning directing users to verify their org's OAuth apps before disabling legacy keys ## What changed - Removed `isAuthorizedAppsSuccess` from the rendering guard, the panel now renders once legacy keys status and permissions resolve - When the authorized apps query errors (e.g. 403), the button still opens a warning dialog with appropriate copy before proceeding to the confirmation modal ## Behavior | User type | Authorized apps query | Button click | |---|---|---| | Org-level access, has apps | Success, apps > 0 | Warning → confirm modal | | Org-level access, no apps | Success, apps = 0 | Confirm modal directly | | Project-only admin | 403 error | Fallback warning → confirm modal | ## Current behavior <img width="1461" height="707" alt="image-IcxHfCX0" src="https://github.com/user-attachments/assets/2fd124cd-02eb-46c0-816e-178fe3ce99b0" /> Project admins can't view the button ## Changed behaaviour <img width="1455" height="704" alt="image-YW1k6GQe" src="https://github.com/user-attachments/assets/8c428c63-f1de-4b84-a1f2-6af7ff064e50" /> Projects admins can view the disable button and when clicked views a warning about oauth apps: <img width="451" height="250" alt="image-yu4bux3l" src="https://github.com/user-attachments/assets/5a314329-350b-4207-b8e4-311d0c827e6f" /> and when they visit oauth apps, there is warning to contact with project owner <img width="1453" height="578" alt="image-pppzfksn" src="https://github.com/user-attachments/assets/489ba3ba-c94e-4efb-923b-a989eebb2fc4" />