mirror of
https://github.com/supabase/supabase.git
synced 2026-10-06 09:55:06 +03:00
Problem:
- new filters are creating an infinite fetch loop of ph.supabase.io
# Before:
snap.filters change → effect → setParams() → router.push()
→ URL updates → filters/sorts recalc → setParams recreated
→ effect re-runs → INFINITE LOOP 🔄
# After:
snap.filters change → effect → comparison shows change → timeout
scheduled
→ setParams() → router.push(shallow: true) → URL updates
→ filters/sorts recalc → setParams recreated → effect runs
→ comparison check: no content change → early return → LOOP BROKEN ✓
The deep comparison prevents the effect from re-executing when only the
dependency references change
(due to URL updates), not the actual filter content. Test it out and the
PostHog spam should stop!
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
## Bug Fixes
* **Prevented unnecessary URL updates** when filter state remains
unchanged, improving application responsiveness.
* **Optimized filter and sort parameter handling** with enhanced
callback efficiency and routing behavior.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Table Filtering and Sorting Developer notes
Overview
The table filtering and sorting system uses a URL-based state persistence pattern combined with custom hooks that abstract the implementation details from consuming components. This architecture provides several benefits:
- Persistent state: Filters and sorts are stored in URL parameters, enabling bookmarking and sharing
- Separation of concerns: Logic is separated from UI components
- Draft-then-apply pattern: UI components maintain draft state until explicitly applied
Core Hooks
useTableFilter
// Returns: { filters, urlFilters, onApplyFilters }
The useTableFilter hook manages filter state with these responsibilities:
- Retrieves raw filter parameters from URL
- Formats filter parameters into usable Filter[] objects
- Provides a callback to apply new filters
- Persists changes to URL parameters
- Triggers side effects through
saveFiltersAndTriggerSideEffects
Key design aspects:
- No direct snapshot interaction, keeping it focused solely on filter management
- Uses URL parameters as the source of truth
- Forwards filter changes to URL and triggers application-specific side effects
useTableSort
// Returns: { sorts, urlSorts, onApplySorts }
The useTableSort hook manages sort state with these responsibilities:
- Retrieves raw filter parameters from URL
- Formats sort parameters into usable Sort[] objects (needs table name)
- Provides a callback to apply new sorts
- Persists changes to URL parameters
- Triggers side effects through
saveSortsAndTriggerSideEffects
Key design aspects:
- Handles applying table name to sort objects
- Maintains URL parameters as source of truth
- Forwards sort changes to URL and triggers application-specific side effects
Component Implementation
FilterPopoverPrimitive and SortPopoverPrimitive
These components follow a "draft and apply" pattern:
- Local state management: Both components maintain a local state copy of filters/sorts
- Edit operations: Changes like adding, modifying, or deleting are made to the local state
- Apply operations: Only when the user clicks "Apply" are the changes committed via the callback
- Synchronization: Local state is synchronized with props when external changes occur
Data Flow
- URL parameters store the raw filter/sort state
- Hooks read and format these parameters into usable objects
- UI components receive formatted objects and callbacks
- Components maintain draft state for editing
- When "Apply" is clicked, callbacks update URL parameters
- Side effects are triggered via dedicated save hooks
Component Usage
Components using these hooks should follow this pattern:
function TableComponent() {
// Get filter data and callbacks
const { filters, onApplyFilters } = useTableFilter()
// Get sort data and callbacks
const { sorts, onApplySorts } = useTableSort()
return (
<>
<FilterPopoverPrimitive filters={filters} onApplyFilters={onApplyFilters} />
<SortPopoverPrimitive sorts={sorts} onApplySorts={onApplySorts} />
{/* Table rendering with filters and sorts applied */}
</>
)
}
Implementation Notes
- Filter and sort parameters are stored in URL using specific formats
- Conversion utilities (
formatFilterURLParams,formatSortURLParams, etc.) handle translation between URL strings and typed objects - Side effect hooks manage database persistence and related operations