Files
supabase/apps/studio/components/interfaces/TableGridEditor/ViewEntityAutofixSecurityModal.tsx
T
Terry SuttonandCharis 4e12a1f5a2 Chore/autofix views (#33363)
* Autofix security status of views

* Update apps/studio/components/interfaces/TableGridEditor/ViewEntityAutofixSecurityModal.tsx

Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>

---------

Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>
2025-02-05 18:21:39 +00:00

93 lines
3.3 KiB
TypeScript

import { useQueryClient } from '@tanstack/react-query'
import { useProjectContext } from 'components/layouts/ProjectLayout/ProjectContext'
import { useViewDefinitionQuery } from 'data/database/view-definition-query'
import { useExecuteSqlMutation } from 'data/sql/execute-sql-mutation'
import { Entity } from 'data/table-editor/table-editor-types'
import { toast } from 'sonner'
import { ScrollArea, SimpleCodeBlock } from 'ui'
import ConfirmationModal from 'ui-patterns/Dialogs/ConfirmationModal'
import { lintKeys } from '../../../data/lint/keys'
interface ViewEntityAutofixSecurityModalProps {
table: Entity
isAutofixViewSecurityModalOpen: boolean
setIsAutofixViewSecurityModalOpen: (isAutofixViewSecurityModalOpen: boolean) => void
}
export default function ViewEntityAutofixSecurityModal({
table,
isAutofixViewSecurityModalOpen,
setIsAutofixViewSecurityModalOpen,
}: ViewEntityAutofixSecurityModalProps) {
const { project } = useProjectContext()
const queryClient = useQueryClient()
const viewDefinition = useViewDefinitionQuery({
id: table?.id,
projectRef: project?.ref,
connectionString: project?.connectionString,
})
const { mutate: execute } = useExecuteSqlMutation({
onSuccess: async () => {
toast.success('View security changed successfully')
setIsAutofixViewSecurityModalOpen(false)
await queryClient.invalidateQueries(lintKeys.lint(project?.ref))
},
onError: (error) => {
toast.error(`Failed to autofix view security: ${error.message}`)
},
})
function handleConfirm() {
const sql = `
ALTER VIEW "${table.schema}"."${table.name}" SET (security_invoker = on);
`
execute({
projectRef: project?.ref,
connectionString: project?.connectionString,
sql,
})
}
return (
<ConfirmationModal
visible={isAutofixViewSecurityModalOpen}
size="xlarge"
title="Confirm autofixing view security"
confirmLabel="Confirm"
onCancel={() => setIsAutofixViewSecurityModalOpen(false)}
onConfirm={() => {
handleConfirm()
}}
>
<p className="text-sm text-foreground-light">
Setting <code>security_invoker=on</code> ensures the View runs with the permissions of the
querying user, reducing the risk of unintended data exposure.
</p>
<div className="flex items-center gap-8 mt-8">
<div className=" border rounded-md w-1/2">
<div className="p-4 bg-200 font-mono text-sm font-semibold">Existing query</div>
<ScrollArea className="h-[225px] px-4 py-2">
{viewDefinition.data && (
<SimpleCodeBlock>
{`create view ${table.schema}.${table.name} as\n ${viewDefinition.data}`}
</SimpleCodeBlock>
)}
</ScrollArea>
</div>
<div className=" border rounded-md w-1/2">
<div className="p-4 bg-200 font-mono text-sm font-semibold">Updated query</div>
<ScrollArea className="h-[225px] px-4 py-2">
{viewDefinition.data && (
<SimpleCodeBlock>
{`create view ${table.schema}.${table.name} with (security_invoker = on) as\n ${viewDefinition.data}`}
</SimpleCodeBlock>
)}
</ScrollArea>
</div>
</div>
</ConfirmationModal>
)
}