mirror of
https://github.com/supabase/supabase.git
synced 2026-10-08 10:55:06 +03:00
Danny White
272bb26635
## Problem During active incidents, the Studio status banner read: > We are investigating a technical issue · Follow the status page for updates Status page The trailing "Status page" goes alongside plain-text copy that already mentioned "status page". ## Solution Match the emergency-override and legacy banners: make "status page" the inline link inside the sentence, and drop the trailing link. Added a regression test covering the link text and href. | Figure | | --- | | <img width="1280" height="288" alt="6696" src="https://github.com/user-attachments/assets/e267f0d0-5484-45a5-969f-03e184b903dd" /> | | _Before_ | | <img width="1280" height="288" alt="47231" src="https://github.com/user-attachments/assets/2beee89e-3674-43f5-9d13-6dc04d153549" /> | | _After_ | ## Review instructions As of writing this: we have an active indident so you could just log in to the [staging preview](https://studio-staging-git-dnywh-dd493a51-supabase.vercel.app/). Otherwise: 1. Open `apps/studio/components/layouts/AppLayout/StatusBanner.tsx` and confirm the incident description is `Follow the [status page] for updates` with no trailing "Status page" link. 2. Optionally run `pnpm --filter studio exec vitest run components/layouts/AppLayout/StatusBanner.test.tsx`. 3. If you have a local Studio with an active incident (or `ongoingIncident` override), confirm the banner shows a single linked "status page" and no duplicate trailing link.
Writing components
Where to create your components
- For components that declare the general structure and layout of a page:
/components/layouts/xxx
- For components that are tightly coupled to a specific interface:
/components/interfaces/xxx
- For components that are meant to be reusable across multiple pages:
/components/ui/xxx
- Note: We're gradually moving files out of the
to-be-cleanedfolder into the respective folders as we refactor
Component structure
- If a component has constants and utility methods that are tightly coupled to itself, keep them close to the component and enclose them in a folder with an
index.tsxas an entry point - Otherwise it can just be a file on its own
- For example:
-
components/ui - SampleComponentA - SampleComponentA.tsx - SampleComponentA.constants.ts - SampleComponentA.utils.ts - SampleComponentA.types.ts - index.ts - SampleComponentB.tsx
-
Template for building components
// Declare the prop types of your component
interface ComponentAProps {
sampleProp: string
}
// Name your component accordingly — use a named export, not a default export
export const ComponentA = ({ sampleProp }: ComponentAProps) => {
return <div>ComponentA: {sampleProp}</div>
}