## What kind of change does this PR introduce? Bug fix for the pipeline destination form. ## What is the current behavior? Clearing a numeric field under Advanced settings restores its previous value immediately, so users cannot replace the value normally. ## What is the new behavior? Numeric fields use an empty string as their controlled blank value while editing, so users can clear an existing value before entering its replacement. Existing field-specific validation messages are preserved for invalid or empty required values. Maximum staleness remains optional and can be left blank. Adds component and schema coverage for all five numeric Advanced settings fields, including the BigQuery-only fields. ## To test 1. Open Database > Replication and start a new pipeline. 2. Select BigQuery and expand Advanced settings. 3. Clear each numeric field and confirm it can be edited without reverting to its previous value. Required fields may show their existing validation message while empty. 4. Enter a replacement value such as `5` and confirm the field accepts it. 5. Leave a required numeric field blank and confirm the existing field-specific validation message appears. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Improved validation for replication destination settings, with clearer errors when required numeric fields are left empty. - Validation now updates immediately when numeric values are cleared or corrected. - BigQuery connection pool size must be greater than zero. - Empty maximum staleness values are accepted and handled correctly. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Joshen Lim <joshenlimek@gmail.com>
UI Testing Notes
Rules
-
All tests should be run consistently (avoid situations whereby tests fails "sometimes")
-
Group tests in folders based on the feature they are testing. Avoid file/folder based folder names since those can change and we will forget to update the tests.
Examples: /logs /reports /projects /database-settings /auth
Custom Render and Custom Render Hook
customRender and customRenderHook are wrappers around render and renderHook that add some necessary providers like QueryClientProvider, TooltipProvider and NuqsTestingAdapter.
Generally use those instead of the default render and renderHook functions.
import { customRender, customRenderHook } from 'tests/lib/custom-render'
customRender(<MyComponent />)
customRenderHook(() => useMyHook())
Mocking API Requests
To mock API requests, we use the msw library.
Global mocks can be found in tests/lib/msw-global-api-mocks.ts.
To mock an endpoint you can use the addAPIMock function. Make sure to add the mock in the beforeEach hook. It won't work with beforeAll if you have many tests.
beforeEach(() => {
addAPIMock({
method: 'get',
path: '/api/my-endpoint',
response: {
data: { foo: 'bar' },
},
})
})
API Mocking Tips:
- Keep mocks in the same folder as the tests that use them
- Add a test to verify the mock is working
This will make debugging and updating the mocks easier.
test('mock is working', async () => {
const response = await fetch('/api/my-endpoint')
expect(response.json()).resolves.toEqual({ data: { foo: 'bar' } })
})
Mocking Nuqs URL Parameters
To render a component that uses Nuqs with some predefined query parameters, you can use customRender with the nuqs prop.
customRender(<MyComponent />, {
nuqs: {
searchParams: {
search: 'hello world',
},
},
})
<Popover> vs <Dropdown>
When simulating clicks on these components, do the following:
// for Popovers
import userEvent from '@testing-library/user-event'
await userEvent.click('Hello world')
// for Dropdowns
import clickDropdown from 'tests/helpers'
clickDropdown('Hello world')