mirror of
https://github.com/supabase/supabase.git
synced 2026-10-06 18:05:11 +03:00
## What kind of change does this PR introduce? Mechanical cleanup on top of the Button default-variant change (#50160). ## What is the current behavior? Many callsites still pass `variant="default"` even though that is now the component default. ## What is the new behavior? Removes redundant static `variant="default"` from legacy `Button` and `ButtonTooltip` callsites. Keeps explicit defaults where they document the API: - `button-default.tsx` and `button-sizes.tsx` demos - `DocsButton`, which pins neutral styling at the wrapper boundary ## To test Studio: - [Auth → Rate Limits](https://studio-staging-2s957kwc4-supabase.vercel.app/dashboard/project/_/auth/rate-limits): dirty the form so Cancel appears; Cancel stays neutral, Save stays green - [Project Settings → API Keys](https://studio-staging-2s957kwc4-supabase.vercel.app/dashboard/project/_/settings/api-keys): `DocsButton` in the header actions stays neutral Design system: - [Design system → Button](https://design-system-git-dnywh-dc924ac1-supabase.vercel.app/design-system/docs/components/button): `button-default` / `button-sizes` still show explicit default styling; Primary (green) is restricted to the Primary section (and `asChild`) WWW: - [www → Brand assets](https://zone-www-dot-com-git-dnywh-dc924ac1-supabase.vercel.app/brand-assets): Download logo kit / Download button kit stay neutral
186 lines
5.9 KiB
TypeScript
186 lines
5.9 KiB
TypeScript
import { zodResolver } from '@hookform/resolvers/zod'
|
|
import { PermissionAction } from '@supabase/shared-types/out/constants'
|
|
import { useParams } from 'common'
|
|
import { Plus } from 'lucide-react'
|
|
import { useState } from 'react'
|
|
import { useForm } from 'react-hook-form'
|
|
import {
|
|
Button,
|
|
Dialog,
|
|
DialogContent,
|
|
DialogDescription,
|
|
DialogFooter,
|
|
DialogHeader,
|
|
DialogSection,
|
|
DialogSectionSeparator,
|
|
DialogTitle,
|
|
DialogTrigger,
|
|
Form,
|
|
FormField,
|
|
Tooltip,
|
|
TooltipContent,
|
|
TooltipTrigger,
|
|
} from 'ui'
|
|
import { Input } from 'ui-patterns/DataInputs/Input'
|
|
import { FormItemLayout } from 'ui-patterns/form/FormItemLayout/FormItemLayout'
|
|
import { z } from 'zod'
|
|
|
|
import { useProjectStorageConfigQuery } from '@/data/config/project-storage-config-query'
|
|
import { useS3AccessKeyCreateMutation } from '@/data/storage/s3-access-key-create-mutation'
|
|
import { useAsyncCheckPermissions } from '@/hooks/misc/useCheckPermissions'
|
|
import { useIsProjectActive } from '@/hooks/misc/useSelectedProject'
|
|
|
|
interface CreateCredentialModalProps {
|
|
visible: boolean
|
|
onOpenChange: (value: boolean) => void
|
|
}
|
|
|
|
export const CreateCredentialModal = ({ visible, onOpenChange }: CreateCredentialModalProps) => {
|
|
const { ref: projectRef } = useParams()
|
|
const isProjectActive = useIsProjectActive()
|
|
const [showSuccess, setShowSuccess] = useState(false)
|
|
|
|
const { can: canCreateCredentials } = useAsyncCheckPermissions(
|
|
PermissionAction.STORAGE_ADMIN_WRITE,
|
|
'*'
|
|
)
|
|
|
|
const { data: config } = useProjectStorageConfigQuery({ projectRef })
|
|
const isS3ConnectionEnabled = config?.features.s3Protocol.enabled
|
|
const disableCreation = !isProjectActive || !canCreateCredentials || !isS3ConnectionEnabled
|
|
|
|
const FormSchema = z.object({
|
|
description: z.string().min(3, {
|
|
message: 'Description must be at least 3 characters long',
|
|
}),
|
|
})
|
|
const form = useForm<z.infer<typeof FormSchema>>({
|
|
resolver: zodResolver(FormSchema),
|
|
defaultValues: {
|
|
description: '',
|
|
},
|
|
})
|
|
|
|
const {
|
|
data: createS3KeyData,
|
|
mutate: createS3AccessKey,
|
|
isPending: isCreating,
|
|
} = useS3AccessKeyCreateMutation({
|
|
onSuccess: () => {
|
|
setShowSuccess(true)
|
|
form.reset()
|
|
},
|
|
})
|
|
|
|
async function onSubmit(data: z.infer<typeof FormSchema>) {
|
|
createS3AccessKey({ projectRef, ...data })
|
|
}
|
|
|
|
return (
|
|
<Dialog
|
|
open={visible}
|
|
onOpenChange={(open) => {
|
|
onOpenChange(open)
|
|
if (!open) setShowSuccess(false)
|
|
}}
|
|
>
|
|
<Tooltip>
|
|
<TooltipTrigger asChild>
|
|
<DialogTrigger asChild>
|
|
<Button
|
|
icon={<Plus size={14} />}
|
|
disabled={disableCreation}
|
|
className="pointer-events-auto"
|
|
>
|
|
New access key
|
|
</Button>
|
|
</DialogTrigger>
|
|
</TooltipTrigger>
|
|
{disableCreation && (
|
|
<TooltipContent side="bottom">
|
|
{!isProjectActive
|
|
? 'Restore your project to create new access keys'
|
|
: !isS3ConnectionEnabled
|
|
? 'Connection via S3 protocol is currently disabled'
|
|
: !canCreateCredentials
|
|
? 'You need additional permissions to create new access keys'
|
|
: ''}
|
|
</TooltipContent>
|
|
)}
|
|
</Tooltip>
|
|
|
|
<DialogContent
|
|
onInteractOutside={(e) => {
|
|
if (showSuccess) e.preventDefault()
|
|
}}
|
|
>
|
|
{showSuccess ? (
|
|
<>
|
|
<DialogHeader>
|
|
<DialogTitle>Save your new S3 access keys</DialogTitle>
|
|
<DialogDescription>
|
|
You won't be able to see them again. If you lose these access keys, you'll need to
|
|
create a new ones.
|
|
</DialogDescription>
|
|
</DialogHeader>
|
|
<DialogSectionSeparator />
|
|
<DialogSection className="flex flex-col gap-4">
|
|
<FormItemLayout label="Access key ID" isReactForm={false}>
|
|
<Input className="input-mono" readOnly copy value={createS3KeyData?.access_key} />
|
|
</FormItemLayout>
|
|
<FormItemLayout label={'Secret access key'} isReactForm={false}>
|
|
<Input className="input-mono" readOnly copy value={createS3KeyData?.secret_key} />
|
|
</FormItemLayout>
|
|
</DialogSection>
|
|
<DialogFooter>
|
|
<Button
|
|
onClick={() => {
|
|
onOpenChange(false)
|
|
setShowSuccess(false)
|
|
}}
|
|
>
|
|
Done
|
|
</Button>
|
|
</DialogFooter>
|
|
</>
|
|
) : (
|
|
<>
|
|
<DialogHeader>
|
|
<DialogTitle>Create new S3 access keys</DialogTitle>
|
|
<DialogDescription>
|
|
S3 access keys provide full access to all S3 operations across all buckets and
|
|
bypass any existing RLS policies.
|
|
</DialogDescription>
|
|
</DialogHeader>
|
|
<DialogSectionSeparator />
|
|
<Form {...form}>
|
|
<form onSubmit={form.handleSubmit(onSubmit)}>
|
|
<DialogSection>
|
|
<FormField
|
|
name="description"
|
|
render={({ field }) => (
|
|
<FormItemLayout label="Description">
|
|
<Input
|
|
autoComplete="off"
|
|
placeholder="My test key"
|
|
type="text"
|
|
{...field}
|
|
/>
|
|
</FormItemLayout>
|
|
)}
|
|
/>
|
|
</DialogSection>
|
|
<DialogFooter>
|
|
<Button variant="primary" type="submit" loading={isCreating}>
|
|
Create access key
|
|
</Button>
|
|
</DialogFooter>
|
|
</form>
|
|
</Form>
|
|
</>
|
|
)}
|
|
</DialogContent>
|
|
</Dialog>
|
|
)
|
|
}
|