Files
supabase/apps/studio/components/interfaces/Auth/Users/InviteUserModal.tsx
T
Danny White 1131e3e2ce fix(ui): default Button variant to default instead of primary (#50160)
## What kind of change does this PR introduce?

Bug fix / design-system alignment for the legacy `Button` from `ui`.

## What is the current behavior?

Omitting `variant` on the legacy `Button` falls back to brand-green
`primary`. That makes accidental greens easy, and it is hard to spot the
real main action on busy pages.

## What is the new behavior?

- Legacy `Button` now defaults to neutral `default`
- Intentional primary CTAs (create, save, submit, marketing CTAs, and
matching `ButtonTooltip` usages) now set `variant="primary"` so their
appearance is unchanged
- Neutral actions that previously relied on the old fallback (cancel,
close, back, dashboard nav, and similar) become grey/white
- Design-system docs updated; regression tests cover the new default

`Button_Shadcn_` is unchanged. It already uses its own CVA default.

This is PR 1 of 2 in a stack. PR 2 drops now-redundant
`variant="default"` props.

## To test

Studio (http://localhost:8082):

- `/sign-in`: Sign in stays green
- Open a project → Database → Tables: New table stays green
- Auth → Users → Invite: Invite user stays green; Cancel / dismiss
controls stay neutral
- Project Settings → General: edit a field so Cancel and Save appear.
Cancel is neutral, Save is green

Design system (http://localhost:3003):

- Components → Button: default demo is neutral; primary demo is green;
featured preview is the default variant

Marketing (optional):

- www header: Start your project stays green; logged-in Dashboard is
neutral

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Style**
- Buttons now default to a neutral style, while primary actions across
Studio, documentation, marketing pages, forms, dialogs, and error states
use prominent primary styling.
- Updated button examples and previews clarify the distinction between
default and primary variants.
  - Event registration now includes a directional arrow icon.

- **Tests**
- Added coverage confirming default button styling and explicit primary
styling behave as expected.
- Updated related test fixtures to use primary styling where
appropriate.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2026-09-10 11:23:17 +10:00

114 lines
3.2 KiB
TypeScript

import { zodResolver } from '@hookform/resolvers/zod'
import { PermissionAction } from '@supabase/shared-types/out/constants'
import { useParams } from 'common'
import { SubmitHandler, useForm } from 'react-hook-form'
import { toast } from 'sonner'
import {
Button,
Dialog,
DialogContent,
DialogFooter,
DialogHeader,
DialogSection,
DialogSectionSeparator,
DialogTitle,
Form,
FormControl,
FormField,
Input,
} from 'ui'
import { FormItemLayout } from 'ui-patterns/form/FormItemLayout/FormItemLayout'
import * as z from 'zod'
import { useUserInviteMutation } from '@/data/auth/user-invite-mutation'
import { useAsyncCheckPermissions } from '@/hooks/misc/useCheckPermissions'
export type InviteUserModalProps = {
visible: boolean
setVisible: (visible: boolean) => void
}
const formSchema = z.object({
email: z.string().min(1, 'Please enter a valid email').email('Please enter a valid email'),
})
const formId = 'invite-user-form'
const InviteUserModal = ({ visible, setVisible }: InviteUserModalProps) => {
const { ref: projectRef } = useParams()
const form = useForm<z.infer<typeof formSchema>>({
resolver: zodResolver(formSchema),
defaultValues: {
email: '',
},
})
const handleToggle = () => setVisible(!visible)
const { mutate: inviteUser, isPending: isInviting } = useUserInviteMutation({
onSuccess: (_, variables) => {
toast.success(`Sent invite email to ${variables.email}`)
setVisible(false)
},
})
const { can: canInviteUsers } = useAsyncCheckPermissions(
PermissionAction.AUTH_EXECUTE,
'invite_user'
)
const onInviteUser: SubmitHandler<z.infer<typeof formSchema>> = async (values) => {
if (!projectRef) return console.error('Project ref is required')
inviteUser(
{ projectRef, email: values.email },
{
onSuccess: () => {
form.reset()
},
}
)
}
return (
<Dialog key="invite-user-modal" open={visible} onOpenChange={handleToggle}>
<DialogContent size="small">
<DialogHeader>
<DialogTitle>Invite a new user</DialogTitle>
</DialogHeader>
<DialogSectionSeparator />
<Form {...form}>
<DialogSection>
<form id={formId} onSubmit={form.handleSubmit(onInviteUser)} noValidate>
<FormField
control={form.control}
name="email"
render={({ field }) => (
<FormItemLayout layout="vertical" label="User email">
<FormControl className="relative col-span-6">
<Input {...field} />
</FormControl>
</FormItemLayout>
)}
/>
</form>
</DialogSection>
<DialogFooter>
<Button variant="default" onClick={handleToggle}>
Cancel
</Button>
<Button
variant="primary"
form={formId}
type="submit"
loading={isInviting}
disabled={!canInviteUsers || isInviting}
>
Invite user
</Button>
</DialogFooter>
</Form>
</DialogContent>
</Dialog>
)
}
export default InviteUserModal