mirror of
https://github.com/supabase/supabase.git
synced 2026-10-13 05:09:12 +03:00
Danny WhiteandJoshen Lim
bd57a73521
* feat: basic clarity improvements * feat: all switches * feat: basic errors * fix: simplify * fix: properly separate sections * fix: remove smart toggle closure * fix: remember file size unit * fix: validation * fix: UpgradeToPro styles * fix: UpgradeToPro styles for full-width * feat: create modal match * fix: tests * Small fix for error message and desc for file size limit in create and edit bucket modals * Prettify error message handling for storage settings * Nit * set default unit as MB * dotted underline and default cursor for tooltip * fix: default MB tests * minor form style and copy improvements * remove extraneous divs * fix mime check on bucket creation * Clean up + minor refactors including improving perms loading state in storage settings * EditBucketModal ensure that file size limit unit defaults to MB if bucket doesnt have a file size limit * Refactor EditBucketModal to use react query mutation * Refactor * Fix unit tests for edit bucket modal * last round of clean up * last fix * Tiny unrelated fix --------- Co-authored-by: Joshen Lim <joshenlimek@gmail.com>
Writing components
Where to create your components
- For components that declare the general structure and layout of a page:
/components/layouts/xxx
- For components that are tightly coupled to a specific interface:
/components/interfaces/xxx
- For components that are meant to be reusable across multiple pages:
/components/ui/xxx
- Note: We're gradually moving files out of the
to-be-cleanedfolder into the respective folders as we refactor
Component structure
- If a component has constants and utility methods that are tightly coupled to itself, keep them close to the component and enclose them in a folder with an
index.tsxas an entry point - Otherwise it can just be a file on its own
- For example:
-
components/ui - SampleComponentA - SampleComponentA.tsx - SampleComponentA.constants.ts - SampleComponentA.utils.ts - SampleComponentA.types.ts - index.ts - SampleComponentB.tsx
-
Template for building components
// Declare the prop types of your component
interface ComponentAProps {
sampleProp: string
}
// Name your component accordingly
const ComponentA = ({ sampleProp }: ComponentAProps) => {
return <div>ComponentA: {sampleProp}</div>
}
export default ComponentA