Files
supabase/apps/studio/components/interfaces/Advisors/DisableRuleModal.tsx
T
Danny White 476d4a5851 refactor(ui): drop redundant Button variant="default" props (#50161)
## What kind of change does this PR introduce?

Mechanical cleanup on top of the Button default-variant change (#50160).

## What is the current behavior?

Many callsites still pass `variant="default"` even though that is now
the component default.

## What is the new behavior?

Removes redundant static `variant="default"` from legacy `Button` and
`ButtonTooltip` callsites. Keeps explicit defaults where they document
the API:

- `button-default.tsx` and `button-sizes.tsx` demos
- `DocsButton`, which pins neutral styling at the wrapper boundary

## To test

Studio:

- [Auth → Rate
Limits](https://studio-staging-2s957kwc4-supabase.vercel.app/dashboard/project/_/auth/rate-limits):
dirty the form so Cancel appears; Cancel stays neutral, Save stays green
- [Project Settings → API
Keys](https://studio-staging-2s957kwc4-supabase.vercel.app/dashboard/project/_/settings/api-keys):
`DocsButton` in the header actions stays neutral

Design system:

- [Design system →
Button](https://design-system-git-dnywh-dc924ac1-supabase.vercel.app/design-system/docs/components/button):
`button-default` / `button-sizes` still show explicit default styling;
Primary (green) is restricted to the Primary section (and `asChild`)

WWW:

- [www → Brand
assets](https://zone-www-dot-com-git-dnywh-dc924ac1-supabase.vercel.app/brand-assets):
Download logo kit / Download button kit stay neutral
2026-09-11 17:05:26 +10:00

91 lines
2.5 KiB
TypeScript

import { useParams } from 'common'
import { useRouter } from 'next/router'
import { useState } from 'react'
import { toast } from 'sonner'
import {
Button,
Dialog,
DialogContent,
DialogFooter,
DialogHeader,
DialogSection,
DialogSectionSeparator,
DialogTitle,
DialogTrigger,
} from 'ui'
import { LintInfo } from '../Linter/Linter.constants'
import { lintInfoMap } from '../Linter/Linter.utils'
import { useLintRuleCreateMutation } from '@/data/lint/create-lint-rule-mutation'
interface DisableRuleModalProps {
lint: LintInfo
}
export const DisableRuleModal = ({ lint }: DisableRuleModalProps) => {
const { ref } = useParams()
const router = useRouter()
const routeCategory = router.pathname.split('/').pop()
const [open, setOpen] = useState(false)
const { mutate: createRule, isPending: isCreating } = useLintRuleCreateMutation({
onSuccess: (_, vars) => {
const ruleLint = vars.exception.lint_name
const ruleLintMeta = lintInfoMap.find((x) => x.name === ruleLint)
toast.success(`Successfully disabled the "${ruleLintMeta?.title}" rule`)
if (ruleLintMeta) {
if (!!routeCategory && routeCategory !== ruleLintMeta.category) {
router.push(
`/project/${ref}/advisors/rules/${ruleLintMeta.category}?lint=${ruleLintMeta.name}`
)
}
}
setOpen(false)
},
})
const onCreateRule = () => {
if (!ref) return console.error('Project ref is required')
createRule({
projectRef: ref,
exception: {
is_disabled: true,
lint_category: undefined,
lint_name: lint.name,
assigned_to: undefined,
},
})
}
return (
<Dialog open={open} onOpenChange={setOpen}>
<DialogTrigger asChild>
<Button>Disable rule</Button>
</DialogTrigger>
<DialogContent size="small">
<DialogHeader>
<DialogTitle>Confirm to disable rule</DialogTitle>
</DialogHeader>
<DialogSectionSeparator />
<DialogSection>
<p className="text-sm">
This will silence the "{lint.title}" by hiding this rule in the Advisor reports, as well
omitting this rule from email notifications for this project.
</p>
</DialogSection>
<DialogFooter>
<Button disabled={isCreating} onClick={() => setOpen(false)}>
Cancel
</Button>
<Button loading={isCreating} variant="primary" onClick={onCreateRule}>
Disable
</Button>
</DialogFooter>
</DialogContent>
</Dialog>
)
}