mirror of
https://github.com/supabase/supabase.git
synced 2026-10-05 17:35:10 +03:00
Seid MuhammedandAli Waseem
f9fc5c8020
Fixes: #47470 ## I have read the [CONTRIBUTING.md](https://github.com/supabase/supabase/blob/master/CONTRIBUTING.md) file. YES ## What kind of change does this PR introduce? Bug fix. ## What is the current behavior? In the Table Editor, filtering a `bigint` (`int8`) column by a large **negative** value returns the wrong results (the matching row does not appear), while the equivalent large **positive** value works correctly. `formatFilterValue` (`apps/studio/data/table-rows/utils.ts`) keeps out-of-range bigint filter values as strings so they reach Postgres without precision loss, but it only guards the upper end of the JS safe-integer range: ```ts const numberValue = Number(filter.value) // Supports BigInt filter values if (Number.isNaN(numberValue) || numberValue > Number.MAX_SAFE_INTEGER) return filter.value else return Number(filter.value) ``` `numberValue > Number.MAX_SAFE_INTEGER` is always `false` for negative numbers, so large negative bigints (e.g. the int8 minimum `-9223372036854775808`) fall through and get rounded by `Number()` (`Number('-9223372036854775808')` → `-9223372036854776000`). The rounded value is then sent to SQL, so the filter no longer matches the intended row. The same helper feeds the row count and "delete all matching" queries. Steps to reproduce: 1. Create a table with a `bigint` column `id`. 2. Insert a row with `id = -9223372036854775808`. 3. In the Table Editor, filter `id = -9223372036854775808`. 4. The row is not returned. Filtering by `9223372036854775807` works as expected. ## What is the new behavior? Large negative bigints are now preserved as strings just like large positive ones, so the literal sent to Postgres matches what the user typed and the filter returns the correct rows. The fix guards the safe-integer range by magnitude: ```ts if (Number.isNaN(numberValue) || Math.abs(numberValue) > Number.MAX_SAFE_INTEGER) return filter.value else return numberValue ``` In-range values and large positive bigints are unaffected. ## Additional context - Added unit tests in `apps/studio/data/table-rows/utils.test.ts` covering non-numerical passthrough, in-range coercion (positive and negative), `NaN` passthrough, large positive bigints (existing behavior), large negative bigints (regression), and the exact safe-integer bounds. - The negative-bigint test fails on `master` and passes with this change. Verify locally: ```bash pnpm --filter studio exec vitest run data/table-rows/utils.test.ts ``` No API, schema, or infrastructure changes. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Improved filter value formatting to keep the original input when numeric conversion would be unsafe (invalid numbers or values outside safe-integer bounds), including large negative inputs. * **Tests** * Added automated coverage for filter value formatting across non-numeric values, valid numeric coercion, invalid numeric strings, and bigint-like edge cases (including a large negative regression case). <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Ali Waseem <waseema393@gmail.com>
Supabase Studio
A dashboard for managing your self-hosted Supabase project, and used on our hosted platform. Built with:
What's included
Studio is designed to work with existing deployments - either the local hosted, docker setup, or our CLI. It is not intended for managing the deployment and administration of projects - that's out of scope.
As such, the features exposed on Studio for existing deployments are limited to those which manage your database:
- Table & SQL editors
- Saved queries are unavailable
- Database management
- Policies, roles, extensions, replication
- API documentation
Managing Project Settings
Project settings are managed outside of the Dashboard. If you use docker compose, you should manage the settings in your docker-compose file. If you're deploying Supabase to your own cloud, you should store your secrets and env vars in a vault or secrets manager.
How to contribute?
- Branch from
masterand name your branches with the following structure{type}/{branch_name}- Type:
chore | fix | feature - The branch name is arbitrary — just make sure it summarizes the work.
- Type:
- When you send a PR to
master, it will automatically tag members of the frontend team for review. - Review the contributing checklists to help test your feature before sending a PR.
- The Dashboard is under active development. You should run
git pullfrequently to make sure you're up to date.
Developer Quickstart
Note
Supabase internal use: To develop on Studio locally with the backend services, see the instructions in the internal
infrastructurerepo.
# You'll need to be on Node v20
# in /studio
## For external contributors
pnpm install # install dependencies
pnpm run dev # start dev server
## For internal contributors
## First clone the private supabase/platform repo and follow instructions for setting up mise
mise studio # Run from supabase/platform alongside `mise infra`
## For all
pnpm run test # run tests
pnpm run test -- --watch # run tests in watch mode
Running within a self-hosted environment
Follow the self-hosting guide to get started.
cd ..
cd docker
docker compose -f docker-compose.yml -f ./dev/docker-compose.dev.yml up
Once you've got that set up, update .env in the studio folder with the corresponding values.
POSTGRES_PASSWORD=
SUPABASE_ANON_KEY=
SUPABASE_SERVICE_KEY=
Then run the following commands to install dependencies and start the dashboard.
npm install
npm run dev
If you would like to configure different defaults for "Default Organization" and "Default Project", you will need to update the .env in the studio folder with the corresponding values.
DEFAULT_ORGANIZATION_NAME=
DEFAULT_PROJECT_NAME=