mirror of
https://github.com/supabase/supabase.git
synced 2026-10-05 09:25:06 +03:00
Gildas GarciaandIvan Vasilov
96d43099bb
## Problem Our `<Button>` component breaks the default `button` contract by redefining the `type` prop to set its variant (`primary`, `default`, etc) instead of the button type (`submit`, `button`, etc). This is confusing and forces to write more code when using it with shadcn components that expect/inject the standard button props. ## Solution - rename the `type` prop to `variant` - rename the `htmlType` prop to `type` - propagate the changes where necessary - format code ## How to test As this is just prop renaming, if it builds it's ok --------- Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
25 lines
543 B
TypeScript
25 lines
543 B
TypeScript
import { BookOpen } from 'lucide-react'
|
|
import { Button } from 'ui'
|
|
|
|
interface DocsButtonProps {
|
|
href: string
|
|
abbrev?: boolean
|
|
className?: string
|
|
}
|
|
|
|
export const DocsButton = ({ href, abbrev = true, className }: DocsButtonProps) => {
|
|
return (
|
|
<Button
|
|
asChild
|
|
variant="default"
|
|
className={className}
|
|
icon={<BookOpen />}
|
|
onClick={(e) => e.stopPropagation()}
|
|
>
|
|
<a target="_blank" rel="noopener noreferrer" href={href}>
|
|
{abbrev ? 'Docs' : 'Documentation'}
|
|
</a>
|
|
</Button>
|
|
)
|
|
}
|