mirror of
https://github.com/supabase/supabase.git
synced 2026-10-06 18:05:11 +03:00
## Summary
- pg_graphql 1.6+ disables schema introspection by default, which breaks
GraphiQL's docs explorer and field autocomplete. This PR adds an in-app
notice + confirmation flow so users can opt into (or later opt out of)
introspection without leaving the GraphQL tab.
- Introspection state is read from, and written to, the `@graphql(...)`
directive embedded in the target schema's Postgres comment (`public` by
default). Other directive options the user has set are preserved when
the introspection key is toggled.
- Ships `parseSchemaComment` / `buildSchemaCommentWith` helpers (with
unit tests) and a `useSetIntrospection` mutation hook, plus collapsible
disabled-state and dismissible enabled-state notices rendered above
GraphiQL. GraphiQL is re-mounted after a toggle so it re-runs
introspection.
## Test plan
- [ ] On a project with pg_graphql >= 1.6 and introspection disabled:
disabled-state notice appears, confirm modal shows the SQL that will
run, enabling re-mounts GraphiQL and populates the docs explorer.
- [ ] On a project with introspection enabled: small enabled-state
banner appears, disabling clears the docs explorer and updates the
schema comment.
- [ ] Existing `@graphql({...})` options (e.g. `inflect_names`,
`max_rows`) survive a toggle; malformed directive text is replaced and a
warning is shown in the confirm modal.
- [ ] On pg_graphql < 1.6 (or extension not installed): no notice
renders, GraphiQL behaves as before.
- [ ] Collapsed-disabled-notice state persists per project via local
storage.
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **New Features**
* GraphQL introspection toggle with enable/disable confirmation modal.
* Notices showing current introspection state with controls to change
it.
* GraphiQL automatically remounts and updates when introspection status
changes.
* Per-project persisted collapsed/expanded state for the introspection
notice.
* Background detection of introspection support and schema comment
handling for targeted schemas.
* **Tests**
* Comprehensive tests for parsing/building schema comment directives and
version behavior.
<!-- review_stack_entry_start -->
[](https://app.coderabbit.ai/change-stack/supabase/supabase/pull/46170?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack)
<!-- review_stack_entry_end -->
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
175 lines
6.2 KiB
TypeScript
175 lines
6.2 KiB
TypeScript
import 'graphiql/style.css'
|
|
import 'graphiql/setup-workers/webpack'
|
|
|
|
import { useMonaco, type GraphiQLPlugin } from '@graphiql/react'
|
|
import { createGraphiQLFetcher, Fetcher } from '@graphiql/toolkit'
|
|
import { PermissionAction } from '@supabase/shared-types/out/constants'
|
|
import { useParams } from 'common'
|
|
import { GraphiQL, HISTORY_PLUGIN } from 'graphiql'
|
|
import { User as IconUser } from 'lucide-react'
|
|
import { useTheme } from 'next-themes'
|
|
import { useCallback, useEffect, useMemo, useState } from 'react'
|
|
import { toast } from 'sonner'
|
|
import { LogoLoader } from 'ui'
|
|
|
|
import { DEFAULT_INTROSPECTION_SCHEMA } from './constants'
|
|
import styles from './graphiql.module.css'
|
|
import { IntrospectionDisabledNotice } from './IntrospectionDisabledNotice'
|
|
import { IntrospectionEnabledNotice } from './IntrospectionEnabledNotice'
|
|
import { usePgGraphqlIntrospectionStatus } from './usePgGraphqlIntrospectionStatus'
|
|
import { getTheme } from '@/components/interfaces/App/MonacoThemeProvider'
|
|
import { RoleImpersonationSelector } from '@/components/interfaces/RoleImpersonationSelector'
|
|
import { useSessionAccessTokenQuery } from '@/data/auth/session-access-token-query'
|
|
import { useProjectPostgrestConfigQuery } from '@/data/config/project-postgrest-config-query'
|
|
import { useAsyncCheckPermissions } from '@/hooks/misc/useCheckPermissions'
|
|
import { useSelectedProjectQuery } from '@/hooks/misc/useSelectedProject'
|
|
import { API_URL, IS_PLATFORM } from '@/lib/constants'
|
|
import { getRoleImpersonationJWT } from '@/lib/role-impersonation'
|
|
import { useGetImpersonatedRoleState } from '@/state/role-impersonation-state'
|
|
|
|
const ROLE_IMPERSONATION_PLUGIN: GraphiQLPlugin = {
|
|
title: 'Role Impersonation',
|
|
icon: () => <IconUser />,
|
|
content: () => <RoleImpersonationSelector orientation="vertical" />,
|
|
}
|
|
|
|
const MONACO_THEME = { dark: 'supabase-graphql-dark', light: 'supabase-graphql-light' }
|
|
|
|
const GraphiQLMonacoTheme = ({ resolvedTheme }: { resolvedTheme: 'dark' | 'light' }) => {
|
|
const { monaco } = useMonaco()
|
|
|
|
useEffect(() => {
|
|
if (!monaco) return
|
|
const dark = getTheme('dark')
|
|
const light = getTheme('light')
|
|
monaco.editor.defineTheme(MONACO_THEME.dark, {
|
|
...dark,
|
|
rules: [...dark.rules, { token: 'argument.identifier.gql', foreground: '908aff' }],
|
|
})
|
|
monaco.editor.defineTheme(MONACO_THEME.light, {
|
|
...light,
|
|
rules: [...light.rules, { token: 'argument.identifier.gql', foreground: '6c69ce' }],
|
|
// Match the dashboard's bg-default in light mode so the editor doesn't read
|
|
// as a darker square against the surrounding UI.
|
|
colors: { ...light.colors, 'editor.background': '#fcfcfc' },
|
|
})
|
|
monaco.editor.setTheme(MONACO_THEME[resolvedTheme])
|
|
}, [monaco, resolvedTheme])
|
|
|
|
return null
|
|
}
|
|
|
|
export const GraphiQLTab = () => {
|
|
const { resolvedTheme } = useTheme()
|
|
const { ref: projectRef } = useParams()
|
|
const currentTheme = resolvedTheme?.includes('dark') ? 'dark' : 'light'
|
|
const { data: accessToken } = useSessionAccessTokenQuery({ enabled: IS_PLATFORM })
|
|
const { data: project } = useSelectedProjectQuery()
|
|
|
|
const { data: config } = useProjectPostgrestConfigQuery({ projectRef })
|
|
const jwtSecret = config?.jwt_secret
|
|
|
|
const getImpersonatedRoleState = useGetImpersonatedRoleState()
|
|
|
|
const { can: canReadJWTSecret } = useAsyncCheckPermissions(
|
|
PermissionAction.READ,
|
|
'field.jwt_secret'
|
|
)
|
|
|
|
const { notice, schemaComment } = usePgGraphqlIntrospectionStatus({
|
|
projectRef,
|
|
connectionString: project?.connectionString,
|
|
schema: DEFAULT_INTROSPECTION_SCHEMA,
|
|
})
|
|
|
|
// Bumped to force GraphiQL to re-mount and re-run introspection after the
|
|
// introspection setting changes in either direction.
|
|
const [graphiqlKey, setGraphiqlKey] = useState(0)
|
|
|
|
const plugins = useMemo<GraphiQLPlugin[]>(
|
|
() => (canReadJWTSecret ? [HISTORY_PLUGIN, ROLE_IMPERSONATION_PLUGIN] : [HISTORY_PLUGIN]),
|
|
[canReadJWTSecret]
|
|
)
|
|
|
|
const fetcher = useMemo(() => {
|
|
const fetcherFn = createGraphiQLFetcher({
|
|
// [Joshen] Opting to hard code /platform for local to match the routes, so that it's clear what's happening
|
|
url: `${API_URL}${IS_PLATFORM ? '' : '/platform'}/projects/${projectRef}/api/graphql`,
|
|
fetch,
|
|
})
|
|
const customFetcher: Fetcher = async (graphqlParams, opts) => {
|
|
let userAuthorization: string | undefined
|
|
|
|
const role = getImpersonatedRoleState().role
|
|
if (
|
|
projectRef !== undefined &&
|
|
jwtSecret !== undefined &&
|
|
role !== undefined &&
|
|
role.type === 'postgrest'
|
|
) {
|
|
try {
|
|
const token = await getRoleImpersonationJWT(projectRef, jwtSecret, role)
|
|
userAuthorization = 'Bearer ' + token
|
|
} catch (err: any) {
|
|
toast.error(`Failed to get JWT for role: ${err.message}`)
|
|
}
|
|
}
|
|
|
|
return fetcherFn(graphqlParams, {
|
|
...opts,
|
|
headers: {
|
|
...opts?.headers,
|
|
...(accessToken && {
|
|
Authorization: `Bearer ${accessToken}`,
|
|
}),
|
|
'x-graphql-authorization':
|
|
opts?.headers?.['Authorization'] ??
|
|
opts?.headers?.['authorization'] ??
|
|
userAuthorization ??
|
|
accessToken,
|
|
},
|
|
})
|
|
}
|
|
|
|
return customFetcher
|
|
}, [projectRef, getImpersonatedRoleState, jwtSecret, accessToken])
|
|
|
|
const handleIntrospectionChanged = useCallback(() => {
|
|
setGraphiqlKey((k) => k + 1)
|
|
}, [])
|
|
|
|
if (IS_PLATFORM && !accessToken) {
|
|
return <LogoLoader />
|
|
}
|
|
|
|
return (
|
|
<div className="flex flex-col h-full">
|
|
<GraphiQLMonacoTheme resolvedTheme={currentTheme} />
|
|
{notice === 'opt-in' && (
|
|
<IntrospectionDisabledNotice
|
|
schema={DEFAULT_INTROSPECTION_SCHEMA}
|
|
currentSchemaComment={schemaComment}
|
|
onEnabled={handleIntrospectionChanged}
|
|
/>
|
|
)}
|
|
{notice === 'opt-out' && (
|
|
<IntrospectionEnabledNotice
|
|
schema={DEFAULT_INTROSPECTION_SCHEMA}
|
|
currentSchemaComment={schemaComment}
|
|
onDisabled={handleIntrospectionChanged}
|
|
/>
|
|
)}
|
|
<div className="flex-1 min-h-0">
|
|
<GraphiQL
|
|
key={graphiqlKey}
|
|
fetcher={fetcher}
|
|
forcedTheme={currentTheme}
|
|
editorTheme={MONACO_THEME}
|
|
className={styles.root}
|
|
plugins={plugins}
|
|
/>
|
|
</div>
|
|
</div>
|
|
)
|
|
}
|