mirror of
https://github.com/supabase/supabase.git
synced 2026-10-05 17:35:10 +03:00
Danny White
68d5011514
## Problem Pipeline edit forms hide stored credentials but still show visibility controls beside their placeholders. The controls suggest that the stored secret can be revealed. ## Solution - Hide visibility controls in edit mode for ClickHouse, Snowflake, DuckLake, and Analytics Bucket secret fields. - Keep the controls available when creating a destination, with accessible labels for the DuckLake and Analytics Bucket controls. | Before | After | | --- | --- | | <img width="1024" height="196" alt="CleanShot 2026-09-29 at 16 48 56@2x" src="https://github.com/user-attachments/assets/a9da9a32-ab17-4c07-abf3-dfa88b8c6475" /> | <img width="1024" height="168" alt="CleanShot 2026-09-29 at 16 47 23@2x" src="https://github.com/user-attachments/assets/fddeb880-cd23-4752-ae73-8f27348c647f" /> | ## To test 1. Open **Database → Pipelines** and edit a destination of each type: ClickHouse, Snowflake, DuckLake with custom parameters, and Analytics Bucket. Check that the hidden secret fields have no eye button. 2. Start creating each destination and check that its secret fields still offer a working visibility control. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary * **Improvements** * Secret fields in replication destination forms remain masked when editing an existing destination, and their visibility controls are hidden. When creating a destination, supported secret fields can be revealed. * **Accessibility** * Catalog-token visibility controls now use dynamic, descriptive labels. DuckLake catalog URL and S3 secret-key reveal controls also have descriptive labels. <!-- end of auto-generated comment: release notes by coderabbit.ai -->