mirror of
https://github.com/supabase/supabase.git
synced 2026-10-07 18:35:07 +03:00
68e6edd5e6
## I have read the [CONTRIBUTING.md](https://github.com/supabase/supabase/blob/master/CONTRIBUTING.md) file. YES ## What kind of change does this PR introduce? This PR changes the logic for show/hide password icon in the sign up form. Fix #39399 and #41459 ## What is the current behavior? For Password Field Eye Icon Label <ul> <li>When password is hidden: Button shows "Hide password" label (incorrect). <li>When password is visible: Button shows "Show password" label (incorrect) </ul> For Edge Functions Secrets <ul> <li>All secret values are always visible in plain text <li>No visibility toggle functionality exists <li>No way to hide/show individual secret values </ul> ## What is the new behavior? Sign-up Form Password Field: <ul> <li>When password is hidden: Button correctly shows "Show password" label <li>When password is visible: Button correctly shows "Hide password" label</ul> Labels now accurately describe what clicking the button will do <p></p> Edge Functions Secrets: <ul> <li>Secret values are hidden by default (security-first approach) <li>Each secret has its own independent visibility toggle button <li>Hidden secrets display as bullet points (•••••••••••••••••••••) <li>Eye icon appears when secret is hidden - click to reveal <li>EyeOff icon appears when secret is visible - click to hide <li>Tooltip shows "Hidden" when value is masked, actual value when visible</ul> --------- Co-authored-by: Gildas Garcia <1122076+djhi@users.noreply.github.com> Co-authored-by: Alaister Young <a@alaisteryoung.com>
Writing components
Where to create your components
- For components that declare the general structure and layout of a page:
/components/layouts/xxx
- For components that are tightly coupled to a specific interface:
/components/interfaces/xxx
- For components that are meant to be reusable across multiple pages:
/components/ui/xxx
- Note: We're gradually moving files out of the
to-be-cleanedfolder into the respective folders as we refactor
Component structure
- If a component has constants and utility methods that are tightly coupled to itself, keep them close to the component and enclose them in a folder with an
index.tsxas an entry point - Otherwise it can just be a file on its own
- For example:
-
components/ui - SampleComponentA - SampleComponentA.tsx - SampleComponentA.constants.ts - SampleComponentA.utils.ts - SampleComponentA.types.ts - index.ts - SampleComponentB.tsx
-
Template for building components
// Declare the prop types of your component
interface ComponentAProps {
sampleProp: string
}
// Name your component accordingly
const ComponentA = ({ sampleProp }: ComponentAProps) => {
return <div>ComponentA: {sampleProp}</div>
}
export default ComponentA