mirror of
https://github.com/supabase/supabase.git
synced 2026-10-12 12:55:06 +03:00
Joshen Lim
0c1bc80b89
## Context Related to this PR [here](https://github.com/supabase/supabase/pull/42265) If you were to update a cell twice, then save, the value that get's saved is the first edited value. There's a number of changes in this PR but the main thing is just `useOperationQueueActions` to declare `operations` outside of `handleSave` since `snap` wouldn't trigger the re-render of that function in the dependency array. ## Other changes - Refactored `useOperationQueueShortcuts.ts` - Reuse an existing `useHotKey` method to handle the event listeners - Remove unnecessary prop drilling, call the necessary hooks within it instead - Simplify its calling by only calling this hook within `SaveQueueActionBar` (removed calling from `OperationQueueSidePanel` - Add tooltip for OperatioItem "Remove operation" - (Unrelated) Fix Table Editor sort "Apply sort" CTA not working for large tables when applying sort on an indexed column (e.g primary key) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes * **New Features** * Operation queue view now toggles open and closed with a single action * Simplified keyboard shortcuts: press **S** to save operations, **.** to toggle the queue view * **Bug Fixes** * Sort operations on large tables with non-primary-key sorting now show a confirmation warning and require explicit user approval before applying * **Improvements** * Operation queue panel automatically closes after successfully saving operations * Enhanced UI with improved delete action feedback and refined visual separators <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Writing components
Where to create your components
- For components that declare the general structure and layout of a page:
/components/layouts/xxx
- For components that are tightly coupled to a specific interface:
/components/interfaces/xxx
- For components that are meant to be reusable across multiple pages:
/components/ui/xxx
- Note: We're gradually moving files out of the
to-be-cleanedfolder into the respective folders as we refactor
Component structure
- If a component has constants and utility methods that are tightly coupled to itself, keep them close to the component and enclose them in a folder with an
index.tsxas an entry point - Otherwise it can just be a file on its own
- For example:
-
components/ui - SampleComponentA - SampleComponentA.tsx - SampleComponentA.constants.ts - SampleComponentA.utils.ts - SampleComponentA.types.ts - index.ts - SampleComponentB.tsx
-
Template for building components
// Declare the prop types of your component
interface ComponentAProps {
sampleProp: string
}
// Name your component accordingly
const ComponentA = ({ sampleProp }: ComponentAProps) => {
return <div>ComponentA: {sampleProp}</div>
}
export default ComponentA