mirror of
https://github.com/supabase/supabase.git
synced 2026-10-05 09:25:06 +03:00
## Summary
I migrated every `useSendEventMutation` call site in `apps/studio` to
`useTrack`, deleted the legacy hook, and added a lint guardrail so it
can't return. `useTrack` is the type-safe replacement: it auto-injects
`groups: { project, organization }` from the selected project/org and
types `action` + `properties` against `TelemetryEvent`. Existing call
sites built groups manually and were not type-checked at the action
level. The migration covers 81 files (60 trivial swaps, 9 org-only, 3
pre-auth, 5 bespoke, 4 test mocks).
## Changes
- Migrated trivial call sites across `pages/project/[ref]`,
`components/interfaces/*` (Reports, Storage, Realtime/Inspector,
SQLEditor, Functions, EdgeFunctions, Integrations, ProjectAPIDocs,
Branching/BranchManagement, TableGridEditor, Connect, Docs, Auth,
Support, Home, ProjectHome, App), `components/layouts/*`, and
`components/ui/*`.
- Migrated org-only sites (`Organization/Documents/*`,
`Organization/BillingSettings/Subscription/*`,
`Organization/SecuritySettings.tsx`,
`Account/Preferences/DashboardSettingsToggles.tsx`) by dropping the
manual `groups: { organization: ... }` and letting `useTrack`
auto-inject. Verified `useSelectedProjectQuery` is disabled on org
routes (gates on URL `[ref]`).
- Migrated pre-auth sites (`SignInForm.tsx`, `sign-in-mfa.tsx`,
`profile.tsx`) where neither project nor org is resolved.
- Bespoke handling:
- `execute-sql-mutation.ts` and `table-row-create-mutation.ts`: pass `{
project: projectRef }` via `groupOverrides` since the mutation can
target a non-selected project ref.
- `useStudioCommandMenuTelemetry.ts`: kept a direct `sendTelemetryEvent`
call because studio groups must override pre-built event groups
(opposite of `useTrack`'s override direction).
- `AIAssistantOption.tsx`: passes sentinel-aware `groupOverrides` so
`NO_PROJECT_MARKER`/`NO_ORG_MARKER` continue to suppress group emission.
- `SidePanelEditor.utils.tsx`: utility functions `createTable` and
`updateTable` now take a `track: Track` parameter (threaded from
`SidePanelEditor.tsx`); dropped the `organizationSlug` arg since groups
are no longer assembled manually.
- Branch-event attribution: preserved `parentProjectRef` overrides on
`branch_updated`, `branch_merge_completed`, `branch_merge_failed`,
`branch_merge_submitted`, `branch_delete_button_clicked`,
`branch_review_with_assistant_clicked`, and
`branch_*_merge_request_button_clicked`. Original code grouped these
under the parent (production) project, not the branch ref;
auto-injection would have shifted them onto the branch.
- Switched 4 test mocks from `@/data/telemetry/send-event-mutation` to
`@/lib/telemetry/track`. Removed obsolete tests around manual groups and
`try/catch` on telemetry rejection.
- Deleted `apps/studio/data/telemetry/send-event-mutation.ts`. The
deleted module is its own guardrail: any reintroduction of the import
fails at TypeScript module resolution before lint runs.
## Testing
Tested on preview deploy:
- [x] SQL editor `CREATE TABLE` fires `table_created` with method
`sql_editor` and `groups.project` set to the mutation's `projectRef`.
- [x] Table editor creates a table from the side panel; `table_created`
fires from `SidePanelEditor.utils` via threaded `track`.
- [x] Help button (`/project/[ref]/...`) fires `help_button_clicked`
with auto-injected project + org groups.
- [x] Sign-in form fires `sign_in` with empty groups (pre-auth,
expected).
- [x] Org documents page (`/org/[slug]/documents`) fires
`document_view_button_clicked` with org group only, no stale project
ref.
- [x] Command menu (`Cmd+K`) inside a project still fires
`command_menu_opened` with studio's project/org overriding any
event-supplied groups.
- [x] Support form "Ask the Assistant" without selected org fires
`ai_assistant_in_support_form_clicked` with no project/org groups
(sentinels suppress).
- [x] On a branch, "Update branch" / "Merge branch" / "Close merge
request" events fire with `groups.project` set to the parent project
ref, not the branch ref.
Local checks:
- [x] 22/22 tests pass across the 4 updated test files
(`SidePanelEditor.utils.createTable`, `EdgeFunctionRenderer`,
`LayoutSidebar`, `PlanUpdateSidePanel`).
- [x] `rg useSendEventMutation apps/studio` returns 0 hits.
## Linear
- fixes GROWTH-860
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **Chores**
* Standardized telemetry across the Studio to a unified tracking system;
events now send simplified payloads with less contextual/grouping data.
* No user-facing flows changed; UI behavior, permissions, and
interactions remain the same.
* **Tests**
* Updated telemetry mocks and tests to align with the new tracking
approach.
<!-- review_stack_entry_start -->
[](https://app.coderabbit.ai/change-stack/supabase/supabase/pull/46140?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack)
<!-- review_stack_entry_end -->
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
148 lines
4.8 KiB
TypeScript
148 lines
4.8 KiB
TypeScript
import * as Sentry from '@sentry/nextjs'
|
|
import { useIsLoggedIn, useUser } from 'common'
|
|
import { useRouter } from 'next/router'
|
|
import { createContext, PropsWithChildren, useContext, useEffect, useMemo } from 'react'
|
|
import { toast } from 'sonner'
|
|
|
|
import { useSignOut } from './auth'
|
|
import { getGitHubProfileImgUrl } from './github'
|
|
import { usePermissionsQuery } from '@/data/permissions/permissions-query'
|
|
import { useProfileCreateMutation } from '@/data/profile/profile-create-mutation'
|
|
import { useProfileIdentitiesQuery } from '@/data/profile/profile-identities-query'
|
|
import { useProfileQuery } from '@/data/profile/profile-query'
|
|
import type { Profile } from '@/data/profile/types'
|
|
import { useTrack } from '@/lib/telemetry/track'
|
|
import type { ResponseError } from '@/types'
|
|
|
|
export type ProfileContextType = {
|
|
profile: Profile | undefined
|
|
error: ResponseError | null
|
|
isLoading: boolean
|
|
isError: boolean
|
|
isSuccess: boolean
|
|
}
|
|
|
|
export const ProfileContext = createContext<ProfileContextType>({
|
|
profile: undefined,
|
|
error: null,
|
|
isLoading: true,
|
|
isError: false,
|
|
isSuccess: false,
|
|
})
|
|
|
|
export const ProfileProvider = ({ children }: PropsWithChildren<{}>) => {
|
|
const user = useUser()
|
|
const isLoggedIn = useIsLoggedIn()
|
|
const router = useRouter()
|
|
const signOut = useSignOut()
|
|
|
|
const track = useTrack()
|
|
const { mutate: createProfile, isPending: isCreatingProfile } = useProfileCreateMutation({
|
|
onSuccess: () => {
|
|
track('sign_up', { category: 'conversion' })
|
|
|
|
if (user) {
|
|
// Send an event to GTM, will do nothing if GTM is not enabled
|
|
const thisWindow = window as any
|
|
thisWindow.dataLayer = thisWindow.dataLayer || []
|
|
thisWindow.dataLayer.push({
|
|
event: 'sign_up',
|
|
email: user.email,
|
|
})
|
|
}
|
|
},
|
|
onError: (error) => {
|
|
if (error.code === 409) {
|
|
// [Joshen] There's currently an assumption that createProfile is getting triggered
|
|
// multiple times unnecessarily, although the tracing the code i can't see why this might
|
|
// be happening unless GET profile is somehow returning `User's profile not found` incorrectly
|
|
// Adding a Sentry capture + toast in hopes to catch this while developing on local / staging
|
|
Sentry.captureMessage('Profile already exists: ' + error.message)
|
|
if (process.env.NEXT_PUBLIC_ENVIRONMENT !== 'prod') {
|
|
toast.error('[DEV] createProfile called despite profile already exists: ' + error.message)
|
|
}
|
|
} else {
|
|
Sentry.captureMessage('Failed to create users profile: ' + error.message)
|
|
toast.error('Failed to create your profile. Please refresh to try again.')
|
|
}
|
|
},
|
|
})
|
|
|
|
// Track telemetry for the current user
|
|
const {
|
|
error,
|
|
data: profile,
|
|
isPending: isLoadingProfile,
|
|
isError,
|
|
isSuccess,
|
|
} = useProfileQuery({
|
|
enabled: isLoggedIn,
|
|
})
|
|
|
|
useEffect(() => {
|
|
if (!isError) return
|
|
// if the user does not yet exist, create a profile for them
|
|
if (error?.message === "User's profile not found") {
|
|
createProfile()
|
|
}
|
|
|
|
// [Alaister] If the user has a bad auth token, auth-js won't know about it
|
|
// and will think the user is authenticated. Since fetching the profile happens
|
|
// on every page load, we can check for a 401 here and sign the user out if
|
|
// they have a bad token.
|
|
if (error?.code === 401) {
|
|
signOut().then(() => router.push('/sign-in'))
|
|
}
|
|
}, [error, signOut, router, createProfile, isError])
|
|
|
|
const { isInitialLoading: isLoadingPermissions } = usePermissionsQuery({ enabled: isLoggedIn })
|
|
|
|
const value = useMemo(() => {
|
|
const isLoading = isLoadingProfile || isCreatingProfile || isLoadingPermissions
|
|
|
|
return {
|
|
error,
|
|
profile,
|
|
isLoading,
|
|
isError,
|
|
isSuccess,
|
|
}
|
|
}, [
|
|
isLoadingProfile,
|
|
isCreatingProfile,
|
|
isLoadingPermissions,
|
|
profile,
|
|
error,
|
|
isError,
|
|
isSuccess,
|
|
])
|
|
|
|
return <ProfileContext.Provider value={value}>{children}</ProfileContext.Provider>
|
|
}
|
|
|
|
export const useProfile = () => useContext(ProfileContext)
|
|
|
|
export function useProfileNameAndPicture(): {
|
|
username?: string
|
|
primaryEmail?: string
|
|
avatarUrl?: string
|
|
isLoading: boolean
|
|
} {
|
|
const { profile, isLoading: isLoadingProfile } = useProfile()
|
|
const { data: identitiesData, isPending: isLoadingIdentities } = useProfileIdentitiesQuery()
|
|
|
|
const isGitHubProfile = profile?.auth0_id?.startsWith('github')
|
|
|
|
const gitHubUsername = isGitHubProfile
|
|
? identitiesData?.identities.find((x) => x.provider === 'github')?.identity_data?.user_name
|
|
: undefined
|
|
const avatarUrl = isGitHubProfile ? getGitHubProfileImgUrl(gitHubUsername) : undefined
|
|
|
|
return {
|
|
username: profile?.username,
|
|
primaryEmail: profile?.primary_email,
|
|
avatarUrl,
|
|
isLoading: isLoadingProfile || isLoadingIdentities,
|
|
}
|
|
}
|