mirror of
https://github.com/supabase/supabase.git
synced 2026-10-06 18:05:11 +03:00
## Summary
I migrated every `useSendEventMutation` call site in `apps/studio` to
`useTrack`, deleted the legacy hook, and added a lint guardrail so it
can't return. `useTrack` is the type-safe replacement: it auto-injects
`groups: { project, organization }` from the selected project/org and
types `action` + `properties` against `TelemetryEvent`. Existing call
sites built groups manually and were not type-checked at the action
level. The migration covers 81 files (60 trivial swaps, 9 org-only, 3
pre-auth, 5 bespoke, 4 test mocks).
## Changes
- Migrated trivial call sites across `pages/project/[ref]`,
`components/interfaces/*` (Reports, Storage, Realtime/Inspector,
SQLEditor, Functions, EdgeFunctions, Integrations, ProjectAPIDocs,
Branching/BranchManagement, TableGridEditor, Connect, Docs, Auth,
Support, Home, ProjectHome, App), `components/layouts/*`, and
`components/ui/*`.
- Migrated org-only sites (`Organization/Documents/*`,
`Organization/BillingSettings/Subscription/*`,
`Organization/SecuritySettings.tsx`,
`Account/Preferences/DashboardSettingsToggles.tsx`) by dropping the
manual `groups: { organization: ... }` and letting `useTrack`
auto-inject. Verified `useSelectedProjectQuery` is disabled on org
routes (gates on URL `[ref]`).
- Migrated pre-auth sites (`SignInForm.tsx`, `sign-in-mfa.tsx`,
`profile.tsx`) where neither project nor org is resolved.
- Bespoke handling:
- `execute-sql-mutation.ts` and `table-row-create-mutation.ts`: pass `{
project: projectRef }` via `groupOverrides` since the mutation can
target a non-selected project ref.
- `useStudioCommandMenuTelemetry.ts`: kept a direct `sendTelemetryEvent`
call because studio groups must override pre-built event groups
(opposite of `useTrack`'s override direction).
- `AIAssistantOption.tsx`: passes sentinel-aware `groupOverrides` so
`NO_PROJECT_MARKER`/`NO_ORG_MARKER` continue to suppress group emission.
- `SidePanelEditor.utils.tsx`: utility functions `createTable` and
`updateTable` now take a `track: Track` parameter (threaded from
`SidePanelEditor.tsx`); dropped the `organizationSlug` arg since groups
are no longer assembled manually.
- Branch-event attribution: preserved `parentProjectRef` overrides on
`branch_updated`, `branch_merge_completed`, `branch_merge_failed`,
`branch_merge_submitted`, `branch_delete_button_clicked`,
`branch_review_with_assistant_clicked`, and
`branch_*_merge_request_button_clicked`. Original code grouped these
under the parent (production) project, not the branch ref;
auto-injection would have shifted them onto the branch.
- Switched 4 test mocks from `@/data/telemetry/send-event-mutation` to
`@/lib/telemetry/track`. Removed obsolete tests around manual groups and
`try/catch` on telemetry rejection.
- Deleted `apps/studio/data/telemetry/send-event-mutation.ts`. The
deleted module is its own guardrail: any reintroduction of the import
fails at TypeScript module resolution before lint runs.
## Testing
Tested on preview deploy:
- [x] SQL editor `CREATE TABLE` fires `table_created` with method
`sql_editor` and `groups.project` set to the mutation's `projectRef`.
- [x] Table editor creates a table from the side panel; `table_created`
fires from `SidePanelEditor.utils` via threaded `track`.
- [x] Help button (`/project/[ref]/...`) fires `help_button_clicked`
with auto-injected project + org groups.
- [x] Sign-in form fires `sign_in` with empty groups (pre-auth,
expected).
- [x] Org documents page (`/org/[slug]/documents`) fires
`document_view_button_clicked` with org group only, no stale project
ref.
- [x] Command menu (`Cmd+K`) inside a project still fires
`command_menu_opened` with studio's project/org overriding any
event-supplied groups.
- [x] Support form "Ask the Assistant" without selected org fires
`ai_assistant_in_support_form_clicked` with no project/org groups
(sentinels suppress).
- [x] On a branch, "Update branch" / "Merge branch" / "Close merge
request" events fire with `groups.project` set to the parent project
ref, not the branch ref.
Local checks:
- [x] 22/22 tests pass across the 4 updated test files
(`SidePanelEditor.utils.createTable`, `EdgeFunctionRenderer`,
`LayoutSidebar`, `PlanUpdateSidePanel`).
- [x] `rg useSendEventMutation apps/studio` returns 0 hits.
## Linear
- fixes GROWTH-860
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **Chores**
* Standardized telemetry across the Studio to a unified tracking system;
events now send simplified payloads with less contextual/grouping data.
* No user-facing flows changed; UI behavior, permissions, and
interactions remain the same.
* **Tests**
* Updated telemetry mocks and tests to align with the new tracking
approach.
<!-- review_stack_entry_start -->
[](https://app.coderabbit.ai/change-stack/supabase/supabase/pull/46140?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack)
<!-- review_stack_entry_end -->
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
146 lines
5.8 KiB
TypeScript
146 lines
5.8 KiB
TypeScript
import { PermissionAction } from '@supabase/shared-types/out/constants'
|
|
import { ArrowUp, ChevronDown, FileText } from 'lucide-react'
|
|
import {
|
|
Button,
|
|
cn,
|
|
DropdownMenu,
|
|
DropdownMenuContent,
|
|
DropdownMenuItem,
|
|
DropdownMenuTrigger,
|
|
} from 'ui'
|
|
|
|
import { ShortcutBadge } from '@/components/ui/ShortcutBadge'
|
|
import { useAsyncCheckPermissions } from '@/hooks/misc/useCheckPermissions'
|
|
import { useTrack } from '@/lib/telemetry/track'
|
|
import { SHORTCUT_IDS } from '@/state/shortcuts/registry'
|
|
import { useShortcut } from '@/state/shortcuts/useShortcut'
|
|
import { useTableEditorStateSnapshot } from '@/state/table-editor'
|
|
import { useTableEditorTableStateSnapshot } from '@/state/table-editor-table'
|
|
|
|
export const InsertButton = () => {
|
|
const track = useTrack()
|
|
|
|
const snap = useTableEditorTableStateSnapshot()
|
|
const tableEditorSnap = useTableEditorStateSnapshot()
|
|
const { can: canCreateColumns } = useAsyncCheckPermissions(
|
|
PermissionAction.TENANT_SQL_ADMIN_WRITE,
|
|
'columns'
|
|
)
|
|
|
|
const onAddRow =
|
|
snap.editable && (snap.table.columns ?? []).length > 0 ? tableEditorSnap.onAddRow : undefined
|
|
const onAddColumn = snap.editable ? tableEditorSnap.onAddColumn : undefined
|
|
const onImportData = snap.editable ? tableEditorSnap.onImportData : undefined
|
|
|
|
const canAddNew = onAddRow !== undefined || onAddColumn !== undefined
|
|
|
|
useShortcut(SHORTCUT_IDS.TABLE_EDITOR_INSERT_ROW, () => onAddRow?.(), {
|
|
registerInCommandMenu: true,
|
|
enabled: onAddRow !== undefined && canAddNew && canCreateColumns,
|
|
})
|
|
useShortcut(SHORTCUT_IDS.TABLE_EDITOR_INSERT_COLUMN, () => onAddColumn?.(), {
|
|
registerInCommandMenu: true,
|
|
enabled: onAddColumn !== undefined && canAddNew && canCreateColumns,
|
|
})
|
|
useShortcut(SHORTCUT_IDS.TABLE_EDITOR_IMPORT_CSV, () => onImportData?.(), {
|
|
registerInCommandMenu: true,
|
|
enabled: onImportData !== undefined && canAddNew && canCreateColumns,
|
|
})
|
|
|
|
if (!canAddNew || !canCreateColumns) return null
|
|
|
|
return (
|
|
<DropdownMenu>
|
|
<DropdownMenuTrigger asChild>
|
|
<Button
|
|
data-testid="table-editor-insert-new-row"
|
|
type="primary"
|
|
size="tiny"
|
|
icon={<ChevronDown strokeWidth={1.5} />}
|
|
>
|
|
Insert
|
|
</Button>
|
|
</DropdownMenuTrigger>
|
|
<DropdownMenuContent side="bottom" align="end">
|
|
{[
|
|
...(onAddRow !== undefined
|
|
? [
|
|
<DropdownMenuItem
|
|
key="add-row"
|
|
className="flex items-center group gap-x-3"
|
|
onClick={onAddRow}
|
|
>
|
|
<div className="shrink-0 w-4">
|
|
<div className="border border-foreground-lighter w-[15px] h-[4px]" />
|
|
<div className="border border-foreground-lighter w-[15px] h-[4px] my-[2px]" />
|
|
<div
|
|
className={cn([
|
|
'border border-foreground-light w-[15px] h-[4px] translate-x-0.5',
|
|
'transition duration-200 group-data-highlighted:border-brand group-data-highlighted:translate-x-0',
|
|
])}
|
|
/>
|
|
</div>
|
|
<p className="flex-1 min-w-0 pr-4">Insert row</p>
|
|
<ShortcutBadge
|
|
shortcutId={SHORTCUT_IDS.TABLE_EDITOR_INSERT_ROW}
|
|
className="shrink-0"
|
|
/>
|
|
</DropdownMenuItem>,
|
|
]
|
|
: []),
|
|
...(onAddColumn !== undefined
|
|
? [
|
|
<DropdownMenuItem key="add-column" className="group gap-x-3" onClick={onAddColumn}>
|
|
<div className="flex shrink-0 w-4">
|
|
<div className="border border-foreground-lighter w-[4px] h-[15px]" />
|
|
<div className="border border-foreground-lighter w-[4px] h-[15px] mx-[2px]" />
|
|
<div
|
|
className={cn([
|
|
'border border-foreground-light w-[4px] h-[15px] -translate-y-0.5',
|
|
'transition duration-200 group-data-highlighted:border-brand group-data-highlighted:translate-y-0',
|
|
])}
|
|
/>
|
|
</div>
|
|
<p className="flex-1 min-w-0 pr-4">Insert column</p>
|
|
<ShortcutBadge
|
|
shortcutId={SHORTCUT_IDS.TABLE_EDITOR_INSERT_COLUMN}
|
|
className="shrink-0"
|
|
/>
|
|
</DropdownMenuItem>,
|
|
]
|
|
: []),
|
|
...(onImportData !== undefined
|
|
? [
|
|
<DropdownMenuItem
|
|
key="import-data"
|
|
className="group gap-x-3"
|
|
onClick={() => {
|
|
onImportData()
|
|
track('import_data_button_clicked', { tableType: 'Existing Table' })
|
|
}}
|
|
>
|
|
<div className="relative shrink-0 w-4">
|
|
<FileText size={18} strokeWidth={1.5} className="translate-x-[-2px]" />
|
|
<ArrowUp
|
|
className={cn(
|
|
'transition duration-200 absolute bottom-0 right-0 translate-y-1 opacity-0 bg-brand-400 rounded-full',
|
|
'group-data-highlighted:translate-y-0 group-data-highlighted:text-brand group-data-highlighted:opacity-100'
|
|
)}
|
|
strokeWidth={3}
|
|
size={12}
|
|
/>
|
|
</div>
|
|
<p className="flex-1 min-w-0 pr-4">Import data from CSV</p>
|
|
<ShortcutBadge
|
|
shortcutId={SHORTCUT_IDS.TABLE_EDITOR_IMPORT_CSV}
|
|
className="shrink-0"
|
|
/>
|
|
</DropdownMenuItem>,
|
|
]
|
|
: []),
|
|
]}
|
|
</DropdownMenuContent>
|
|
</DropdownMenu>
|
|
)
|
|
}
|