mirror of
https://github.com/supabase/supabase.git
synced 2026-10-14 05:39:11 +03:00
## I have read the [CONTRIBUTING.md](https://github.com/supabase/supabase/blob/master/CONTRIBUTING.md) file. YES ## What kind of change does this PR introduce? Bug fix ## What is the current behavior? After clicking delete on a project, the `onSuccess` callback unconditionally redirects to `/org/{slug}` or `/organizations`. If the user has already navigated away from the project page before the deletion completes, this causes an unwanted redirect back to the organizations page. ## What is the new behavior? The redirect now only happens if the user is still viewing the deleted project's page (`router.asPath.startsWith(/project/${projectRef})`). If they've already navigated away, only the success toast is shown. ## Additional context The Next.js pages router object is mutable, so `router.asPath` reflects the current URL at callback execution time, not at closure creation time. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Fixed navigation behavior after project deletion to avoid unnecessary redirects when you've already navigated away from the deleted project. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Writing components
Where to create your components
- For components that declare the general structure and layout of a page:
/components/layouts/xxx
- For components that are tightly coupled to a specific interface:
/components/interfaces/xxx
- For components that are meant to be reusable across multiple pages:
/components/ui/xxx
- Note: We're gradually moving files out of the
to-be-cleanedfolder into the respective folders as we refactor
Component structure
- If a component has constants and utility methods that are tightly coupled to itself, keep them close to the component and enclose them in a folder with an
index.tsxas an entry point - Otherwise it can just be a file on its own
- For example:
-
components/ui - SampleComponentA - SampleComponentA.tsx - SampleComponentA.constants.ts - SampleComponentA.utils.ts - SampleComponentA.types.ts - index.ts - SampleComponentB.tsx
-
Template for building components
// Declare the prop types of your component
interface ComponentAProps {
sampleProp: string
}
// Name your component accordingly
const ComponentA = ({ sampleProp }: ComponentAProps) => {
return <div>ComponentA: {sampleProp}</div>
}
export default ComponentA