dima/supabase

0 Fork 0

mirror of https://github.com/supabase/supabase.git synced 2026-10-11 04:15:04 +03:00

Files

T

Gildas Garcia 4f92790587 fix: FormItemLayout does not apply item id correctly (#49637 )

## Problem

`<FormItemLayout>` does not apply item id correctly. This can be seen on
https://supabase.com/design-system/docs/ui-patterns/forms: open the
devtool and check the form items labels. They have no `for` attribute.
This makes it harder to correctly test and is an accessibility issue.

Axe devtool actually report it

## Solution

When inside React Hook Form, `<FormItemLayout>` actually generate an
`id` (via `<FormItem>`). However, this `id` is overridden in
`<FormLayout>` and read from context by `<FormLabel>`. Ensure we use the
generated id unless one was provided.

Also updated the paths filters for the CI check so that any changes in
either `ui` or `ui-patterns` triggers the studio unit and e2e tests.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Bug Fixes**
- Improved form accessibility by ensuring labels consistently connect to
their corresponding input fields.
- React-based forms now correctly preserve field-specific identifiers
when associating labels with inputs.
- Added support for explicitly specifying a label’s input target,
improving compatibility with customized form layouts.
- Updated Studio forms to use consistent control identifiers and
labeling behavior.

- **Quality Improvements**
- Automated validation now also runs when shared UI components and
patterns are updated.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

2026-08-31 10:32:45 +02:00

scripts

chore: UI theme cleanup (#47519 )

2026-07-02 17:03:08 +02:00

src

fix: FormItemLayout does not apply item id correctly (#49637 )

2026-08-31 10:32:45 +02:00

package.json

feat(www + studio): promote Select 2026 in www and Dashboard (#49511 )

2026-08-25 18:07:38 +01:00

README.md

feat: Move some components into ui-patterns (#20774 )

2024-02-12 12:44:00 +01:00

tailwind.config.css

chore: Migrate the main Tailwind JS config to CSS (#45686 )

2026-05-13 13:14:58 +02:00

tsconfig.json

chore: Bump Typescript to v6 (#44204 )

2026-03-26 15:27:35 +01:00

vitest.config.ts

add coverage option to ui-patterns (#35669 )

2025-05-29 19:09:26 +02:00

vitest.setup.ts

chore: upgrade vite to v8 and vitest to v4 (#44833 )

2026-04-16 00:13:48 +09:00

README.md

Supabase UI Patterns

This package should be used for components which are built using NPM libraries (react-markdown, reactflow for example), which make no sense to be included in all apps. It should also be used for components which are constructed using various components from the ui package.

This package does not have a barrel file - each component has to be imported from its index (ui-patterns/PrivacySettings, for example). This is intentional so that adding a new component which is used only in 1 or 2 apps doesn't burden the rest of the apps.