mirror of
https://github.com/supabase/supabase.git
synced 2026-10-05 17:35:10 +03:00
## Problem Primary colour serves readable text and selected controls, but those uses need different shades. Light mode needs darker text, while dark mode needs a deeper button fill. Fixed brand green on interactive chrome also prevents a custom primary hue from carrying through the interface. Some slider tracks and selected text are hard to read. ## Solution - Keep `--primary` for accessible text and small selected indicators. Use `--primary-solid` for button fills, which need a deeper shade in dark mode. - Add `--primary-bright` for focus rings, selected control chrome, chart accents, and other interactive highlights. It follows `--primary-hue`; `brand-*` stays fixed for Supabase identity. - Make slider troughs clearer and text selection translucent with theme foreground text. - Document the split in the design-system colour guide. | Before | After | | --- | --- | | <img width="980" height="244" alt="Before: light mode primary controls" src="https://github.com/user-attachments/assets/dfae325d-0dfe-4231-8bcd-3f89c4b9d793" /> | <img width="982" height="204" alt="After: light mode primary controls" src="https://github.com/user-attachments/assets/5fdcb531-a6e3-4549-8a13-9d9a5ebe6e20" /> | | <img width="610" height="120" alt="Before: slider track" src="https://github.com/user-attachments/assets/04f768e0-51e8-4d06-9b97-c52f4a34f122" /> | <img width="622" height="126" alt="After: slider track" src="https://github.com/user-attachments/assets/95127f4e-13dc-4f0f-b63c-cf5d70a28b42" /> | | <img width="652" height="512" alt="Before: dark mode controls" src="https://github.com/user-attachments/assets/3f88de66-90cc-40ee-8cf1-b5f4eb87b09a" /> | <img width="658" height="498" alt="After: dark mode controls" src="https://github.com/user-attachments/assets/906bec30-6ca1-4614-9fb3-6cf5e5feec22" /> | ## Review instructions 1. Compare light and dark mode in the [colour usage guide](https://design-system-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/design-system/docs/color-usage#primary-and-brand-colors). Check primary ink, primary-solid, primary-bright, and fixed brand swatches. 2. In Studio, open the ‘new table’ sheet in [Table Editor](https://studio-staging-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/dashboard/project/_/editor). Tab through the new table sheet's fields and toggles. Check the focus rings, selected controls, and the sheet's edges in both themes. You do not need to save a table. 3. Select text in Studio in both themes, including a link or primary-coloured label. The selection and text should remain legible. 4. Check the [Field](https://design-system-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/design-system/docs/components/field) Price Range slider: the unused track should remain visible in both themes. The selected field card border should follow primary-bright. 5. Check the [Button](https://design-system-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/design-system/docs/components/button) and [Radio Group](https://design-system-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/design-system/docs/components/radio-group) previews. In dark mode, `primary` button fill should be deeper than primary [text](https://design-system-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/design-system/docs/color-usage#text); selected radios should remain readable.
147 lines
5.2 KiB
TypeScript
147 lines
5.2 KiB
TypeScript
import { Code, Eye, HelpCircle } from 'lucide-react'
|
|
import { Button, Tooltip, TooltipContent, TooltipTrigger } from 'ui'
|
|
|
|
import { buildExplainPrompt } from './ExplainVisualizer.ai'
|
|
import type { QueryPlanRow } from './ExplainVisualizer.types'
|
|
import { SIDEBAR_KEYS } from '@/components/layouts/ProjectLayout/LayoutSidebar/LayoutSidebarProvider'
|
|
import { AiAssistantDropdown } from '@/components/ui/AiAssistantDropdown'
|
|
import { useAiAssistantStateSnapshot } from '@/state/ai-assistant-state'
|
|
import { useSidebarManagerSnapshot } from '@/state/sidebar-manager-state'
|
|
import { useSqlEditorV2StateSnapshot } from '@/state/sql-editor/sql-editor-state'
|
|
|
|
export interface ExplainSummary {
|
|
totalTime: number
|
|
hasSeqScan: boolean
|
|
hasIndexScan: boolean
|
|
}
|
|
|
|
export interface ExplainHeaderProps {
|
|
mode: 'visual' | 'raw'
|
|
onToggleMode: () => void
|
|
summary?: ExplainSummary
|
|
id?: string
|
|
rows?: readonly QueryPlanRow[]
|
|
}
|
|
|
|
export function ExplainHeader({ mode, onToggleMode, summary, id, rows }: ExplainHeaderProps) {
|
|
const isVisual = mode === 'visual'
|
|
|
|
const snapV2 = useSqlEditorV2StateSnapshot()
|
|
const { openSidebar } = useSidebarManagerSnapshot()
|
|
const aiSnap = useAiAssistantStateSnapshot()
|
|
|
|
const getPromptData = () => {
|
|
if (!id) return null
|
|
const snippet = snapV2.snippets[id]?.snippet
|
|
if (!snippet?.content?.unchecked_sql) return null
|
|
|
|
return buildExplainPrompt({
|
|
sql: snippet.content.unchecked_sql,
|
|
explainPlanRows: (rows as QueryPlanRow[]) ?? [],
|
|
})
|
|
}
|
|
|
|
const handleExplainWithAI = () => {
|
|
const promptData = getPromptData()
|
|
if (!promptData) return
|
|
|
|
openSidebar(SIDEBAR_KEYS.AI_ASSISTANT)
|
|
aiSnap.newChat({
|
|
sqlSnippets: [
|
|
{
|
|
label: 'Query',
|
|
content: promptData.query,
|
|
},
|
|
],
|
|
initialMessage: promptData.prompt,
|
|
})
|
|
}
|
|
|
|
const buildPromptForCopy = () => {
|
|
const promptData = getPromptData()
|
|
if (!promptData) return ''
|
|
|
|
// Combine SQL and prompt into a single copyable text
|
|
return `${promptData.prompt}\n\nSQL Query:\n\`\`\`sql\n${promptData.query}\n\`\`\``
|
|
}
|
|
|
|
const hasSummaryStats =
|
|
isVisual && summary && (summary.totalTime > 0 || (summary.hasSeqScan && !summary.hasIndexScan))
|
|
|
|
return (
|
|
<div className="bg-surface-100 border-b px-4 py-3 flex flex-col gap-3 text-xs">
|
|
{/* Title row */}
|
|
<div className="flex items-center justify-between text-sm">
|
|
<div className="flex items-center gap-2">
|
|
<h3 className="font-medium text-foreground">Query Execution Plan</h3>
|
|
<Tooltip>
|
|
<TooltipTrigger>
|
|
<HelpCircle
|
|
size="14"
|
|
strokeWidth={2}
|
|
className="text-foreground-lighter hover:text-foreground-light transition-colors cursor-help"
|
|
/>
|
|
</TooltipTrigger>
|
|
<TooltipContent side="top" className="max-w-xs p-4">
|
|
<h3 className="text-xs font-medium mb-2">How to read</h3>
|
|
<p className="text-foreground-light text-xs">
|
|
Start at the bottom where data is read from tables, then follow upward as each step
|
|
processes the results.
|
|
</p>
|
|
|
|
{isVisual && (
|
|
<>
|
|
<h3 className="text-xs font-medium mt-4 mb-2">Key</h3>
|
|
<div className="flex flex-col gap-1 text-foreground-light">
|
|
<div className="flex items-center gap-1.5">
|
|
<span className="inline-block w-1.5 h-1.5 rounded-full bg-warning" />
|
|
<span>Seq Scan (slow)</span>
|
|
</div>
|
|
<div className="flex items-center gap-1.5">
|
|
<span className="inline-block w-1.5 h-1.5 rounded-full bg-primary-bright" />
|
|
<span>Index Scan (fast)</span>
|
|
</div>
|
|
</div>
|
|
</>
|
|
)}
|
|
</TooltipContent>
|
|
</Tooltip>
|
|
{/* Summary stats - only show in visual mode when we have the data */}
|
|
{hasSummaryStats && (
|
|
<div className="flex items-center gap-4 flex-wrap">
|
|
{summary.totalTime > 0 && (
|
|
<div className="flex items-center gap-2">
|
|
<span className="text-foreground-muted">/</span>
|
|
<span className="text-foreground-light">Total time</span>
|
|
<span className="font-medium text-foreground">
|
|
{summary.totalTime.toFixed(2)}ms
|
|
</span>
|
|
</div>
|
|
)}
|
|
</div>
|
|
)}
|
|
</div>
|
|
<div className="flex items-center gap-2">
|
|
{id && rows && (
|
|
<AiAssistantDropdown
|
|
label="Explain with AI"
|
|
buildPrompt={buildPromptForCopy}
|
|
onOpenAssistant={handleExplainWithAI}
|
|
telemetrySource="explain_visualizer"
|
|
size="tiny"
|
|
variant="default"
|
|
/>
|
|
)}
|
|
<Button
|
|
size="tiny"
|
|
icon={isVisual ? <Code size={14} /> : <Eye size={14} />}
|
|
onClick={onToggleMode}
|
|
>
|
|
{isVisual ? 'Raw' : 'Visual'}
|
|
</Button>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
)
|
|
}
|