supabase

dima/supabase

0 Fork 0

mirror of https://github.com/supabase/supabase.git synced 2026-10-05 17:35:10 +03:00

Files

T

History

Kanishk DudejaandJoshen Lim c55908bbf0 chore(billing): make update billing address modal non-dismissable (#44127 )

### Summary

This PR removes the visible close button from the billing address
required modal to make it non dismissable, since the majority of users
on paid orgs are still not filling their billing address.

The modal already prevents dismissal via Esc and outside/backdrop
interaction, and this change preserves that behavior. The existing
submit flow is unchanged, so the modal still closes after a successful
billing address update.

### Manual testing:

1. Open Studio in a state where the billing address required modal
appears.
2. Confirm the top-right close button is no longer shown.
3. Press Esc and verify the modal remains open.
4. Click outside the modal / on the backdrop and verify the modal
remains open.
5. Submit a valid billing address and verify the modal closes after a
successful save.

For testing whether an update successfully closes the modal, you can:

- You can create a free org without a billing address
- You will need to tweak this logic (on the frontend)

```
const shouldShow = Boolean(
  IS_PLATFORM &&
  // showMissingAddressModal &&
  org &&
  // org.plan.id !== 'free' &&
  org.organization_missing_address &&
  !org.billing_partner &&
  permissionsLoaded &&
  canBillingWrite
)
```

- Tweak the backend logic which computes `organization_missing_address`
to exclude free orgs

---------

Co-authored-by: Joshen Lim <joshenlimek@gmail.com>

2026-03-24 18:25:58 +05:30

Auth

Chore/update url regex (#30138 )

2024-10-29 10:05:52 -02:30

Billing

chore(billing): make update billing address modal non-dismissable (#44127 )

2026-03-24 18:25:58 +05:30

Editor

Fix Table Editor not identifying truncated array column values properly (#37683 )

2025-08-06 11:11:14 +07:00

Grid

chore: Prep work for pnpm (#29610 )