Files
supabase/apps/studio/data/logs/safe-analytics-sql.test.ts
T
Charis d117e70f6c feat: add safe SQL execution for analytics queries (BigQuery/ClickHouse) (#46287)
## I have read the
[CONTRIBUTING.md](https://github.com/supabase/supabase/blob/master/CONTRIBUTING.md)
file.

YES

## What kind of change does this PR introduce?

Feature - Security infrastructure

## What is the current behavior?

Analytics queries (BigQuery for legacy cloud, ClickHouse for self-hosted
OTEL) lack a compile-time safety model to prevent SQL injection from
untrusted input sources like URL parameters, UI inputs, or LLM output.

## What is the new behavior?

Implement a security model with a branded type `SafeLogSqlFragment` that
ensures all SQL fragments originate from either static code or
sanitization helpers. This includes:

- `analyticsLiteral()` for escaping string/number/boolean values
- `bqIdent()` and `clickhouseIdent()` for quoting identifiers with
engine-specific syntax
- `safeSql` template tag for composing fragments safely
- `executeAnalyticsSql()` wire boundary that rejects plain strings at
compile time

The pattern prevents cross-engine confusion by keeping
`SafeLogSqlFragment` (analytics) distinct from pg-meta's
`SafeSqlFragment` (Postgres).

## Additional context

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **New Features**
* Introduced analytics SQL execution capabilities with built-in safety
validation for queries.
* Enhanced query robustness through keyword and identifier validation
mechanisms.
  * Improved error handling and reporting for analytics operations.

* **Tests**
* Added comprehensive test suite for analytics SQL safety and validation
utilities.

<!-- review_stack_entry_start -->

[![Review Change
Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/supabase/supabase/pull/46287?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack)

<!-- review_stack_entry_end -->

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2026-05-25 08:40:18 -04:00

171 lines
5.9 KiB
TypeScript

import { describe, expect, it } from 'vitest'
import { executeAnalyticsSql } from './execute-analytics-sql'
import {
analyticsLiteral,
bqDottedIdent,
bqIdent,
clickhouseDottedIdent,
clickhouseIdent,
keyword,
safeSql,
} from './safe-analytics-sql'
describe('keyword', () => {
it('returns the matching SafeLogSqlFragment from the allow-list', () => {
expect(keyword('AND', [safeSql`AND`, safeSql`OR`])).toBe('AND')
expect(keyword('=', [safeSql`=`, safeSql`!=`, safeSql`LIKE`])).toBe('=')
})
it('throws when value is not in the allow-list', () => {
expect(() => keyword('DROP', [safeSql`AND`, safeSql`OR`])).toThrow(
'"DROP" is not in the allowed list'
)
})
it('is case-insensitive and returns the allow-listed fragment', () => {
// 'and' (lowercase) matches 'AND' in the allow-list; the returned value
// is the allow-listed fragment 'AND', not the raw input 'and'.
expect(keyword('and', [safeSql`AND`, safeSql`OR`])).toBe('AND')
expect(keyword('OR', [safeSql`and`, safeSql`or`])).toBe('or')
})
it('throws for an empty allow-list', () => {
expect(() => keyword('AND', [])).toThrow()
})
})
describe('bqDottedIdent', () => {
it('wraps a single-segment identifier in backticks', () => {
expect(bqDottedIdent('status')).toBe('`status`')
})
it('wraps the entire two-part dotted path in a single pair of backticks', () => {
expect(bqDottedIdent('request.method')).toBe('`request.method`')
})
it('wraps the entire three-part dotted path in a single pair of backticks', () => {
expect(bqDottedIdent('a.b.c')).toBe('`a.b.c`')
})
it('throws for an empty string', () => {
expect(() => bqDottedIdent('')).toThrow('invalid BigQuery dotted identifier')
})
it('throws when a segment contains disallowed characters', () => {
expect(() => bqDottedIdent('request.method; DROP TABLE')).toThrow(
'invalid BigQuery dotted identifier'
)
})
it('throws for an empty segment (double dot)', () => {
expect(() => bqDottedIdent('a..b')).toThrow('invalid BigQuery dotted identifier')
})
it('produces the same result as bqIdent for a single segment', () => {
expect(bqDottedIdent('col')).toBe(bqIdent('col'))
})
})
describe('clickhouseDottedIdent', () => {
it('quotes a single-segment identifier with double-quotes', () => {
expect(clickhouseDottedIdent('status')).toBe('"status"')
})
it('quotes each segment of a two-part dotted identifier', () => {
expect(clickhouseDottedIdent('request.method')).toBe('"request"."method"')
})
it('quotes each segment of a three-part dotted identifier', () => {
expect(clickhouseDottedIdent('a.b.c')).toBe('"a"."b"."c"')
})
it('throws for an empty string', () => {
expect(() => clickhouseDottedIdent('')).toThrow('invalid ClickHouse dotted identifier')
})
it('throws when a segment contains disallowed characters', () => {
expect(() => clickhouseDottedIdent('col OR 1=1')).toThrow(
'invalid ClickHouse dotted identifier'
)
})
it('produces the same result as clickhouseIdent for a single segment', () => {
expect(clickhouseDottedIdent('col')).toBe(clickhouseIdent('col'))
})
})
describe('executeAnalyticsSql — compile-time boundary', () => {
it('accepts a SafeLogSqlFragment', () => {
const sql = safeSql`SELECT 1`
// SafeLogSqlFragment is accepted — no type error expected here.
const fn = () =>
executeAnalyticsSql({
projectRef: 'test-ref',
endpoint: '/platform/projects/{ref}/analytics/endpoints/logs.all',
sql,
iso_timestamp_start: '2024-01-01T00:00:00Z',
iso_timestamp_end: '2024-01-02T00:00:00Z',
})
expect(fn).toBeDefined()
})
it('rejects a plain string at the type level', () => {
const plainSql: string = 'SELECT 1'
// Never invoked — compile-time check only. The function is defined so
// TypeScript type-checks the body, but no network request is made.
const _check = () =>
executeAnalyticsSql({
projectRef: 'test-ref',
endpoint: '/platform/projects/{ref}/analytics/endpoints/logs.all',
// @ts-expect-error — plain string must not be assignable to SafeLogSqlFragment
sql: plainSql,
iso_timestamp_start: '2024-01-01T00:00:00Z',
iso_timestamp_end: '2024-01-02T00:00:00Z',
})
expect(_check).toBeDefined()
})
it('rejects rawSql output cast back to string at the type level', () => {
const fragment = safeSql`SELECT 1`
const asString: string = fragment as string
// Never invoked — compile-time check only.
const _check = () =>
executeAnalyticsSql({
projectRef: 'test-ref',
endpoint: '/platform/projects/{ref}/analytics/endpoints/logs.all',
// @ts-expect-error — widened-to-string value must not be assignable to SafeLogSqlFragment
sql: asString,
iso_timestamp_start: '2024-01-01T00:00:00Z',
iso_timestamp_end: '2024-01-02T00:00:00Z',
})
expect(_check).toBeDefined()
})
})
describe('safeSql template tag — existing helpers still compose', () => {
it('analyticsLiteral output is composable via safeSql', () => {
const val = analyticsLiteral('hello')
const query = safeSql`SELECT ${val}`
expect(query).toBe("SELECT 'hello'")
})
it('bqDottedIdent output is composable via safeSql', () => {
const col = bqDottedIdent('request.method')
const query = safeSql`SELECT ${col} FROM logs`
expect(query).toBe('SELECT `request.method` FROM logs')
})
it('clickhouseDottedIdent output is composable via safeSql', () => {
const col = clickhouseDottedIdent('request.method')
const query = safeSql`SELECT ${col} FROM logs`
expect(query).toBe('SELECT "request"."method" FROM logs')
})
it('keyword output is composable via safeSql', () => {
const op = keyword('AND', [safeSql`AND`, safeSql`OR`])
const query = safeSql`WHERE a = 1 ${op} b = 2`
expect(query).toBe('WHERE a = 1 AND b = 2')
})
})