mirror of
https://github.com/supabase/supabase.git
synced 2026-10-07 18:35:07 +03:00
Gildas Garcia
d0fd4478c0
## Problem We have multiple Popover components ## Solution - [x] migrate Popover usages to Shadcn components - Migrated JSON and text editor in the `TableEditor` (inline row edition) - Migrated the template popover in the logs explorer templates page - [x] remove `_Shadcn_` suffix from Popover components (renaming + prettier) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Refactor** * Unified popover implementation across the app and design system; dropdowns, calendars, menus and tooltips now use a consistent popover API with no visual or interaction changes. * **Chores** * Minor prop typing update for the logs date-picker to align with the consolidated popover content type. <!-- review_stack_entry_start --> [](https://app.coderabbit.ai/change-stack/supabase/supabase/pull/45980) <!-- review_stack_entry_end --> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
57 lines
1.7 KiB
TypeScript
57 lines
1.7 KiB
TypeScript
import { useParams } from 'common'
|
|
import { Unlock } from 'lucide-react'
|
|
import Link from 'next/link'
|
|
import { Button, Popover, PopoverContent, PopoverTrigger } from 'ui'
|
|
|
|
import { type Lint } from '@/data/lint/lint-query'
|
|
|
|
export const SecurityDefinerViewPopover = ({
|
|
lint,
|
|
onAutofix,
|
|
}: {
|
|
lint: Lint | null
|
|
onAutofix?: () => void
|
|
}) => {
|
|
const { ref } = useParams()
|
|
|
|
return (
|
|
<Popover modal={false}>
|
|
<PopoverTrigger asChild>
|
|
<Button type="warning" icon={<Unlock strokeWidth={1.5} />}>
|
|
Security Definer view
|
|
</Button>
|
|
</PopoverTrigger>
|
|
<PopoverContent className="min-w-[395px] text-sm" align="end">
|
|
<h4 className="flex items-center gap-2">
|
|
<Unlock size={14} /> Secure your view
|
|
</h4>
|
|
<div className="grid gap-2 mt-2 text-foreground-light text-sm">
|
|
<p>
|
|
This view is defined with the Security Definer property, giving it permissions of the
|
|
view's creator (Postgres), rather than the permissions of the querying user.
|
|
</p>
|
|
|
|
<p>Since this view is in the public schema, it is accessible via your project's APIs.</p>
|
|
|
|
<div className="mt-2 flex items-center gap-2">
|
|
{!!onAutofix && (
|
|
<Button type="secondary" onClick={onAutofix}>
|
|
Autofix
|
|
</Button>
|
|
)}
|
|
<Button type="default" asChild>
|
|
<Link
|
|
target="_blank"
|
|
rel="noopener noreferrer"
|
|
href={`/project/${ref}/advisors/security?preset=${lint?.level}&id=${lint?.cache_key}`}
|
|
>
|
|
Learn more
|
|
</Link>
|
|
</Button>
|
|
</div>
|
|
</div>
|
|
</PopoverContent>
|
|
</Popover>
|
|
)
|
|
}
|