mirror of
https://github.com/supabase/supabase.git
synced 2026-10-06 01:45:10 +03:00
Gildas GarciaandIvan Vasilov
96d43099bb
## Problem Our `<Button>` component breaks the default `button` contract by redefining the `type` prop to set its variant (`primary`, `default`, etc) instead of the button type (`submit`, `button`, etc). This is confusing and forces to write more code when using it with shadcn components that expect/inject the standard button props. ## Solution - rename the `type` prop to `variant` - rename the `htmlType` prop to `type` - propagate the changes where necessary - format code ## How to test As this is just prop renaming, if it builds it's ok --------- Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
39 lines
1.2 KiB
TypeScript
39 lines
1.2 KiB
TypeScript
import { ArrowRight } from 'lucide-react'
|
|
import Link from 'next/link'
|
|
import { Button } from 'ui'
|
|
|
|
interface NextUpProps {
|
|
title: string
|
|
description: string
|
|
href: string
|
|
chapterNumber?: number
|
|
}
|
|
|
|
export function NextUp({ title, description, href, chapterNumber }: NextUpProps) {
|
|
return (
|
|
<div className="mt-16 mb-8 grow">
|
|
<div className="bg-background border border-border rounded-lg shadow-sm p-8 max-w-2xl">
|
|
<div className="grid gap-4">
|
|
<p className="text-sm text-foreground-lighter">Next Up</p>
|
|
<h2 className="text-xl font-bold text-foreground">
|
|
{chapterNumber && <span>{chapterNumber}: </span>}
|
|
{title}
|
|
</h2>
|
|
<p className="text-foreground text-base">{description}</p>
|
|
<div className="mt-2">
|
|
<Link href={href}>
|
|
<Button
|
|
variant="default"
|
|
iconRight={<ArrowRight className="h-4 w-4" />}
|
|
className="flex items-center gap-2"
|
|
>
|
|
Start {chapterNumber ? `Chapter ${chapterNumber}` : 'Next'}
|
|
</Button>
|
|
</Link>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
)
|
|
}
|