mirror of
https://github.com/supabase/supabase.git
synced 2026-10-05 17:35:10 +03:00
## Problem Primary colour serves readable text and selected controls, but those uses need different shades. Light mode needs darker text, while dark mode needs a deeper button fill. Fixed brand green on interactive chrome also prevents a custom primary hue from carrying through the interface. Some slider tracks and selected text are hard to read. ## Solution - Keep `--primary` for accessible text and small selected indicators. Use `--primary-solid` for button fills, which need a deeper shade in dark mode. - Add `--primary-bright` for focus rings, selected control chrome, chart accents, and other interactive highlights. It follows `--primary-hue`; `brand-*` stays fixed for Supabase identity. - Make slider troughs clearer and text selection translucent with theme foreground text. - Document the split in the design-system colour guide. | Before | After | | --- | --- | | <img width="980" height="244" alt="Before: light mode primary controls" src="https://github.com/user-attachments/assets/dfae325d-0dfe-4231-8bcd-3f89c4b9d793" /> | <img width="982" height="204" alt="After: light mode primary controls" src="https://github.com/user-attachments/assets/5fdcb531-a6e3-4549-8a13-9d9a5ebe6e20" /> | | <img width="610" height="120" alt="Before: slider track" src="https://github.com/user-attachments/assets/04f768e0-51e8-4d06-9b97-c52f4a34f122" /> | <img width="622" height="126" alt="After: slider track" src="https://github.com/user-attachments/assets/95127f4e-13dc-4f0f-b63c-cf5d70a28b42" /> | | <img width="652" height="512" alt="Before: dark mode controls" src="https://github.com/user-attachments/assets/3f88de66-90cc-40ee-8cf1-b5f4eb87b09a" /> | <img width="658" height="498" alt="After: dark mode controls" src="https://github.com/user-attachments/assets/906bec30-6ca1-4614-9fb3-6cf5e5feec22" /> | ## Review instructions 1. Compare light and dark mode in the [colour usage guide](https://design-system-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/design-system/docs/color-usage#primary-and-brand-colors). Check primary ink, primary-solid, primary-bright, and fixed brand swatches. 2. In Studio, open the ‘new table’ sheet in [Table Editor](https://studio-staging-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/dashboard/project/_/editor). Tab through the new table sheet's fields and toggles. Check the focus rings, selected controls, and the sheet's edges in both themes. You do not need to save a table. 3. Select text in Studio in both themes, including a link or primary-coloured label. The selection and text should remain legible. 4. Check the [Field](https://design-system-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/design-system/docs/components/field) Price Range slider: the unused track should remain visible in both themes. The selected field card border should follow primary-bright. 5. Check the [Button](https://design-system-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/design-system/docs/components/button) and [Radio Group](https://design-system-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/design-system/docs/components/radio-group) previews. In dark mode, `primary` button fill should be deeper than primary [text](https://design-system-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/design-system/docs/color-usage#text); selected radios should remain readable.
146 lines
5.8 KiB
TypeScript
146 lines
5.8 KiB
TypeScript
import { PermissionAction } from '@supabase/shared-types/out/constants'
|
|
import { ArrowUp, ChevronDown, FileText } from 'lucide-react'
|
|
import {
|
|
Button,
|
|
cn,
|
|
DropdownMenu,
|
|
DropdownMenuContent,
|
|
DropdownMenuItem,
|
|
DropdownMenuTrigger,
|
|
} from 'ui'
|
|
|
|
import { ShortcutBadge } from '@/components/ui/ShortcutBadge'
|
|
import { useAsyncCheckPermissions } from '@/hooks/misc/useCheckPermissions'
|
|
import { useTrack } from '@/lib/telemetry/track'
|
|
import { SHORTCUT_IDS } from '@/state/shortcuts/registry'
|
|
import { useShortcut } from '@/state/shortcuts/useShortcut'
|
|
import { useTableEditorStateSnapshot } from '@/state/table-editor'
|
|
import { useTableEditorTableStateSnapshot } from '@/state/table-editor-table'
|
|
|
|
export const InsertButton = () => {
|
|
const track = useTrack()
|
|
|
|
const snap = useTableEditorTableStateSnapshot()
|
|
const tableEditorSnap = useTableEditorStateSnapshot()
|
|
const { can: canCreateColumns } = useAsyncCheckPermissions(
|
|
PermissionAction.TENANT_SQL_ADMIN_WRITE,
|
|
'columns'
|
|
)
|
|
|
|
const onAddRow =
|
|
snap.editable && (snap.table.columns ?? []).length > 0 ? tableEditorSnap.onAddRow : undefined
|
|
const onAddColumn = snap.editable ? tableEditorSnap.onAddColumn : undefined
|
|
const onImportData = snap.editable ? tableEditorSnap.onImportData : undefined
|
|
|
|
const canAddNew = onAddRow !== undefined || onAddColumn !== undefined
|
|
|
|
useShortcut(SHORTCUT_IDS.TABLE_EDITOR_INSERT_ROW, () => onAddRow?.(), {
|
|
registerInCommandMenu: true,
|
|
enabled: onAddRow !== undefined && canAddNew && canCreateColumns,
|
|
})
|
|
useShortcut(SHORTCUT_IDS.TABLE_EDITOR_INSERT_COLUMN, () => onAddColumn?.(), {
|
|
registerInCommandMenu: true,
|
|
enabled: onAddColumn !== undefined && canAddNew && canCreateColumns,
|
|
})
|
|
useShortcut(SHORTCUT_IDS.TABLE_EDITOR_IMPORT_CSV, () => onImportData?.(), {
|
|
registerInCommandMenu: true,
|
|
enabled: onImportData !== undefined && canAddNew && canCreateColumns,
|
|
})
|
|
|
|
if (!canAddNew || !canCreateColumns) return null
|
|
|
|
return (
|
|
<DropdownMenu>
|
|
<DropdownMenuTrigger asChild>
|
|
<Button
|
|
data-testid="table-editor-insert-new-row"
|
|
variant="primary"
|
|
size="tiny"
|
|
icon={<ChevronDown strokeWidth={1.5} />}
|
|
>
|
|
Insert
|
|
</Button>
|
|
</DropdownMenuTrigger>
|
|
<DropdownMenuContent side="bottom" align="end">
|
|
{[
|
|
...(onAddRow !== undefined
|
|
? [
|
|
<DropdownMenuItem
|
|
key="add-row"
|
|
className="flex items-center group gap-x-3"
|
|
onClick={onAddRow}
|
|
>
|
|
<div className="shrink-0 w-4">
|
|
<div className="border border-foreground-lighter w-[15px] h-[4px]" />
|
|
<div className="border border-foreground-lighter w-[15px] h-[4px] my-[2px]" />
|
|
<div
|
|
className={cn([
|
|
'border border-foreground-light w-[15px] h-[4px] translate-x-0.5',
|
|
'transition duration-200 group-data-highlighted:border-primary-bright group-data-highlighted:translate-x-0',
|
|
])}
|
|
/>
|
|
</div>
|
|
<p className="flex-1 min-w-0 pr-4">Insert row</p>
|
|
<ShortcutBadge
|
|
shortcutId={SHORTCUT_IDS.TABLE_EDITOR_INSERT_ROW}
|
|
className="shrink-0"
|
|
/>
|
|
</DropdownMenuItem>,
|
|
]
|
|
: []),
|
|
...(onAddColumn !== undefined
|
|
? [
|
|
<DropdownMenuItem key="add-column" className="group gap-x-3" onClick={onAddColumn}>
|
|
<div className="flex shrink-0 w-4">
|
|
<div className="border border-foreground-lighter w-[4px] h-[15px]" />
|
|
<div className="border border-foreground-lighter w-[4px] h-[15px] mx-[2px]" />
|
|
<div
|
|
className={cn([
|
|
'border border-foreground-light w-[4px] h-[15px] -translate-y-0.5',
|
|
'transition duration-200 group-data-highlighted:border-primary-bright group-data-highlighted:translate-y-0',
|
|
])}
|
|
/>
|
|
</div>
|
|
<p className="flex-1 min-w-0 pr-4">Insert column</p>
|
|
<ShortcutBadge
|
|
shortcutId={SHORTCUT_IDS.TABLE_EDITOR_INSERT_COLUMN}
|
|
className="shrink-0"
|
|
/>
|
|
</DropdownMenuItem>,
|
|
]
|
|
: []),
|
|
...(onImportData !== undefined
|
|
? [
|
|
<DropdownMenuItem
|
|
key="import-data"
|
|
className="group gap-x-3"
|
|
onClick={() => {
|
|
onImportData()
|
|
track('import_data_button_clicked', { tableType: 'Existing Table' })
|
|
}}
|
|
>
|
|
<div className="relative shrink-0 w-4">
|
|
<FileText size={18} strokeWidth={1.5} className="translate-x-[-2px]" />
|
|
<ArrowUp
|
|
className={cn(
|
|
'transition duration-200 absolute bottom-0 right-0 translate-y-1 opacity-0 bg-brand-400 rounded-full',
|
|
'group-data-highlighted:translate-y-0 group-data-highlighted:text-primary group-data-highlighted:opacity-100'
|
|
)}
|
|
strokeWidth={3}
|
|
size={12}
|
|
/>
|
|
</div>
|
|
<p className="flex-1 min-w-0 pr-4">Import data from CSV</p>
|
|
<ShortcutBadge
|
|
shortcutId={SHORTCUT_IDS.TABLE_EDITOR_IMPORT_CSV}
|
|
className="shrink-0"
|
|
/>
|
|
</DropdownMenuItem>,
|
|
]
|
|
: []),
|
|
]}
|
|
</DropdownMenuContent>
|
|
</DropdownMenu>
|
|
)
|
|
}
|