mirror of
https://github.com/supabase/supabase.git
synced 2026-10-14 21:59:16 +03:00
Gildas GarciaandIvan Vasilov
96d43099bb
## Problem Our `<Button>` component breaks the default `button` contract by redefining the `type` prop to set its variant (`primary`, `default`, etc) instead of the button type (`submit`, `button`, etc). This is confusing and forces to write more code when using it with shadcn components that expect/inject the standard button props. ## Solution - rename the `type` prop to `variant` - rename the `htmlType` prop to `type` - propagate the changes where necessary - format code ## How to test As this is just prop renaming, if it builds it's ok --------- Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
45 lines
1.3 KiB
TypeScript
45 lines
1.3 KiB
TypeScript
import { useQueryClient } from '@tanstack/react-query'
|
|
import { useParams } from 'common'
|
|
import { RefreshCw } from 'lucide-react'
|
|
import { Button } from 'ui'
|
|
|
|
import { useTableIndexAdvisor } from '@/components/grid/context/TableIndexAdvisorContext'
|
|
import { Shortcut } from '@/components/ui/Shortcut'
|
|
import { tableRowKeys } from '@/data/table-rows/keys'
|
|
import { SHORTCUT_IDS } from '@/state/shortcuts/registry'
|
|
|
|
export type RefreshButtonProps = {
|
|
tableId?: number
|
|
isRefetching?: boolean
|
|
}
|
|
|
|
export const RefreshButton = ({ tableId, isRefetching }: RefreshButtonProps) => {
|
|
const { ref } = useParams()
|
|
const queryClient = useQueryClient()
|
|
const { invalidate: invalidateIndexAdvisor } = useTableIndexAdvisor()
|
|
const queryKey = tableRowKeys.tableRowsAndCount(ref, tableId)
|
|
|
|
async function onClick() {
|
|
await queryClient.invalidateQueries({ queryKey })
|
|
await invalidateIndexAdvisor()
|
|
}
|
|
|
|
return (
|
|
<Shortcut
|
|
id={SHORTCUT_IDS.TABLE_EDITOR_REFRESH}
|
|
onTrigger={onClick}
|
|
options={{ registerInCommandMenu: true }}
|
|
side="bottom"
|
|
>
|
|
<Button
|
|
variant="outline"
|
|
loading={isRefetching}
|
|
icon={<RefreshCw />}
|
|
onClick={() => onClick()}
|
|
className="w-7 p-0"
|
|
aria-label="Refresh table data"
|
|
/>
|
|
</Shortcut>
|
|
)
|
|
}
|