mirror of
https://github.com/supabase/supabase.git
synced 2026-10-06 01:45:10 +03:00
## What kind of change does this PR introduce? Bug fix / design-system alignment for the legacy `Button` from `ui`. ## What is the current behavior? Omitting `variant` on the legacy `Button` falls back to brand-green `primary`. That makes accidental greens easy, and it is hard to spot the real main action on busy pages. ## What is the new behavior? - Legacy `Button` now defaults to neutral `default` - Intentional primary CTAs (create, save, submit, marketing CTAs, and matching `ButtonTooltip` usages) now set `variant="primary"` so their appearance is unchanged - Neutral actions that previously relied on the old fallback (cancel, close, back, dashboard nav, and similar) become grey/white - Design-system docs updated; regression tests cover the new default `Button_Shadcn_` is unchanged. It already uses its own CVA default. This is PR 1 of 2 in a stack. PR 2 drops now-redundant `variant="default"` props. ## To test Studio (http://localhost:8082): - `/sign-in`: Sign in stays green - Open a project → Database → Tables: New table stays green - Auth → Users → Invite: Invite user stays green; Cancel / dismiss controls stay neutral - Project Settings → General: edit a field so Cancel and Save appear. Cancel is neutral, Save is green Design system (http://localhost:3003): - Components → Button: default demo is neutral; primary demo is green; featured preview is the default variant Marketing (optional): - www header: Start your project stays green; logged-in Dashboard is neutral <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Style** - Buttons now default to a neutral style, while primary actions across Studio, documentation, marketing pages, forms, dialogs, and error states use prominent primary styling. - Updated button examples and previews clarify the distinction between default and primary variants. - Event registration now includes a directional arrow icon. - **Tests** - Added coverage confirming default button styling and explicit primary styling behave as expected. - Updated related test fixtures to use primary styling where appropriate. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
152 lines
4.9 KiB
TypeScript
152 lines
4.9 KiB
TypeScript
import { Loader2 } from 'lucide-react'
|
|
import { MouseEvent, useState } from 'react'
|
|
import {
|
|
Button,
|
|
cn,
|
|
HoverCard,
|
|
HoverCardContent,
|
|
HoverCardTrigger,
|
|
Separator,
|
|
WarningIcon,
|
|
} from 'ui'
|
|
import { CodeBlock } from 'ui-patterns/CodeBlock'
|
|
|
|
import { useIndexInvalidation } from '../hooks/useIndexInvalidation'
|
|
import { QueryPanelScoreSection } from '../QueryPanel'
|
|
import { createIndexes } from './index-advisor.utils'
|
|
import { IndexImprovementText } from './IndexImprovementText'
|
|
import { GetIndexAdvisorResultResponse } from '@/data/database/retrieve-index-advisor-result-query'
|
|
import { useSelectedProjectQuery } from '@/hooks/misc/useSelectedProject'
|
|
|
|
interface IndexSuggestionIconProps {
|
|
indexAdvisorResult: GetIndexAdvisorResultResponse
|
|
onClickIcon?: () => void
|
|
}
|
|
|
|
export const IndexSuggestionIcon = ({
|
|
indexAdvisorResult,
|
|
onClickIcon,
|
|
}: IndexSuggestionIconProps) => {
|
|
const { data: project } = useSelectedProjectQuery()
|
|
const [isCreatingIndex, setIsCreatingIndex] = useState(false)
|
|
const [isHoverCardOpen, setIsHoverCardOpen] = useState(false)
|
|
|
|
const invalidateQueries = useIndexInvalidation()
|
|
|
|
const handleCreateIndex = async (e: MouseEvent) => {
|
|
e.stopPropagation()
|
|
|
|
setIsCreatingIndex(true)
|
|
|
|
try {
|
|
await createIndexes({
|
|
projectRef: project?.ref,
|
|
connectionString: project?.connectionString,
|
|
indexStatements: indexAdvisorResult.index_statements,
|
|
onSuccess: () => {
|
|
// Handle UI-specific logic
|
|
if (onClickIcon) {
|
|
onClickIcon()
|
|
setIsHoverCardOpen(false)
|
|
}
|
|
},
|
|
})
|
|
|
|
// Only invalidate queries if index creation was successful
|
|
invalidateQueries()
|
|
} catch (error) {
|
|
// Error is already handled by createIndexes with a toast notification
|
|
// But we could add component-specific error handling here if needed
|
|
console.error('Failed to create index:', error)
|
|
setIsCreatingIndex(false)
|
|
} finally {
|
|
// Reset the loading state after a short delay to show feedback
|
|
setTimeout(() => setIsCreatingIndex(false), 1000)
|
|
}
|
|
}
|
|
|
|
if (!indexAdvisorResult?.index_statements?.length) return null
|
|
|
|
return (
|
|
<HoverCard open={isHoverCardOpen} onOpenChange={setIsHoverCardOpen}>
|
|
<HoverCardTrigger>
|
|
<div
|
|
onClick={(e) => {
|
|
if (onClickIcon && !isCreatingIndex) {
|
|
e.stopPropagation()
|
|
onClickIcon()
|
|
}
|
|
}}
|
|
className="cursor-pointer"
|
|
>
|
|
{isCreatingIndex ? (
|
|
<Loader2 size={16} className="animate-spin text-foreground-light" />
|
|
) : (
|
|
<WarningIcon />
|
|
)}
|
|
</div>
|
|
</HoverCardTrigger>
|
|
<HoverCardContent className="w-[520px] p-0 overflow-hidden" align="start" alignOffset={-32}>
|
|
<div className="px-4 py-3 bg-surface-75">
|
|
<IndexImprovementText
|
|
indexStatements={indexAdvisorResult.index_statements}
|
|
totalCostBefore={indexAdvisorResult.total_cost_before}
|
|
totalCostAfter={indexAdvisorResult.total_cost_after}
|
|
className="text-sm"
|
|
/>
|
|
</div>
|
|
<Separator />
|
|
<div>
|
|
<CodeBlock
|
|
hideLineNumbers
|
|
value={indexAdvisorResult.index_statements.join(';\n') + ';'}
|
|
language="sql"
|
|
className={cn(
|
|
'border-none rounded-none',
|
|
'max-w-full',
|
|
'py-0.5! px-3.5! prose dark:prose-dark transition',
|
|
'[&>code]:m-0 [&>code>span]:flex [&>code>span]:flex-wrap'
|
|
)}
|
|
/>
|
|
</div>
|
|
<Separator />
|
|
<QueryPanelScoreSection
|
|
name="Total cost of query"
|
|
description="An estimate of how long it will take to return all the rows (Includes start up cost)"
|
|
before={indexAdvisorResult.total_cost_before}
|
|
after={indexAdvisorResult.total_cost_after}
|
|
/>
|
|
<QueryPanelScoreSection
|
|
hideArrowMarkers
|
|
className="border-t"
|
|
name="Start up cost"
|
|
description="An estimate of how long it will take to fetch the first row"
|
|
before={indexAdvisorResult.startup_cost_before}
|
|
after={indexAdvisorResult.startup_cost_after}
|
|
/>
|
|
<div className="p-3 flex gap-2 items-center border-t justify-end">
|
|
<Button
|
|
variant="text"
|
|
onClick={(e) => {
|
|
e.stopPropagation()
|
|
if (onClickIcon && !isCreatingIndex) onClickIcon()
|
|
setIsHoverCardOpen(false)
|
|
}}
|
|
disabled={isCreatingIndex}
|
|
>
|
|
View details
|
|
</Button>
|
|
<Button
|
|
variant="primary"
|
|
onClick={handleCreateIndex}
|
|
loading={isCreatingIndex}
|
|
disabled={isCreatingIndex}
|
|
>
|
|
Create index
|
|
</Button>
|
|
</div>
|
|
</HoverCardContent>
|
|
</HoverCard>
|
|
)
|
|
}
|