mirror of
https://github.com/supabase/supabase.git
synced 2026-10-06 09:55:06 +03:00
## What kind of change does this PR introduce? Refactor, cleanup, and docs update. ## What is the current behavior? After the page-title rollout, `ProjectLayout` is still in a transitional state: - it accepts a deprecated `title` prop - it still supports a separate `browserTitle.surface` - wrapper layouts are split between passing `title` directly and passing `browserTitle.section` That makes the API harder to reason about than it needs to be, even though the rendered titles are already correct. ## What is the new behavior? This cleanup finishes the API simplification that came out of the stacked PR review: - wrapper layouts stay `title`-first for DX - `ProjectLayout` no longer accepts `title` - `product` is now the single source of truth for the project-surface title segment - `browserTitle` is now only used for extra browser-title metadata (`entity`, `section`, `override`) - the remaining project-scoped callers now pass `browserTitle.section` when they need a section label - docs now reflect the final pattern instead of the transitional one Rendered page titles stay the same. ## Additional context Checks run: - `pnpm --filter studio exec vitest --run lib/page-title.test.ts components/layouts/ProjectLayout/index.test.tsx` - `pnpm --filter studio typecheck` - `pnpm exec prettier --check ...` on touched files This is intended as the post-rollout cleanup PR based on Joshen's review feedback across the stacked title changes. --------- Co-authored-by: Joshen Lim <joshenlimek@gmail.com>
61 lines
1.5 KiB
TypeScript
61 lines
1.5 KiB
TypeScript
import { useParams } from 'common'
|
|
import { ProductMenu } from 'components/ui/ProductMenu'
|
|
import { withAuth } from 'hooks/misc/withAuth'
|
|
import { useRouter } from 'next/router'
|
|
import type { ComponentProps, PropsWithChildren } from 'react'
|
|
|
|
import { ProjectLayout } from '../ProjectLayout'
|
|
|
|
export const EdgeFunctionsProductMenu = () => {
|
|
const { ref: projectRef = 'default' } = useParams()
|
|
const router = useRouter()
|
|
const page = router.pathname.split('/')[4]
|
|
|
|
const menuItems = [
|
|
{
|
|
title: 'Manage',
|
|
items: [
|
|
{
|
|
name: 'Functions',
|
|
key: 'main',
|
|
pages: ['', '[functionSlug]', 'new'],
|
|
url: `/project/${projectRef}/functions`,
|
|
items: [],
|
|
},
|
|
{
|
|
name: 'Secrets',
|
|
key: 'secrets',
|
|
url: `/project/${projectRef}/functions/secrets`,
|
|
items: [],
|
|
},
|
|
],
|
|
},
|
|
]
|
|
|
|
return <ProductMenu page={page} menu={menuItems} />
|
|
}
|
|
|
|
interface EdgeFunctionsLayoutProps {
|
|
title: string
|
|
browserTitle?: ComponentProps<typeof ProjectLayout>['browserTitle']
|
|
}
|
|
|
|
const EdgeFunctionsLayout = ({
|
|
children,
|
|
title,
|
|
browserTitle,
|
|
}: PropsWithChildren<EdgeFunctionsLayoutProps>) => {
|
|
return (
|
|
<ProjectLayout
|
|
product="Edge Functions"
|
|
browserTitle={{ ...browserTitle, section: title }}
|
|
productMenu={<EdgeFunctionsProductMenu />}
|
|
isBlocking={false}
|
|
>
|
|
{children}
|
|
</ProjectLayout>
|
|
)
|
|
}
|
|
|
|
export default withAuth(EdgeFunctionsLayout)
|