mirror of
https://github.com/supabase/supabase.git
synced 2026-10-08 19:05:06 +03:00
## What kind of change does this PR introduce? A11y cleanup follow-up to #47984 / [DEPR-626](https://linear.app/supabase/issue/DEPR-626). ## What is the current behavior? Studio had 82 ratcheted `supabase/require-explicit-tabindex` violations (raw `<button>` / `role="button"` without explicit `tabIndex`). ## What is the new behavior? - Explicit `tabIndex={0}` (or disabled → `-1`) on those Studio call sites across nav, `components/ui`, Database, Storage, and the remainder - Ratchet baseline cleared (**82 → 0**) and the rule **removed from the Studio ratchet** (debt is gone; ratchet is temporary) - Rule remains a shared **`warn`** for now — promoting to `error` (and sweeping www/docs/design-system) is a follow-up - Also fixed the learn/ui-library call sites that surfaced while experimenting with error promotion - Small follow-ups where making controls focusable exposed gaps: accessible names, disabled/focus consistency, focus-ring polish on To-test surfaces, home section `KeyboardSensor`, and an E2E locator tightened after `aria-label="Remove column"` Prefer migrating to `Button` from `ui` in future touch-ups; this PR takes the minimal path so Studio debt can stay at zero. ## Additional context Batches landed together so baseline conflicts stayed simple while chipping away: - Hotspots / nav (FirstLevelNav, Marketplace, AttachmentUpload, Column, Tabs, …) - `components/ui` shared - Database + Storage - Remainder **Out of scope / intentional deferrals** - Promoting `supabase/require-explicit-tabindex` to a lint **error** (follow-up after www/docs/design-system sweeps) - Tabs/Radio roving, tooltips, context menus, in-menu items - Full keyboard-accessible tab-close UX (close stays hover + `tabIndex={-1}`; context menu still closes tabs) - Data API docs links (`/project/<ref>/api` redirect) **Reviewer notes** - Rule only flags raw `<button>` / `role="button"` without a `tabIndex` prop. `Button` from `ui` already bakes this in - `tabIndex={-1}` is intentional for disabled controls, in-menu / roving-focus children, and hover-only tab close - For dnd-kit grips, put `tabIndex` **after** `{...attributes}` so it isn’t overwritten (TS2783) ### To test Use **Safari** with macOS Keyboard navigation **off** (System Settings → Keyboard). Chrome once for a sanity pass. For each surface below: Tab until the control is focused, then activate with Enter/Space where relevant. 1. **API Docs side panel** (Table Editor → open a table → **API docs**) - Floating API Docs panel — **not** `/project/<ref>/api` (that redirects to Data API docs; language ToggleGroup uses arrow keys; links are out of scope) - Left nav buttons — Tab through several and activate one; active highlight / navigation still works 2. **Integrations → Marketplace** - Enable **Integrations layout** feature preview first (avatar menu → Feature previews) - `/org/<slug>/integrations` or project integrations marketplace - “Clear all”, grid/list toggles — Tab + activate 3. **Table Editor → create a table → Columns** - Drag handles only appear while **creating** (not when editing an existing table) - Tab to grip / remove (X) / sensitive-data eye if shown 4. **Project Home** — section drag handles - Tab to a grip (visible focus ring) - Optional: Space to pick up, arrows to move, Space/Esc to drop (KeyboardSensor added) - Mouse dnd still works 5. **Storage → Policies** — expand/collapse bucket list chevron (design-system focus ring, no stuck grey open bg) 6. **Support form** (Help → Support) — attachment remove (×) and add-attachment control when visible Disabled controls should be **skipped** by Tab. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Accessibility Improvements** * Improved keyboard navigation throughout Studio by explicitly managing focus (`tabIndex`) across many interactive controls (menus, tabs, tables, charts, dialogs, navigation, and form actions). * Disabled or non-interactive controls are now removed from the tab order (or made unfocusable), while available actions remain reachable. * Ensured `type="button"` on relevant controls to prevent unintended submissions, and refined keyboard focus behavior for various toggles and copy/remove actions. * **Chores** * Updated the ESLint rule baseline configuration to match the new focus behavior. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
120 lines
3.9 KiB
TypeScript
120 lines
3.9 KiB
TypeScript
import { useParams } from 'common'
|
|
import { ExternalLink, RotateCcw } from 'lucide-react'
|
|
import Link from 'next/link'
|
|
import { Badge, Button, TableCell, TableRow, Tooltip, TooltipContent, TooltipTrigger } from 'ui'
|
|
|
|
import { ErroredTableDetails } from '../ErroredTableDetails'
|
|
import { TableState } from './ReplicationPipelineStatus.types'
|
|
import { getStatusConfig } from './ReplicationPipelineStatus.utils'
|
|
import { ButtonTooltip } from '@/components/ui/ButtonTooltip'
|
|
import { InlineLinkClassName } from '@/components/ui/InlineLink'
|
|
import { ReplicationPipelineTableStatus } from '@/data/replication/pipeline-replication-status-query'
|
|
|
|
interface TableReplicationRowProps {
|
|
table: ReplicationPipelineTableStatus
|
|
isRestarting: boolean
|
|
showDisabledState: boolean
|
|
disabledStateMessage: string
|
|
isAnyRestartInProgress: boolean
|
|
isPipelineStopped: boolean
|
|
onSelectRestart: () => void
|
|
onSelectShowError: () => void
|
|
}
|
|
|
|
export const TableReplicationRow = ({
|
|
table,
|
|
isRestarting,
|
|
showDisabledState,
|
|
disabledStateMessage,
|
|
isAnyRestartInProgress,
|
|
isPipelineStopped,
|
|
onSelectRestart,
|
|
onSelectShowError,
|
|
}: TableReplicationRowProps) => {
|
|
const { ref } = useParams()
|
|
const isErrorState = table.state.name === 'error'
|
|
const statusConfig = getStatusConfig(table.state as TableState['state'])
|
|
|
|
return (
|
|
<TableRow>
|
|
<TableCell className="align-top">
|
|
<div className="flex items-center gap-x-2">
|
|
<p>{table.table_name}</p>
|
|
|
|
<ButtonTooltip
|
|
asChild
|
|
variant="text"
|
|
className="px-1.5"
|
|
icon={<ExternalLink />}
|
|
tooltip={{
|
|
content: { side: 'bottom', text: 'Table Editor' },
|
|
}}
|
|
>
|
|
<Link
|
|
target="_blank"
|
|
rel="noopener noreferrer"
|
|
href={`/project/${ref}/editor/${table.table_id}`}
|
|
/>
|
|
</ButtonTooltip>
|
|
</div>
|
|
</TableCell>
|
|
|
|
<TableCell className="align-top">
|
|
{isRestarting ? (
|
|
<Badge variant="default">Restarting</Badge>
|
|
) : showDisabledState ? (
|
|
<Badge variant="default">Not Available</Badge>
|
|
) : (
|
|
statusConfig.badge
|
|
)}
|
|
</TableCell>
|
|
|
|
<TableCell className="align-top">
|
|
{isRestarting ? (
|
|
<p className="text-sm text-foreground-lighter">
|
|
Replication is being restarted for this table. The pipeline will restart automatically.
|
|
</p>
|
|
) : showDisabledState ? (
|
|
<p className="text-sm text-foreground-lighter">{disabledStateMessage}</p>
|
|
) : (
|
|
<div className="flex flex-col gap-y-3">
|
|
<div className="text-sm text-foreground">
|
|
{statusConfig.description}{' '}
|
|
{isErrorState && 'reason' in table.state && (
|
|
<button
|
|
tabIndex={0}
|
|
className={InlineLinkClassName}
|
|
onClick={() => onSelectShowError()}
|
|
>
|
|
View error.
|
|
</button>
|
|
)}
|
|
</div>
|
|
{table.state.name === 'error' && <ErroredTableDetails table={table} />}
|
|
</div>
|
|
)}
|
|
</TableCell>
|
|
|
|
<TableCell className="align-top">
|
|
<div className="flex items-center justify-end">
|
|
<Tooltip>
|
|
<TooltipTrigger asChild>
|
|
<Button
|
|
variant="default"
|
|
className="w-7"
|
|
icon={<RotateCcw />}
|
|
disabled={showDisabledState || isRestarting || isAnyRestartInProgress}
|
|
aria-label={`Restart replication for ${table.table_name}`}
|
|
onClick={onSelectRestart}
|
|
/>
|
|
</TooltipTrigger>
|
|
<TooltipContent side="bottom" align="center">
|
|
{isPipelineStopped ? 'Reset table and start pipeline' : 'Reset and restart pipeline'}
|
|
</TooltipContent>
|
|
</Tooltip>
|
|
</div>
|
|
</TableCell>
|
|
</TableRow>
|
|
)
|
|
}
|