Files
Pamela Chia 38b74af3f1 fix(studio): fall back for framework icons without an asset (#51065)
I made the connected-project framework icons fall back when no shipped
SVG exists for a framework. The three icon sites built
`/img/icons/frameworks/<framework>.svg` straight from the integration's
framework preset, which is an open-ended string. They only fell back
when the value was empty, so any preset without an asset (`express`,
`hono`, `fastapi`, `tanstack-start` and others) showed a broken image
and logged a 404.

**Changed:**
- **Broken framework icons**: `getFrameworkIconUrl` returns the asset
URL only for slugs in a set that mirrors `public/img/icons/frameworks/`.
The integration connection row, the org project linker and the
marketplace project picker now show their existing fallback icon for any
other slug. A test keeps the set equal to the directory listing.
- **Framework type**: I deleted the hand-kept `VercelFramework` union.
It listed exactly the shipped icon slugs, while the API types the field
as `string | null`, and that mismatch is what made the old empty-only
check look safe.

**Note:** I rejected an `onError` fallback because the browser still
sends the 404 request. Adding logos for common presets is left for
design.

## To test

Tested on Vercel preview (staging): no real connection there uses these
presets, so I rewrote the org integrations response in the browser to
give one integration four connections.
- [x] Open an org's Integrations page with connections whose framework
has no shipped icon (`express`, `eve`, `tanstack-start-lovable`). Expect
the fallback badge and no request under
`/dashboard/img/icons/frameworks/` for those slugs. Observed: all three
rows showed the badge and the network log had no request for their SVGs.
- [x] Same page with a `nextjs` connection. Expect its framework logo.
Observed: `nextjs.svg` loaded with a 200.
- [x] Same page with the real, unmodified response (one connection with
`framework: null`). Expect the badge, no frameworks requests, and no new
console errors. Observed: as expected.

## Linear
- fixes GROWTH-1309


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Bug Fixes**
* Vercel integration and project views now display framework icons when
available and fall back to the Vercel icon when no matching icon exists.
* Framework metadata now supports values beyond a fixed list, while
unsupported frameworks continue to use the fallback icon.

* **Tests**
* Added coverage for supported and unsupported framework icons,
including base-path handling.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2026-09-30 12:59:36 +08:00

370 lines
12 KiB
TypeScript

import dayjs from 'dayjs'
import { ArrowRight, ExternalLink, Github } from 'lucide-react'
import Image from 'next/legacy/image'
import Link from 'next/link'
import { forwardRef, HTMLAttributes, ReactNode, RefAttributes } from 'react'
import { Badge, Button, cn } from 'ui'
import { Markdown } from '@/components/interfaces/Markdown'
import { ButtonTooltip } from '@/components/ui/ButtonTooltip'
import type {
Integration,
IntegrationProjectConnection,
} from '@/data/integrations/integrations.types'
import { useProjectDetailQuery } from '@/data/projects/project-detail-query'
import { BASE_PATH } from '@/lib/constants'
import { getFrameworkIconUrl, getIntegrationConfigurationUrl } from '@/lib/integration-utils'
const ICON_STROKE_WIDTH = 2
const ICON_SIZE = 14
interface IntegrationInstallationProps extends RefAttributes<HTMLLIElement> {
title: string
integration: Integration
disabled?: boolean
}
type HandleIconType = Integration['integration']['name'] | 'Supabase'
const HandleIcon = ({ type, className }: { type: HandleIconType; className?: string }) => {
switch (type) {
case 'GitHub':
return <Github strokeWidth={ICON_STROKE_WIDTH} size={ICON_SIZE} />
break
// case 'Netlify':
// return <Square strokeWidth={ICON_STROKE_WIDTH} size={ICON_SIZE} />
// break
case 'Vercel':
return (
<svg
xmlns="http://www.w3.org/2000/svg"
fill="white"
viewBox="0 0 512 512"
className={cn('w-3.5', className)}
>
<path fillRule="evenodd" d="M256,48,496,464H16Z" />
</svg>
)
break
case 'Supabase':
return <img src={`${BASE_PATH}/img/supabase-logo.svg`} alt="Supabase" className="w-3.5"></img>
break
default:
return <></>
break
}
}
const Avatar = ({ src }: { src: string | undefined }) => {
return (
<div className="relative border shadow-lg w-8 h-8 rounded-full overflow-hidden">
<Image
src={src || ''}
width={30}
height={30}
layout="fill"
alt="avatar"
className="relative"
/>
</div>
)
}
const IntegrationIconBlock = ({ integration }: { integration: Integration }) => {
return (
<div className="bg-black text-white w-8 h-8 rounded-sm flex items-center justify-center">
<HandleIcon type={integration.integration.name} />
</div>
)
}
export const IntegrationInstallation = forwardRef<HTMLLIElement, IntegrationInstallationProps>(
({ integration, disabled, ...props }, ref) => {
return (
<li
ref={ref}
key={integration.id}
className="bg-surface-100 border shadow-xs flex justify-between items-center px-8 py-4 rounded-lg"
{...props}
>
<div className="flex gap-6 items-center">
<div className="flex gap-3 items-center">
<div className="flex -space-x-1">
<IntegrationIconBlock integration={integration} />
<Avatar src={integration?.metadata?.account.avatar} />
</div>
</div>
<div className="flex flex-col gap-0">
<div className="flex items-center gap-2">
<span className="text-foreground text-sm font-medium">
{integration.metadata?.account.name ||
(integration.metadata !== undefined &&
'gitHubConnectionOwner' in integration.metadata &&
integration.metadata?.gitHubConnectionOwner)}
</span>
<Badge>{integration.metadata?.account.type}</Badge>
</div>
<div className="flex flex-col gap-0">
<span className="text-foreground-lighter text-xs">
Created {dayjs(integration.inserted_at).fromNow()}
</span>
<span className="text-foreground-lighter text-xs">
Added by {integration?.added_by?.primary_email}
</span>
</div>
</div>
</div>
<Button asChild disabled={disabled} iconRight={<ExternalLink />}>
{disabled ? (
<p>Manage</p>
) : (
<Link
href={getIntegrationConfigurationUrl(integration)}
target="_blank"
rel="noopener noreferrer"
>
Manage
</Link>
)}
</Button>
</li>
)
}
)
export interface IntegrationConnectionProps extends HTMLAttributes<HTMLLIElement> {
connection: IntegrationProjectConnection
type: Integration['integration']['name']
actions?: ReactNode
showNode?: boolean
orientation?: 'horizontal' | 'vertical'
}
export const IntegrationConnection = forwardRef<HTMLLIElement, IntegrationConnectionProps>(
(
{ connection, type, actions, showNode = true, orientation = 'horizontal', className, ...props },
ref
) => {
const { data: project } = useProjectDetailQuery({ ref: connection.supabase_project_ref })
const frameworkIconUrl = getFrameworkIconUrl(connection?.metadata?.framework)
return (
<li
ref={ref}
key={connection.id}
{...props}
className={cn(showNode && 'pl-8 ml-6 border-l border-muted', 'relative')}
>
{showNode && (
<div className="absolute w-8 rounded-bl-full border-b border-l border-muted h-10 -left-px"></div>
)}
<div
className={cn(
orientation === 'horizontal'
? 'flex items-center justify-between gap-2'
: 'flex flex-col gap-3',
'bg-surface-100 border shadow-xs px-6 py-4 rounded-lg',
className
)}
>
<div className="flex flex-col gap-1 min-w-0">
<div className="flex items-center gap-2">
<div className="shrink-0 flex gap-x-2 items-center max-w-40 ">
<HandleIcon type={'Supabase'} />
<span title={project?.name} className="text-sm truncate">
{project?.name}
</span>
</div>
<ArrowRight
size={14}
className="shrink-0 text-foreground-lighter"
strokeWidth={1.5}
/>
<div className="flex-1 min-w-0 flex gap-2 items-center">
{!frameworkIconUrl ? (
<div className="bg-black text-white w-4 h-4 rounded-sm flex items-center justify-center">
<HandleIcon type={type} className={'w-2.5!'} />
</div>
) : (
<img src={frameworkIconUrl} width={21} height={21} alt={`icon`} />
)}
{type === 'GitHub' ? (
<a
title={connection.metadata.name}
href={`https://github.com/${connection.metadata?.name}`}
className="text-sm truncate"
target="_blank"
rel="noreferrer"
>
{connection.metadata?.name}
</a>
) : (
<span title={connection.metadata.name} className="text-sm truncate">
{connection.metadata?.name}
</span>
)}
</div>
</div>
<div className="flex flex-col gap-0">
<span className="text-foreground-lighter text-xs">
Connected {dayjs(connection?.inserted_at).fromNow()}
</span>
<span className="text-foreground-lighter text-xs">
Added by {connection?.added_by?.primary_email}
</span>
</div>
</div>
<div className="shrink-0">{actions}</div>
</div>
</li>
)
}
)
export const IntegrationConnectionOption = forwardRef<HTMLLIElement, IntegrationConnectionProps>(
({ connection, type, ...props }, ref) => {
const { data: project } = useProjectDetailQuery({ ref: connection.supabase_project_ref })
return (
<li
ref={ref}
key={connection.id}
{...props}
className={cn(
'bg-surface-100 border shadow-xs flex justify-between items-center px-8 py-4 rounded-lg'
)}
>
<div className="flex flex-col gap-1">
<div className="flex gap-2 items-center">
<HandleIcon type={'Supabase'} />
<span className="text-sm">{project?.name}</span>
<ArrowRight size={14} className="text-foreground-lighter" strokeWidth={1.5} />
<HandleIcon type={type} />
<span className="text-sm">{connection.metadata.name}</span>
</div>
<span className="text-foreground-lighter text-xs">
Connected {dayjs(connection.inserted_at).fromNow()}
</span>
</div>
<Button>Connect</Button>
</li>
)
}
)
type EmptyIntegrationConnectionProps = HTMLAttributes<HTMLDivElement> & {
showNode?: boolean
disabled?: boolean
icon?: ReactNode
disabledTooltip?: string
} & ({ onClick: () => void; href?: never } | { href: string; onClick?: never })
export const EmptyIntegrationConnection = forwardRef<
HTMLDivElement,
EmptyIntegrationConnectionProps
>(
(
{
className,
showNode = true,
onClick,
href,
disabled,
icon,
disabledTooltip = 'Additional permissions required to add connection',
children,
...props
},
ref
) => {
const label = children ?? 'Add connection'
return (
<div
ref={ref}
{...props}
className={cn(
showNode && 'ml-6 pl-8 mt-4 border-l',
'relative',
'last:border-l-transparent',
className
)}
>
{showNode && (
<div className="absolute w-8 rounded-bl-full border-b border-l border-muted h-14 -top-4 -left-px"></div>
)}
<div
className={cn(
'w-full',
'border border-dashed bg-surface-100 border-overlay',
'flex h-20 px-10 rounded-lg justify-center items-center'
)}
>
{href && !disabled ? (
<Button icon={icon} asChild>
<Link href={href} target="_blank" rel="noreferrer">
{label}
</Link>
</Button>
) : (
<ButtonTooltip
icon={icon}
disabled={disabled}
onClick={onClick ? () => onClick() : undefined}
tooltip={{
content: {
side: 'bottom',
text: disabled ? disabledTooltip : undefined,
},
}}
>
{label}
</ButtonTooltip>
)}
</div>
</div>
)
}
)
interface IntegrationConnectionHeader extends React.HTMLAttributes<HTMLDivElement> {
name?: string
markdown?: string
showNode?: boolean
}
export const IntegrationConnectionHeader = forwardRef<HTMLDivElement, IntegrationConnectionHeader>(
({ className, markdown = '', showNode = true, ...props }, ref) => {
return (
<div
{...props}
ref={ref}
className={cn(
showNode && 'border-l border-muted ml-6 pl-8',
'py-4 prose text-sm',
className
)}
>
{props.title && <h5 className="text-foreground">{props.title}</h5>}
<Markdown content={markdown} className="[&>p]:my-0" />
</div>
)
}
)
IntegrationInstallation.displayName = 'IntegrationInstallation'
IntegrationConnection.displayName = 'IntegrationConnection'
IntegrationConnectionHeader.displayName = 'IntegrationConnectionHeader'
EmptyIntegrationConnection.displayName = 'EmptyIntegrationConnection'
IntegrationConnectionOption.displayName = 'IntegrationConnectionOption'