mirror of
https://github.com/supabase/supabase.git
synced 2026-10-08 19:05:06 +03:00
Upgrades Vitest from 4.1.4 to 5.0.0 across the monorepo, fixes the handful of things v5 turned into hard errors, and drops the `vi.clearAllMocks()` boilerplate that v5's `clearMocks` default makes redundant. **Changed:** - `vitest`, `@vitest/ui`, `@vitest/coverage-v8` 4.1.4 → 5.0.0 (catalog) - `vi.mock` calls that lived inside `beforeAll`/`beforeEach`/test bodies moved to module scope (v5 throws on nested calls). Affects the Studio and docs setup files and four Studio tests. - `detectBrowser` test restores `navigator` via `vi.unstubAllGlobals()` instead of assigning `global.navigator`, which now reaches jsdom's getter-only property. - `RowEditor.utils.test.ts` restores its `JSON.stringify` spy. It used to leak a throwing mock for the rest of the file, which v5's coverage provider now trips over. A later test in the same file had been asserting the leak's side effect (valid JSON reported as invalid) and now asserts the correct behavior. - `@testing-library/jest-dom` 6.6 → 7.0.1. Its vitest type augmentation resolves through a peer now, so it lands on each package's own `vitest` instead of whichever copy pnpm hoisted. Fixes `toBeInTheDocument` type errors in dev-tools after the reshuffle. - `@testing-library/react` 16.0.0 → 16.3.3 for the React 19 peer range. - `vite: catalog:` added to dev-tools, www, and common. Without it they resolved a newer vite than the catalog pin, which forked a second vitest instance in the lockfile. There's now one. - ai-commands custom matcher types use v5's `Matchers<R, T>` form. - 110 test files: `vi.clearAllMocks()` removed from `beforeEach`/`afterEach` hooks, along with hooks that only did that and the imports they left unused. Calls that also reset/restore mocks are untouched. Second commit, mechanical. **Added:** - `.vitest/` to the root gitignore (v5 writes JSON/JUnit/HTML reporter output there) **Removed:** - `vite-tsconfig-paths` catalog entry and deps. Vitest 5 resolves tsconfig paths itself. Release-age note: this sat in draft with a temporary `minimumReleaseAgeExclude` entry for `vitest` and `@vitest/*` while 5.0.0 was inside the workspace's 3-day `minimumReleaseAge` window. That window has closed, so the exclusion is gone and nothing bypasses the release-age gate. **Perf** (local, medians of 3 runs, same machine): | Suite | v4.1.4 | v5.0.0 | |---|---|---| | studio | 144.1s | 141.7s (-2%) | | studio `--coverage` | 156.9s | 146.4s (-7%) | | ui-patterns | 6.27s | 5.07s (-19%) | | ui `--coverage` | 3.35s | 2.14s (-36%) | | www | 0.89s | 0.47s (-47%) | Studio is dominated by jsdom environment setup per file, which v5 doesn't change. `vitest doctor` recommends keeping the current pool config: the vm pools and `isolate: false` all break tests. ## To test - `pnpm install --frozen-lockfile` succeeds with no `minimumReleaseAgeExclude` entry for vitest. - CI: Studio unit tests, ui, ui-patterns, www, docs, and typecheck/lint should all be green. The lint ratchet was checked locally: warning counts on touched Studio files are identical to master. - `pnpm test:studio` locally passes with coverage (588 files, 6240 tests). - Open a Studio test that uses `toBeInTheDocument` in your editor and confirm no type errors on jest-dom matchers, in Studio and in `packages/dev-tools`. - Known pre-existing failures unrelated to this PR: one dev-tools test (`getEventCountBadge` capped pill) fails on master too. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Tests - Improved test coverage for JSON validation and mobile navigation behavior. - Updated test setup, cleanup, environment configuration, and matcher support across application and shared package suites. - Removed obsolete coverage for alternate MCP transport selection. ## Chores - Streamlined TypeScript path resolution and Vitest reporter output handling. - Updated testing libraries and Vitest tooling across documentation, Studio, website, and shared packages. - Added Vitest reporter output to ignored files. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Alaister Young <10985857+alaister@users.noreply.github.com> Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
269 lines
8.5 KiB
TypeScript
269 lines
8.5 KiB
TypeScript
import { fireEvent, screen, waitFor } from '@testing-library/react'
|
|
import userEvent from '@testing-library/user-event'
|
|
import type { ComponentProps } from 'react'
|
|
import { describe, expect, it, vi } from 'vitest'
|
|
|
|
import type { WebhookEndpoint } from './PlatformWebhooks.types'
|
|
import { PlatformWebhooksEndpointSheet, toEndpointPayload } from './PlatformWebhooksEndpointSheet'
|
|
import { customRender } from '@/tests/lib/custom-render'
|
|
|
|
const { generateWebhookEndpointNameMock } = vi.hoisted(() => ({
|
|
generateWebhookEndpointNameMock: vi.fn(() => 'winged-envelope'),
|
|
}))
|
|
|
|
vi.mock(import('./PlatformWebhooks.utils'), async (importOriginal) => {
|
|
const actual = await importOriginal()
|
|
return {
|
|
...actual,
|
|
generateWebhookEndpointName: generateWebhookEndpointNameMock,
|
|
}
|
|
})
|
|
|
|
const PROJECT_EVENT_TYPES = ['project.updated', 'project.paused']
|
|
|
|
const createEndpoint = (overrides?: Partial<WebhookEndpoint>): WebhookEndpoint => ({
|
|
id: '3c9b7e21-8d54-4f63-b2a1-6e7d8c9f0a12',
|
|
name: 'Billing events',
|
|
url: 'https://hooks.example.com/billing',
|
|
description: 'Invoices and receipts',
|
|
enabled: true,
|
|
eventTypes: ['project.updated'],
|
|
customHeaders: [],
|
|
createdBy: 'user@supabase.io',
|
|
createdAt: '2026-03-16T00:00:00.000Z',
|
|
...overrides,
|
|
})
|
|
|
|
const renderEndpointSheet = (
|
|
props?: Partial<ComponentProps<typeof PlatformWebhooksEndpointSheet>>
|
|
) => {
|
|
const onClose = vi.fn()
|
|
const onSubmit = vi.fn()
|
|
|
|
customRender(
|
|
<PlatformWebhooksEndpointSheet
|
|
visible
|
|
mode="create"
|
|
scope="project"
|
|
eventTypes={PROJECT_EVENT_TYPES}
|
|
onClose={onClose}
|
|
onSubmit={onSubmit}
|
|
{...props}
|
|
/>
|
|
)
|
|
|
|
return { onClose, onSubmit }
|
|
}
|
|
|
|
const submitForm = () =>
|
|
fireEvent.submit(document.getElementById('platform-webhook-endpoint-form')!)
|
|
|
|
const getUrlInput = () => screen.getByPlaceholderText('https://api.example.com/webhooks/supabase')
|
|
|
|
const findEventTypeCheckbox = (eventType: string) =>
|
|
screen.findByRole('checkbox', {
|
|
name: new RegExp(eventType.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')),
|
|
})
|
|
describe('PlatformWebhooksEndpointSheet', () => {
|
|
it('prefills the name field when creating an endpoint', async () => {
|
|
renderEndpointSheet()
|
|
|
|
expect(await screen.findByDisplayValue('winged-envelope')).toBeInTheDocument()
|
|
})
|
|
|
|
it('loads the existing name and description in edit mode', async () => {
|
|
renderEndpointSheet({
|
|
mode: 'edit',
|
|
endpoint: createEndpoint(),
|
|
})
|
|
|
|
expect(await screen.findByDisplayValue('Billing events')).toBeInTheDocument()
|
|
expect(screen.getByDisplayValue('Invoices and receipts')).toBeInTheDocument()
|
|
})
|
|
|
|
it('submits an empty name when an existing name is cleared', async () => {
|
|
const user = userEvent.setup()
|
|
const { onSubmit } = renderEndpointSheet({
|
|
mode: 'edit',
|
|
endpoint: createEndpoint(),
|
|
})
|
|
|
|
const nameInput = await screen.findByDisplayValue('Billing events')
|
|
await user.clear(nameInput)
|
|
submitForm()
|
|
|
|
await waitFor(() => expect(onSubmit).toHaveBeenCalledTimes(1))
|
|
expect(onSubmit).toHaveBeenCalledWith(
|
|
expect.objectContaining({
|
|
name: '',
|
|
url: 'https://hooks.example.com/billing',
|
|
description: 'Invoices and receipts',
|
|
}),
|
|
expect.anything()
|
|
)
|
|
})
|
|
|
|
it('blocks submit when the endpoint URL is empty', async () => {
|
|
const user = userEvent.setup()
|
|
const { onSubmit } = renderEndpointSheet()
|
|
|
|
await user.click(await findEventTypeCheckbox('project.updated'))
|
|
submitForm()
|
|
|
|
expect(await screen.findByText('Please provide a URL')).toBeInTheDocument()
|
|
expect(onSubmit).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('blocks submit when the endpoint URL is malformed', async () => {
|
|
const user = userEvent.setup()
|
|
const { onSubmit } = renderEndpointSheet()
|
|
|
|
await user.type(getUrlInput(), 'https://not a url')
|
|
await user.click(await findEventTypeCheckbox('project.updated'))
|
|
submitForm()
|
|
|
|
expect(await screen.findByText('Please provide a valid URL')).toBeInTheDocument()
|
|
expect(onSubmit).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('blocks submit when the endpoint URL uses an incomplete hostname', async () => {
|
|
const user = userEvent.setup()
|
|
const { onSubmit } = renderEndpointSheet()
|
|
|
|
await user.type(getUrlInput(), 'https://webhook')
|
|
await user.click(await findEventTypeCheckbox('project.updated'))
|
|
submitForm()
|
|
|
|
expect(await screen.findByText('Please provide a valid URL')).toBeInTheDocument()
|
|
expect(onSubmit).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('blocks submit when the endpoint URL does not include a protocol', async () => {
|
|
const user = userEvent.setup()
|
|
const { onSubmit } = renderEndpointSheet()
|
|
|
|
await user.type(getUrlInput(), 'hooks.example.com/billing')
|
|
await user.click(await findEventTypeCheckbox('project.updated'))
|
|
submitForm()
|
|
|
|
expect(
|
|
await screen.findByText('Please prefix your URL with http:// or https://')
|
|
).toBeInTheDocument()
|
|
expect(onSubmit).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('shows an error when no event types are selected', async () => {
|
|
const user = userEvent.setup()
|
|
const { onSubmit } = renderEndpointSheet()
|
|
|
|
await user.type(getUrlInput(), 'https://hooks.example.com/billing')
|
|
submitForm()
|
|
|
|
expect(await screen.findByText('Select at least one event type')).toBeInTheDocument()
|
|
expect(onSubmit).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('clears the event type error after selecting an event and allows submit', async () => {
|
|
const user = userEvent.setup()
|
|
const { onSubmit } = renderEndpointSheet()
|
|
|
|
await user.type(getUrlInput(), 'https://hooks.example.com/billing')
|
|
submitForm()
|
|
|
|
expect(await screen.findByText('Select at least one event type')).toBeInTheDocument()
|
|
|
|
await user.click(await findEventTypeCheckbox('project.updated'))
|
|
|
|
await waitFor(() => {
|
|
expect(screen.queryByText('Select at least one event type')).not.toBeInTheDocument()
|
|
})
|
|
|
|
submitForm()
|
|
|
|
await waitFor(() => expect(onSubmit).toHaveBeenCalledTimes(1))
|
|
expect(onSubmit).toHaveBeenCalledWith(
|
|
expect.objectContaining({
|
|
url: 'https://hooks.example.com/billing',
|
|
eventTypes: ['project.updated'],
|
|
}),
|
|
expect.anything()
|
|
)
|
|
})
|
|
|
|
it('allows submit when subscribe all is enabled', async () => {
|
|
const user = userEvent.setup()
|
|
const { onSubmit } = renderEndpointSheet()
|
|
|
|
await user.type(getUrlInput(), 'https://hooks.example.com/billing')
|
|
await user.click(screen.getByRole('checkbox', { name: /subscribe to all events/i }))
|
|
submitForm()
|
|
|
|
await waitFor(() => expect(onSubmit).toHaveBeenCalledTimes(1))
|
|
expect(onSubmit).toHaveBeenCalledWith(
|
|
expect.objectContaining({
|
|
subscribeAll: true,
|
|
eventTypes: PROJECT_EVENT_TYPES,
|
|
url: 'https://hooks.example.com/billing',
|
|
}),
|
|
expect.anything()
|
|
)
|
|
})
|
|
|
|
it('submits custom headers added through the shared header editor', async () => {
|
|
const user = userEvent.setup()
|
|
const { onSubmit } = renderEndpointSheet({
|
|
mode: 'edit',
|
|
endpoint: createEndpoint(),
|
|
})
|
|
|
|
await user.click(screen.getByRole('button', { name: 'Add header' }))
|
|
await user.type(screen.getByPlaceholderText('Header name'), 'X-Webhook-Secret')
|
|
await user.type(screen.getByPlaceholderText('Header value'), 'super-secret')
|
|
submitForm()
|
|
|
|
await waitFor(() => expect(onSubmit).toHaveBeenCalledTimes(1))
|
|
expect(onSubmit).toHaveBeenCalledWith(
|
|
expect.objectContaining({
|
|
customHeaders: [{ key: 'X-Webhook-Secret', value: 'super-secret' }],
|
|
}),
|
|
expect.anything()
|
|
)
|
|
})
|
|
|
|
it('blocks submit when a custom header is missing its value', async () => {
|
|
const user = userEvent.setup()
|
|
const { onSubmit } = renderEndpointSheet({
|
|
mode: 'edit',
|
|
endpoint: createEndpoint(),
|
|
})
|
|
|
|
await user.click(screen.getByRole('button', { name: 'Add header' }))
|
|
await user.type(screen.getByPlaceholderText('Header name'), 'X-Webhook-Secret')
|
|
submitForm()
|
|
|
|
expect(await screen.findByText('Header value is required')).toBeInTheDocument()
|
|
expect(onSubmit).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('strips fully empty custom header rows from the payload', () => {
|
|
expect(
|
|
toEndpointPayload({
|
|
name: 'Billing events',
|
|
url: 'https://hooks.example.com/billing',
|
|
description: '',
|
|
enabled: true,
|
|
subscribeAll: false,
|
|
eventTypes: ['project.updated'],
|
|
customHeaders: [
|
|
{ key: 'X-Webhook-Secret', value: 'super-secret' },
|
|
{ key: '', value: '' },
|
|
],
|
|
})
|
|
).toEqual(
|
|
expect.objectContaining({
|
|
customHeaders: [{ key: 'X-Webhook-Secret', value: 'super-secret' }],
|
|
})
|
|
)
|
|
})
|
|
})
|