Files
supabase/apps/studio/components/layouts/AppLayout/AdvisorButton.tsx
ChloeGarciaMillerandandGildas Garcia 2c48c6a002 fix: improve accessibility for icon buttons in LayoutHeader (#45790)
## I have read the
[CONTRIBUTING.md](https://github.com/supabase/supabase/blob/master/CONTRIBUTING.md)
file.

YES

## What kind of change does this PR introduce?

Bug fix (accessibility improvement in LayoutHeader)

## What is the current behavior?

Icon-only buttons do not have explicit accessible names for screen
readers.

## What is the new behavior?

All icon-only buttons now have explicit accessible names using visually
hidden text (sr-only), ensuring proper screen reader support.

## Additional context

Tooltip text is preserved for visual users.
No visual changes were introduced.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Accessibility**
* Added hidden screen-reader labels to multiple toolbar and menu buttons
(Settings, Advisor Center, AI Assistant, SQL Editor, Help) so icons are
announced by assistive technologies, improving navigation and
discoverability across the studio interface.

[![Review Change
Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/supabase/supabase/pull/45790)
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Gildas Garcia <1122076+djhi@users.noreply.github.com>
2026-05-11 17:30:16 +02:00

83 lines
3.1 KiB
TypeScript

import { Lightbulb } from 'lucide-react'
import { useMemo } from 'react'
import { cn } from 'ui'
import { SIDEBAR_KEYS } from '@/components/layouts/ProjectLayout/LayoutSidebar/LayoutSidebarProvider'
import { useAdvisorSignals } from '@/components/ui/AdvisorPanel/useAdvisorSignals'
import { ButtonTooltip } from '@/components/ui/ButtonTooltip'
import { useProjectLintsQuery } from '@/data/lint/lint-query'
import { useNotificationsV2Query } from '@/data/notifications/notifications-v2-query'
import { useTrack } from '@/lib/telemetry/track'
import { useSidebarManagerSnapshot } from '@/state/sidebar-manager-state'
export const AdvisorButton = ({ projectRef }: { projectRef?: string }) => {
const { toggleSidebar, activeSidebar } = useSidebarManagerSnapshot()
const track = useTrack()
const { data: lints } = useProjectLintsQuery({ projectRef })
const { data: signalItems } = useAdvisorSignals({ projectRef })
const { data: notificationsData } = useNotificationsV2Query({
filters: {},
limit: 20,
})
const notifications = useMemo(() => {
return notificationsData?.pages.flatMap((page) => page) ?? []
}, [notificationsData?.pages])
const hasUnreadNotifications = notifications.some((x) => x?.status === 'new')
const hasCriticalNotifications = notifications.some((x) => x?.priority === 'Critical')
const hasSignals = signalItems.length > 0
const hasCriticalSignals = signalItems.some((item) => item.severity === 'critical')
const hasCriticalIssues =
hasCriticalNotifications ||
hasCriticalSignals ||
(Array.isArray(lints) && lints.some((lint) => lint.level === 'ERROR'))
const hasWarningIssues = hasSignals && !hasCriticalIssues
const isOpen = activeSidebar?.id === SIDEBAR_KEYS.ADVISOR_PANEL
const handleClick = () => {
track('header_advisor_button_clicked')
toggleSidebar(SIDEBAR_KEYS.ADVISOR_PANEL)
}
return (
<div className="relative">
<ButtonTooltip
type="outline"
size="tiny"
id="advisor-center-trigger"
className={cn(
'rounded-full w-[32px] h-[32px] flex items-center justify-center p-0 group',
hasCriticalIssues && 'bg-destructive-200 border-destructive-500',
isOpen && 'bg-foreground text-background'
)}
onClick={handleClick}
tooltip={{
content: {
text: 'Advisor Center',
},
}}
>
<Lightbulb
size={16}
strokeWidth={1.5}
className={cn(
'text-foreground-light group-hover:text-foreground',
isOpen && 'text-background group-hover:text-background'
)}
/>
<span className="sr-only">Advisor Center</span>
</ButtonTooltip>
{hasCriticalIssues ? (
<span className="absolute top-1.5 right-1.5 w-1.5 h-1.5 rounded-full bg-destructive" />
) : hasWarningIssues ? (
<span className="absolute top-1.5 right-1.5 w-1.5 h-1.5 rounded-full bg-warning" />
) : hasUnreadNotifications ? (
<span className="absolute top-1.5 right-1.5 w-1.5 h-1.5 rounded-full bg-brand" />
) : null}
</div>
)
}