mirror of
https://github.com/supabase/supabase.git
synced 2026-10-05 17:35:10 +03:00
Danny White
1131e3e2ce
## What kind of change does this PR introduce? Bug fix / design-system alignment for the legacy `Button` from `ui`. ## What is the current behavior? Omitting `variant` on the legacy `Button` falls back to brand-green `primary`. That makes accidental greens easy, and it is hard to spot the real main action on busy pages. ## What is the new behavior? - Legacy `Button` now defaults to neutral `default` - Intentional primary CTAs (create, save, submit, marketing CTAs, and matching `ButtonTooltip` usages) now set `variant="primary"` so their appearance is unchanged - Neutral actions that previously relied on the old fallback (cancel, close, back, dashboard nav, and similar) become grey/white - Design-system docs updated; regression tests cover the new default `Button_Shadcn_` is unchanged. It already uses its own CVA default. This is PR 1 of 2 in a stack. PR 2 drops now-redundant `variant="default"` props. ## To test Studio (http://localhost:8082): - `/sign-in`: Sign in stays green - Open a project → Database → Tables: New table stays green - Auth → Users → Invite: Invite user stays green; Cancel / dismiss controls stay neutral - Project Settings → General: edit a field so Cancel and Save appear. Cancel is neutral, Save is green Design system (http://localhost:3003): - Components → Button: default demo is neutral; primary demo is green; featured preview is the default variant Marketing (optional): - www header: Start your project stays green; logged-in Dashboard is neutral <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Style** - Buttons now default to a neutral style, while primary actions across Studio, documentation, marketing pages, forms, dialogs, and error states use prominent primary styling. - Updated button examples and previews clarify the distinction between default and primary variants. - Event registration now includes a directional arrow icon. - **Tests** - Added coverage confirming default button styling and explicit primary styling behave as expected. - Updated related test fixtures to use primary styling where appropriate. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
69 lines
2.0 KiB
TypeScript
69 lines
2.0 KiB
TypeScript
import { Check } from 'lucide-react'
|
|
import Link from 'next/link'
|
|
import { Badge, Button, ButtonProps } from 'ui'
|
|
import { Image } from 'ui-patterns/Image'
|
|
|
|
import Panel from '@/components/Panel'
|
|
|
|
export interface CardProps {
|
|
title: string
|
|
features?: string[]
|
|
badge?: string
|
|
ctas: {
|
|
label: string
|
|
href: string
|
|
target: HTMLAnchorElement['target']
|
|
type: ButtonProps['variant']
|
|
}[]
|
|
image: {
|
|
dark: string
|
|
light: string
|
|
}
|
|
}
|
|
|
|
const NewFeatureCard = (props: CardProps) => (
|
|
<Panel outerClassName="w-full" innerClassName="relative">
|
|
<div className="relative z-10 flex flex-col gap-4 p-4 md:p-8 h-full">
|
|
<div className="flex items-center gap-2">
|
|
<h4 className="text-lg text-foreground">{props.title}</h4>
|
|
{props.badge && <Badge variant="success">{props.badge}</Badge>}
|
|
</div>
|
|
<div className="flex flex-col w-full xl:w-2/3 grow mb-4 sm:mb-10 lg:mb-8 2xl:xl:mb-32">
|
|
<ul className="flex flex-col text-foreground-lighter text-sm gap-1">
|
|
{props.features?.map((feature: any) => (
|
|
<li key={feature} className="flex items-start gap-2">
|
|
<span className="w-3 mt-0.5 flex items-center">
|
|
<Check className="stroke-2" />
|
|
</span>{' '}
|
|
<p>{feature}</p>
|
|
</li>
|
|
))}
|
|
</ul>
|
|
</div>
|
|
|
|
<div className="flex items-center flex-wrap gap-1">
|
|
{props.ctas.map((cta: any) => (
|
|
<Button variant={cta.type} asChild>
|
|
<Link href={cta.href} target={cta.target}>
|
|
{cta.label}
|
|
</Link>
|
|
</Button>
|
|
))}
|
|
</div>
|
|
</div>
|
|
{props.image && (
|
|
<div className="hidden sm:flex lg:hidden xl:flex absolute object-bottom inset-0 left-auto items-center h-full aspect-296/275">
|
|
<Image
|
|
src={props.image}
|
|
alt={`database ${props.title}`}
|
|
width="296"
|
|
height="275"
|
|
className=""
|
|
/>
|
|
</div>
|
|
)}
|
|
</Panel>
|
|
)
|
|
|
|
export default NewFeatureCard
|