Files
Danny White 3bca21b3f8 chore(a11y): convert leftover focus recipes to focus-ring (#48219)
## What kind of change does this PR introduce?

Accessibility cleanup (DEPR-628).

## What is the current behavior?

Leftover call sites still use ad-hoc focus recipes
(`ring-foreground-muted`, `outline-brand`, Dialog/Sheet `focus:` rings,
etc.) instead of the shared utilities from #41575.

## What is the new behavior?

Converts those leftovers across `packages/ui`, Studio, www, docs, and
design-system to `focus-ring`, preferring `focus-visible`. Keeps
documented exceptions (`group-focus-visible`, InputGroup `:has()`).

## To test

Tab through controls (keyboard only). Expect a consistent offset ring on
`:focus-visible`, not a green/brand/custom stack, and no ring animation.

### www (marketing)

Preview:
https://zone-www-dot-com-git-danny-depr-628-focus-ring-fbccf9-supabase.vercel.app

- Global nav on `/`: Product, Developers, Solutions dropdowns; logo;
hamburger + mobile menu
- `/features`: view toggles and feature cards
- `/company`: card links
- `/changelog`: timeline / entry links
- `/partners/catalog`: grid/list toggle and partner cards
- `/pricing`: compute section expand control
- Product / Modules / Solutions sticky navs on product pages (e.g.
`/database`, `/storage`)
- `/state-of-startups`: TwoOptionToggle if present

### docs

Preview:
https://docs-git-danny-depr-628-focus-ring-long-tail-supabase.vercel.app

- Any guide page: top nav dropdowns and items
- Narrow viewport: hamburger, then mobile menu links + close
- Guide with PromptPanel / tabs: tab to prompt actions and tab list

### studio (dashboard)

Preview:
https://studio-staging-git-danny-depr-628-focus-ring-long-tail-supabase.vercel.app

- Project home: Connect section tiles; drag-handle focus on sortable
sections
- Integrations marketplace (`/project/<ref>/integrations`): featured
cards, list/grid toggle, list rows
- Auth (`/project/<ref>/auth/oauth-apps`,
`/project/<ref>/auth/providers`): open create/edit sheet, tab to close
(X)
- Database policies (`/project/<ref>/database/policies`): open policy
editor sheet, tab to close
- Storage policies (`/project/<ref>/storage/files/policies`): bucket
section links; policy modal close
- Query performance (`/project/<ref>/observability/query-performance`):
info icon buttons on metrics
- Replication pipeline detail (if available): slot lag / status info
icons
- Support (`/support/new`): attachment add/remove controls
- Table editor: spreadsheet import preview checkboxes; row text/JSON
editor TwoOptionToggle
- Any Dialog/Sheet/toast close (X): ring on keyboard focus only, not
mouse click

### design-system

Preview:
https://design-system-git-danny-depr-628-focus-ring-long-tail-supabase.vercel.app

- Colour palette swatches (keyboard focus)
- Form patterns sidepanel example: avatar / focusable control in the
example

## Additional context

- Linear: [DEPR-628](https://linear.app/supabase/issue/DEPR-628)
- Follow-ups: form-group CSS (DEPR-629), Storage columns selection
(DEPR-630), ESLint rule (DEPR-632)

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Accessibility & Usability**
* Standardized keyboard focus indicators across navigation, dialogs,
forms, buttons, toggles, links, and tooltips using a consolidated focus
style.
* Improved toggle controls to use proper button semantics (instead of
clickable text), including `aria-pressed`/disabled handling and better
keyboard navigation.

* **Visual Updates**
* Harmonized hover/focus ring visuals across the design system, Studio,
documentation, and marketing pages while preserving existing layout and
interaction behavior.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2026-07-23 08:52:22 +10:00

273 lines
8.6 KiB
TypeScript

// End of third-party imports
import { compact } from 'lodash'
import { FileCode, Plus, X } from 'lucide-react'
import {
useCallback,
useEffect,
useMemo,
useRef,
useState,
type ChangeEvent,
type RefObject,
} from 'react'
import { toast } from 'sonner'
import { cn, Tooltip, TooltipContent, TooltipTrigger } from 'ui'
import { createSupportStorageClient } from './support-storage-client'
import { InlineLink } from '@/components/ui/InlineLink'
import { useGenerateAttachmentURLsMutation } from '@/data/support/generate-attachment-urls-mutation'
import { uuidv4 } from '@/lib/helpers'
import { useProfile } from '@/lib/profile'
const MAX_ATTACHMENTS = 5
const removeAttachmentButtonClassName = cn(
'absolute -top-1 -right-1 size-4 shrink-0 rounded-full bg-red-900 p-0 cursor-pointer',
'focus-ring'
)
const RemoveAttachmentIcon = () => (
<X
aria-hidden="true"
strokeWidth={3}
className="pointer-events-none absolute left-1/2 top-1/2 size-2.5 -translate-x-1/2 -translate-y-1/2 text-contrast"
/>
)
const uploadAttachments = async ({ userId, files }: { userId: string; files: File[] }) => {
const supportSupabaseClient = createSupportStorageClient()
const filesToUpload = Array.from(files)
const uploadedFiles = await Promise.all(
filesToUpload.map(async (file) => {
const suffix = file.name.endsWith('.har') ? 'har' : file.type.split('/')[1]
const prefix = `${userId}/${uuidv4()}.${suffix}`
const options = { cacheControl: '3600' }
const { data, error } = await supportSupabaseClient.storage
.from('support-attachments')
.upload(prefix, file, options)
if (error) console.error('Failed to upload:', file.name, error)
return data
})
)
const keys = compact(uploadedFiles).map((file) => file.path)
return keys
}
export function useAttachmentUpload() {
const { profile } = useProfile()
const uploadButtonRef = useRef<HTMLInputElement>(null)
const [uploadedFiles, setUploadedFiles] = useState<File[]>([])
const [uploadedDataUrls, setUploadedDataUrls] = useState<string[]>([])
const { mutateAsync: generateAttachmentURLs } = useGenerateAttachmentURLsMutation()
const isFull = uploadedFiles.length >= MAX_ATTACHMENTS
const addFile = useCallback(() => {
uploadButtonRef.current?.click()
}, [])
const handleFileUpload = useCallback(
async (event: ChangeEvent<HTMLInputElement>) => {
event.persist()
const items = event.target.files || (event as any).dataTransfer.items
const itemsCopied = Array.prototype.map.call(items, (item: any) => item) as File[]
const itemsToBeUploaded = itemsCopied.slice(0, MAX_ATTACHMENTS - uploadedFiles.length)
setUploadedFiles(uploadedFiles.concat(itemsToBeUploaded))
if (items.length + uploadedFiles.length > MAX_ATTACHMENTS) {
toast(`Only up to ${MAX_ATTACHMENTS} attachments are allowed`)
}
event.target.value = ''
},
[uploadedFiles]
)
const removeFileUpload = useCallback(
(idx: number) => {
const updatedFiles = uploadedFiles.slice()
updatedFiles.splice(idx, 1)
setUploadedFiles(updatedFiles)
const updatedDataUrls = uploadedDataUrls.slice()
uploadedDataUrls.splice(idx, 1)
setUploadedDataUrls(updatedDataUrls)
},
[uploadedFiles, uploadedDataUrls]
)
useEffect(() => {
if (!uploadedFiles) return
const objectUrls = uploadedFiles.map((file) => {
if (file.name.endsWith('.har')) {
return file.name
} else {
return URL.createObjectURL(file)
}
})
setUploadedDataUrls(objectUrls)
return () => {
objectUrls.forEach((url: any) => void URL.revokeObjectURL(url))
}
}, [uploadedFiles])
const createAttachments = useCallback(async () => {
if (!profile?.id) {
console.error('[Support Form > uploadAttachments] Unable to upload files, missing user ID')
toast.error('Unable to upload attachments')
return []
}
if (uploadedFiles.length === 0) return
try {
const filenames = await uploadAttachments({ userId: profile.gotrue_id, files: uploadedFiles })
const urls = await generateAttachmentURLs({ bucket: 'support-attachments', filenames })
return urls
} catch {
// Ignore attachments upload errors, images are additional context and support can ask for more if needed
return
}
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [profile, uploadedFiles])
return useMemo(
() => ({
uploadButtonRef,
isFull,
addFile,
handleFileUpload,
removeFileUpload,
createAttachments,
uploadedDataUrls,
}),
[isFull, addFile, handleFileUpload, removeFileUpload, createAttachments, uploadedDataUrls]
)
}
interface AttachmentUploadDisplayProps {
uploadButtonRef: RefObject<HTMLInputElement | null>
isFull: boolean
uploadedDataUrls: string[]
addFile: () => void
handleFileUpload: (event: ChangeEvent<HTMLInputElement>) => Promise<void>
removeFileUpload: (idx: number) => void
}
export function AttachmentUploadDisplay({
uploadButtonRef,
isFull,
uploadedDataUrls,
addFile,
handleFileUpload,
removeFileUpload,
}: AttachmentUploadDisplayProps) {
const { profile } = useProfile()
if (!profile) {
return (
<div>
<h3 className="text-sm text-foreground">Attachments</h3>
<p className="text-sm text-foreground-lighter mt-2">
Uploads are only supported when logged in. Please reply to the acknowledgement email you
will receive with any screenshots you'd like to upload.
</p>
</div>
)
}
return (
<div className="flex flex-col gap-y-4">
<div className="flex flex-col gap-y-1">
<p className="text-sm text-foreground">Attachments</p>
<p className="text-sm text-foreground-lighter">
Optionally upload up to {MAX_ATTACHMENTS} relevant images or{' '}
<InlineLink href="https://github.com/orgs/supabase/discussions/36540">
HAR files
</InlineLink>
</p>
</div>
<input
multiple
type="file"
ref={uploadButtonRef}
className="hidden"
accept="image/png, image/jpeg, .har"
onChange={handleFileUpload}
/>
<div className="flex items-center gap-x-2">
{uploadedDataUrls.map((url, idx) => {
if (url.endsWith('.har')) {
return (
<div
key={url}
className="border relative h-14 w-14 rounded-sm flex items-center justify-center"
>
<Tooltip>
<TooltipTrigger className="cursor-default" onClick={(e) => e.preventDefault()}>
<div className="flex flex-col items-center justify-center gap-y-1">
<FileCode className="text-foreground-light" size={16} />
<p className="text-[10px] font-mono text-foreground-light tracking-wide leading-none">
HAR
</p>
</div>
</TooltipTrigger>
<TooltipContent side="bottom">{url}</TooltipContent>
</Tooltip>
<button
type="button"
tabIndex={0}
aria-label="Remove attachment"
className={removeAttachmentButtonClassName}
onClick={() => removeFileUpload(idx)}
>
<RemoveAttachmentIcon />
</button>
</div>
)
} else {
return (
<div
key={url}
style={{ backgroundImage: `url("${url}")` }}
className="relative h-14 w-14 rounded-sm bg-cover bg-center bg-no-repeat"
>
<button
type="button"
tabIndex={0}
aria-label="Remove attachment"
className={removeAttachmentButtonClassName}
onClick={() => removeFileUpload(idx)}
>
<RemoveAttachmentIcon />
</button>
</div>
)
}
})}
{!isFull && (
<button
type="button"
tabIndex={0}
aria-label="Add attachment"
className={cn(
'border border-stronger opacity-50 hover:opacity-100',
'group flex h-14 w-14 cursor-pointer items-center justify-center rounded-sm',
'focus-visible:opacity-100 focus-ring'
)}
onClick={addFile}
>
<Plus strokeWidth={2} size={20} />
</button>
)}
</div>
</div>
)
}