mirror of
https://github.com/supabase/supabase.git
synced 2026-10-06 01:45:10 +03:00
### Context Just some housekeeping/consolidate refactors. There's a number of places where we render the same "no result" empty state for tables. So this PR just consolidates that into a reusable component `TableRowNoResults` to reduce duplication. Opting to save this under `components/ui` instead of the `ui` package as this is more of a derivation of `TableRow` than a primitive <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **UI Improvements** - Standardized empty search-result messages across database, functions, storage, and vector bucket tables. - Search terms now appear consistently when no matching records are found. - Added an accessible label to the vector bucket row actions menu. - Improved the storage explorer loading layout so content expands to use available vertical space. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
137 lines
4.7 KiB
TypeScript
137 lines
4.7 KiB
TypeScript
import { FilesBucket as FilesBucketIcon } from 'icons'
|
|
import { ChevronRight } from 'lucide-react'
|
|
import { KeyboardEventHandler, MouseEventHandler } from 'react'
|
|
import { Badge, cn, TableCell, TableRow, Tooltip, TooltipContent, TooltipTrigger } from 'ui'
|
|
|
|
import type { AllowedBucketType } from './types'
|
|
import { PUBLIC_BUCKET_TOOLTIP } from '@/components/interfaces/Storage/Storage.constants'
|
|
import { useBucketPolicyCount } from '@/components/interfaces/Storage/useBucketPolicyCount'
|
|
import { VirtualizedTableCell, VirtualizedTableRow } from '@/components/ui/VirtualizedTable'
|
|
import { Bucket } from '@/data/storage/buckets-query'
|
|
import { formatBytes } from '@/lib/helpers'
|
|
|
|
type BucketTableMode = 'standard' | 'virtualized'
|
|
|
|
type BucketTableRowProps = {
|
|
mode: BucketTableMode
|
|
bucket: Bucket
|
|
onSelectBucket: (bucket: Bucket) => void
|
|
allowedBucketType: AllowedBucketType
|
|
formattedGlobalUploadLimit: string
|
|
}
|
|
|
|
export const BucketTableRow = ({
|
|
mode,
|
|
bucket,
|
|
onSelectBucket,
|
|
allowedBucketType,
|
|
formattedGlobalUploadLimit,
|
|
}: BucketTableRowProps) => {
|
|
const { getPolicyCount } = useBucketPolicyCount()
|
|
|
|
const BucketTableRow = mode === 'standard' ? TableRow : VirtualizedTableRow
|
|
const BucketTableCell = mode === 'standard' ? TableCell : VirtualizedTableCell
|
|
|
|
const isDisabled = !(
|
|
allowedBucketType === 'all' ||
|
|
(allowedBucketType === 'public' && bucket.public) ||
|
|
(allowedBucketType === 'private' && !bucket.public)
|
|
)
|
|
|
|
const handleRowActivate: MouseEventHandler<HTMLTableRowElement> = (e) => {
|
|
e.preventDefault()
|
|
if (isDisabled) return
|
|
onSelectBucket(bucket)
|
|
}
|
|
|
|
const handleRowKeyDown: KeyboardEventHandler<HTMLTableRowElement> = (e) => {
|
|
if (isDisabled) return
|
|
if (e.key === 'Enter' || e.key === ' ') {
|
|
e.preventDefault()
|
|
onSelectBucket(bucket)
|
|
}
|
|
}
|
|
|
|
return (
|
|
<Tooltip>
|
|
<TooltipTrigger asChild>
|
|
<BucketTableRow
|
|
key={bucket.id}
|
|
data-bucket-id={bucket.id}
|
|
className={cn(
|
|
'relative cursor-pointer h-16 group focus-inset',
|
|
isDisabled && 'opacity-50 [&>td]:hover:bg-transparent cursor-not-allowed'
|
|
)}
|
|
onClick={handleRowActivate}
|
|
onKeyDown={handleRowKeyDown}
|
|
tabIndex={isDisabled ? -1 : 0}
|
|
aria-disabled={isDisabled || undefined}
|
|
>
|
|
<BucketTableCell className="w-2 pr-1">
|
|
<FilesBucketIcon aria-label="bucket icon" size={16} className="text-foreground-muted" />
|
|
</BucketTableCell>
|
|
<BucketTableCell className="flex-1">
|
|
<div className="flex items-center gap-2.5">
|
|
<p className="whitespace-nowrap max-w-[512px] truncate">{bucket.id}</p>
|
|
{bucket.public && (
|
|
<Tooltip>
|
|
<TooltipTrigger asChild>
|
|
<Badge variant="warning" className="flex">
|
|
Public
|
|
</Badge>
|
|
</TooltipTrigger>
|
|
<TooltipContent side="top">{PUBLIC_BUCKET_TOOLTIP}</TooltipContent>
|
|
</Tooltip>
|
|
)}
|
|
</div>
|
|
</BucketTableCell>
|
|
|
|
<BucketTableCell>
|
|
<p className="text-foreground-light">{getPolicyCount(bucket.id)}</p>
|
|
</BucketTableCell>
|
|
|
|
<BucketTableCell>
|
|
<p
|
|
className={`whitespace-nowrap ${bucket.file_size_limit ? 'text-foreground-light' : 'text-foreground-muted'}`}
|
|
>
|
|
{bucket.file_size_limit
|
|
? formatBytes(bucket.file_size_limit)
|
|
: `Unset (${formattedGlobalUploadLimit})`}
|
|
</p>
|
|
</BucketTableCell>
|
|
|
|
<BucketTableCell>
|
|
<p
|
|
className={
|
|
bucket.allowed_mime_types ? 'text-foreground-light' : 'text-foreground-muted'
|
|
}
|
|
>
|
|
{bucket.allowed_mime_types ? bucket.allowed_mime_types.join(', ') : 'Any'}
|
|
</p>
|
|
</BucketTableCell>
|
|
|
|
<BucketTableCell>
|
|
{!isDisabled && (
|
|
<>
|
|
<div className="flex justify-end items-center h-full">
|
|
<ChevronRight aria-hidden={true} size={14} className="text-foreground-muted/60" />
|
|
</div>
|
|
<button tabIndex={-1} className="sr-only">
|
|
Go to bucket details
|
|
</button>
|
|
</>
|
|
)}
|
|
</BucketTableCell>
|
|
</BucketTableRow>
|
|
</TooltipTrigger>
|
|
{isDisabled && (
|
|
<TooltipContent>
|
|
{allowedBucketType === 'public'
|
|
? 'Private buckets are not selectable for this action. Please select a public bucket.'
|
|
: 'Public buckets are not selectable for this action. Please select a private bucket.'}
|
|
</TooltipContent>
|
|
)}
|
|
</Tooltip>
|
|
)
|
|
}
|