mirror of
https://github.com/supabase/supabase.git
synced 2026-10-05 17:35:10 +03:00
## Problem Primary colour serves readable text and selected controls, but those uses need different shades. Light mode needs darker text, while dark mode needs a deeper button fill. Fixed brand green on interactive chrome also prevents a custom primary hue from carrying through the interface. Some slider tracks and selected text are hard to read. ## Solution - Keep `--primary` for accessible text and small selected indicators. Use `--primary-solid` for button fills, which need a deeper shade in dark mode. - Add `--primary-bright` for focus rings, selected control chrome, chart accents, and other interactive highlights. It follows `--primary-hue`; `brand-*` stays fixed for Supabase identity. - Make slider troughs clearer and text selection translucent with theme foreground text. - Document the split in the design-system colour guide. | Before | After | | --- | --- | | <img width="980" height="244" alt="Before: light mode primary controls" src="https://github.com/user-attachments/assets/dfae325d-0dfe-4231-8bcd-3f89c4b9d793" /> | <img width="982" height="204" alt="After: light mode primary controls" src="https://github.com/user-attachments/assets/5fdcb531-a6e3-4549-8a13-9d9a5ebe6e20" /> | | <img width="610" height="120" alt="Before: slider track" src="https://github.com/user-attachments/assets/04f768e0-51e8-4d06-9b97-c52f4a34f122" /> | <img width="622" height="126" alt="After: slider track" src="https://github.com/user-attachments/assets/95127f4e-13dc-4f0f-b63c-cf5d70a28b42" /> | | <img width="652" height="512" alt="Before: dark mode controls" src="https://github.com/user-attachments/assets/3f88de66-90cc-40ee-8cf1-b5f4eb87b09a" /> | <img width="658" height="498" alt="After: dark mode controls" src="https://github.com/user-attachments/assets/906bec30-6ca1-4614-9fb3-6cf5e5feec22" /> | ## Review instructions 1. Compare light and dark mode in the [colour usage guide](https://design-system-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/design-system/docs/color-usage#primary-and-brand-colors). Check primary ink, primary-solid, primary-bright, and fixed brand swatches. 2. In Studio, open the ‘new table’ sheet in [Table Editor](https://studio-staging-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/dashboard/project/_/editor). Tab through the new table sheet's fields and toggles. Check the focus rings, selected controls, and the sheet's edges in both themes. You do not need to save a table. 3. Select text in Studio in both themes, including a link or primary-coloured label. The selection and text should remain legible. 4. Check the [Field](https://design-system-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/design-system/docs/components/field) Price Range slider: the unused track should remain visible in both themes. The selected field card border should follow primary-bright. 5. Check the [Button](https://design-system-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/design-system/docs/components/button) and [Radio Group](https://design-system-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/design-system/docs/components/radio-group) previews. In dark mode, `primary` button fill should be deeper than primary [text](https://design-system-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/design-system/docs/color-usage#text); selected radios should remain readable.
109 lines
3.9 KiB
TypeScript
109 lines
3.9 KiB
TypeScript
import { Trash } from 'lucide-react'
|
|
import { useEffect, useState } from 'react'
|
|
import { toast } from 'sonner'
|
|
import { Button, Checkbox } from 'ui'
|
|
import ConfirmationModal from 'ui-patterns/Dialogs/ConfirmationModal'
|
|
import { FormItemLayout } from 'ui-patterns/form/FormItemLayout/FormItemLayout'
|
|
|
|
import { DocsButton } from '@/components/ui/DocsButton'
|
|
import Panel from '@/components/ui/Panel'
|
|
import { useCustomDomainDeleteMutation } from '@/data/custom-domains/custom-domains-delete-mutation'
|
|
import type { CustomDomainResponse } from '@/data/custom-domains/custom-domains-query'
|
|
import { DOCS_URL } from '@/lib/constants'
|
|
|
|
export type CustomDomainDeleteProps = {
|
|
projectRef?: string
|
|
customDomain: CustomDomainResponse
|
|
}
|
|
|
|
export const CustomDomainDelete = ({ projectRef, customDomain }: CustomDomainDeleteProps) => {
|
|
const [removeCustomDomain, setRemoveCustomDomain] = useState(false)
|
|
const [isDeleteConfirmModalVisible, setIsDeleteConfirmModalVisible] = useState(false)
|
|
|
|
const { mutate: deleteCustomDomain, isPending: isDeletingCustomDomain } =
|
|
useCustomDomainDeleteMutation({
|
|
onSuccess: () => {
|
|
toast.success(
|
|
`Successfully deleted custom domain. Refresh your browser to see the changes.`
|
|
)
|
|
setIsDeleteConfirmModalVisible(false)
|
|
},
|
|
})
|
|
|
|
const onDeleteCustomDomain = async () => {
|
|
if (!projectRef) return console.error('Project ref is required')
|
|
deleteCustomDomain({ projectRef, removeAddon: removeCustomDomain })
|
|
}
|
|
|
|
useEffect(() => {
|
|
if (!isDeleteConfirmModalVisible) setRemoveCustomDomain(false)
|
|
}, [isDeleteConfirmModalVisible])
|
|
|
|
return (
|
|
<>
|
|
<Panel.Content>
|
|
<div className="w-full space-y-2">
|
|
<p className="text-xs text-foreground-light">Active custom domain:</p>
|
|
<div className="flex items-center space-x-2">
|
|
<code className="text-lg mx-0 flex items-center space-x-2">
|
|
<div className="h-2 w-2 rounded-full bg-primary-bright" />
|
|
<span>
|
|
<code className="text-code-inline">{customDomain.hostname}</code>
|
|
</span>
|
|
</code>
|
|
</div>
|
|
<p className="text-sm text-foreground-light">
|
|
Your custom domain is currently active and is serving traffic
|
|
</p>
|
|
</div>
|
|
</Panel.Content>
|
|
|
|
<div className="w-full border-t border-muted" />
|
|
|
|
<Panel.Content className="w-full">
|
|
<div className="flex items-center justify-between">
|
|
<DocsButton href={`${DOCS_URL}/guides/platform/custom-domains`} />
|
|
<Button
|
|
variant="danger"
|
|
icon={<Trash />}
|
|
onClick={() => setIsDeleteConfirmModalVisible(true)}
|
|
>
|
|
Delete custom domain
|
|
</Button>
|
|
</div>
|
|
</Panel.Content>
|
|
|
|
<ConfirmationModal
|
|
visible={isDeleteConfirmModalVisible}
|
|
variant="destructive"
|
|
title="Delete custom domain"
|
|
confirmLabel="Delete"
|
|
confirmLabelLoading="Deleting"
|
|
loading={isDeletingCustomDomain}
|
|
onCancel={() => setIsDeleteConfirmModalVisible(false)}
|
|
onConfirm={onDeleteCustomDomain}
|
|
>
|
|
<p className="text-sm mb-4">
|
|
Are you sure you want to delete the custom domain{' '}
|
|
<code className="text-code-inline break-normal!">{customDomain.hostname}</code> for your
|
|
project? You will need to re-verify this domain if you want to use it again.
|
|
</p>
|
|
|
|
<FormItemLayout
|
|
isReactForm={false}
|
|
layout="flex"
|
|
name="removeCustomDomain"
|
|
label="Also remove custom domain add-on"
|
|
description="Stops the monthly add-on charge for this project"
|
|
className="[&>div:first-child>button]:translate-y-0.5"
|
|
>
|
|
<Checkbox
|
|
checked={removeCustomDomain}
|
|
onCheckedChange={(value) => setRemoveCustomDomain(!!value)}
|
|
/>
|
|
</FormItemLayout>
|
|
</ConfirmationModal>
|
|
</>
|
|
)
|
|
}
|