mirror of
https://github.com/supabase/supabase.git
synced 2026-10-05 17:35:10 +03:00
## Problem Primary colour serves readable text and selected controls, but those uses need different shades. Light mode needs darker text, while dark mode needs a deeper button fill. Fixed brand green on interactive chrome also prevents a custom primary hue from carrying through the interface. Some slider tracks and selected text are hard to read. ## Solution - Keep `--primary` for accessible text and small selected indicators. Use `--primary-solid` for button fills, which need a deeper shade in dark mode. - Add `--primary-bright` for focus rings, selected control chrome, chart accents, and other interactive highlights. It follows `--primary-hue`; `brand-*` stays fixed for Supabase identity. - Make slider troughs clearer and text selection translucent with theme foreground text. - Document the split in the design-system colour guide. | Before | After | | --- | --- | | <img width="980" height="244" alt="Before: light mode primary controls" src="https://github.com/user-attachments/assets/dfae325d-0dfe-4231-8bcd-3f89c4b9d793" /> | <img width="982" height="204" alt="After: light mode primary controls" src="https://github.com/user-attachments/assets/5fdcb531-a6e3-4549-8a13-9d9a5ebe6e20" /> | | <img width="610" height="120" alt="Before: slider track" src="https://github.com/user-attachments/assets/04f768e0-51e8-4d06-9b97-c52f4a34f122" /> | <img width="622" height="126" alt="After: slider track" src="https://github.com/user-attachments/assets/95127f4e-13dc-4f0f-b63c-cf5d70a28b42" /> | | <img width="652" height="512" alt="Before: dark mode controls" src="https://github.com/user-attachments/assets/3f88de66-90cc-40ee-8cf1-b5f4eb87b09a" /> | <img width="658" height="498" alt="After: dark mode controls" src="https://github.com/user-attachments/assets/906bec30-6ca1-4614-9fb3-6cf5e5feec22" /> | ## Review instructions 1. Compare light and dark mode in the [colour usage guide](https://design-system-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/design-system/docs/color-usage#primary-and-brand-colors). Check primary ink, primary-solid, primary-bright, and fixed brand swatches. 2. In Studio, open the ‘new table’ sheet in [Table Editor](https://studio-staging-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/dashboard/project/_/editor). Tab through the new table sheet's fields and toggles. Check the focus rings, selected controls, and the sheet's edges in both themes. You do not need to save a table. 3. Select text in Studio in both themes, including a link or primary-coloured label. The selection and text should remain legible. 4. Check the [Field](https://design-system-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/design-system/docs/components/field) Price Range slider: the unused track should remain visible in both themes. The selected field card border should follow primary-bright. 5. Check the [Button](https://design-system-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/design-system/docs/components/button) and [Radio Group](https://design-system-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/design-system/docs/components/radio-group) previews. In dark mode, `primary` button fill should be deeper than primary [text](https://design-system-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/design-system/docs/color-usage#text); selected radios should remain readable.
69 lines
2.4 KiB
TypeScript
69 lines
2.4 KiB
TypeScript
import { ExternalLink, HelpCircle, LockKeyholeOpen, RectangleEllipsis } from 'lucide-react'
|
|
import { HoverCard, HoverCardContent, HoverCardTrigger } from 'ui'
|
|
|
|
import { AlgorithmDetail, algorithmDetails } from './algorithm-details'
|
|
|
|
interface AlgorithmHoverCardProps {
|
|
algorithm: keyof typeof algorithmDetails
|
|
legacy?: boolean
|
|
}
|
|
|
|
export const AlgorithmHoverCard = ({ algorithm, legacy }: AlgorithmHoverCardProps) => {
|
|
const details: AlgorithmDetail = algorithmDetails[algorithm]
|
|
|
|
return (
|
|
<div className="flex items-center gap-x-2">
|
|
{algorithm === 'HS256' ? (
|
|
<RectangleEllipsis className="shrink-0" size={14} />
|
|
) : (
|
|
<LockKeyholeOpen className="shrink-0" size={14} />
|
|
)}
|
|
<p>{legacy ? `Legacy ${details.label}` : details.label}</p>
|
|
<HoverCard closeDelay={50} openDelay={300}>
|
|
<HoverCardTrigger className="min-w-0">
|
|
<HelpCircle size={14} className="text-foreground-lighter" />
|
|
</HoverCardTrigger>
|
|
<HoverCardContent className="w-88 flex items-start gap-3" side="right" align="center">
|
|
<div className="flex-1">
|
|
<h4 className="font-semibold truncate">{details.name}</h4>
|
|
<div className="flex flex-col gap-2 text-sm text-foreground-light">
|
|
<p>{details.description}</p>
|
|
<p>
|
|
Pros:
|
|
<ul className="list-disc pl-6">
|
|
{details.pros.map((pro, i) => (
|
|
<li key={i}>{pro}</li>
|
|
))}
|
|
</ul>
|
|
</p>
|
|
<p>
|
|
Cons:{' '}
|
|
<ul className="list-disc pl-6">
|
|
{details.cons.map((con, i) => (
|
|
<li key={i}>{con}</li>
|
|
))}
|
|
</ul>
|
|
<br />
|
|
</p>
|
|
</div>
|
|
<div className="space-y-1 mt-2">
|
|
{details.links.map((link, index) => (
|
|
<a
|
|
key={index}
|
|
href={link.url}
|
|
target="_blank"
|
|
rel="noopener noreferrer"
|
|
className="text-xs text-primary hover:text-primary-hover flex items-center"
|
|
>
|
|
<ExternalLink className="w-3 h-3 mr-1 shrink-0" />
|
|
<span className="truncate">{link.label}</span>
|
|
</a>
|
|
))}
|
|
</div>
|
|
</div>
|
|
</HoverCardContent>
|
|
</HoverCard>
|
|
</div>
|
|
)
|
|
}
|