## I have read the [CONTRIBUTING.md](https://github.com/supabase/supabase/blob/master/CONTRIBUTING.md) file. YES ## What kind of change does this PR introduce? Feature (SQL editor: execution wiring for logs-source snippets). Part of the stacked SQL-editor "Database vs Logs" query-source series. ## What is the current behavior? The SQL editor only ever runs queries against the user's Postgres database. There is no execution path for a logs (`log_sql`) snippet, and the run-button telemetry event carries no backend discriminator. ## What is the new behavior? - `useRunSource(id)` derives the run backend from the snippet type; a `log_sql` snippet resolves to `{ type: 'logs', dateRange }`, pairing the run with its session time range (default: last hour). - `useLogsSqlExecution` runs a promoted `SafeLogSqlFragment` against the analytics OTEL (ClickHouse) endpoint with the resolved time range as `iso_timestamp_start`/`iso_timestamp_end` request params. The endpoint is **pinned to OTEL** — a snippet's dialect must not flip with org migration. - The run gestures (toolbar button and Cmd+Enter) branch on the source and promote with the matching `acceptUntrusted*` right at the user action, preserving the auditable promotion-at-gesture boundary. pg intellisense is gated off for logs snippets. - The `sql_editor_query_run_button_clicked` telemetry event gains a required `{ source: 'database' | 'logs' }` property, fired from both execution paths. - Capability guard: a `log_sql` snippet is reachable by direct URL regardless of the (later) entry-point flag gating, so `executeLogsQuery` short-circuits when `otelLegacyLogs` is off — recording a clear "not available yet" result message instead of firing a request that would only return an opaque backend error on a non-ClickHouse project. This is a guard on the gesture, not endpoint selection. - Tests: `useRunSource` routing, `useLogsSqlExecution` endpoint/range/structured-error/capability-guard, and a reusable `flags` option on `renderSqlEditorHook`. No UI entry points are added — the feature runs dark until the flag-gated creation/nav PRs later in the stack. ## Additional context Stacked on the query-source series; base branch is `master` now that PR 4 (log date range domain + session state, #48401) is merged. Follow-ups in the stack add the toolbar/creation UI (with a run-affordance gate on `otelLegacyLogs`), nav section, AI dialect support, and reports guard. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added support for running log queries directly from the SQL editor. * Log query results, errors, and time ranges are now handled within the editor session. * Added automatic selection between database and log query execution, including support for custom date ranges. * SQL assistance is disabled while editing log queries where database definitions do not apply. * **Tests** * Added coverage for log query execution, date ranges, feature availability, and execution source selection. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
SQL Editor Overview
Quick run-through of the different building blocks that make up the SQL Editor, to help navigating the codebase a little easier 🙂🙏
UI structure
-
Folders and snippets (in the product menu) are rendered via
SQLEditorMenuandSQLEditorNav, in which the data are all loaded from the API via React Query directly. (Refer to point 3 under "Data Structure" below)SQLEditorMenu: Wraps aroundSQLEditorNav+ renders search input + View running queries buttonSQLEditorNav: Renders the 3 collapsible snippet sections
-
The Tabs interface is powered by a separate state
tabs.ts. (Also used by the Table Editor) -
Route validation to check for snippet validity + last visited snippet lies in the page level on
[id].tsx -
When searching for snippets, we're deliberately opting to render the results as a flat list in
SearchListfor ease of finding (rather than keeping the 3 separate sections / having folders)
Data structure
-
SQL Editor is mainly powered by a Valtio store in
sql-editor-v2.ts, in which most of the data is being managed on the client side for optimistic rendering to keep the editor feeling snappy. (unlike other parts of the dashboard where the data is always invalidated whenever a mutation happens). -
The Valtio store here stores snippets across multiple projects as we aren't using a context provider, though this was a legacy decision (refer to
ProjectContextfor more context on using providers with stores) -
While
SQLEditorNavrenders the folders + snippets directly from the API endpoints via React Query, we still store them in the Valtio store to store some properties used on the client side likesplitSizesandprojectReffor snippets, andstatusfor folders (although it's possible that we can simplify the Valtio store).
Data fetching
-
The endpoint to fetch snippets and folders are via
useSQLSnippetFoldersQueryanduseSqlSnippetsQuery, both of which are paginated (limit set at 100)useSQLSnippetFoldersQuery: Specifically for fetching private snippets and foldersuseSqlSnippetsQuery: For fetching shared and favorite snippets
-
Page fetching is done on demand for the snippets via a "Load more" button due to the complexity of a tree view (we've deliberate avoided an infinite loading UX which we commonly do across other parts of the dashboard)
Data flow
Landing on the SQL Editor
-
Snippets and folders are all initially loaded via React Query in
SQLEditorNav, which are then initialized into the Valtio store viasnapV2.addSnippetcalls in theuseEffects -
On
/editor/sql- We'll redirect users to the last visited snippet if there's one (
/editor/sql/[id]), otherwise will redirect to/editor/sql/new(within[id].tsx)
- We'll redirect users to the last visited snippet if there's one (
-
On
/editor/sql/[id]- We'll load the content of the snippet via
useContentQueryand update the Valtio store viasnapV2.setSnippet
- We'll load the content of the snippet via
Writing a snippet
-
On
/editor/sql/new:- The first character input will update the Valtio store with a snippet skeleton via
snapV2.addSnippetand user will be redirected to/editor/sql/[id], using theidfrom the skeleton - Note that
snapV2.addSnippetonly handles adding snippets to the store and does not queue the snippet for saving - Subsequent character inputs will follow below as per
/editor/sql/[id]
- The first character input will update the Valtio store with a snippet skeleton via
-
On
/editor/sql/[id]:snapV2.setSqlwill be called based on the debounced value of the code editor, in which we'll then queue the snippet for saving viaupsertSnippet.- Note that we do invalidate some React Queries (snippet count, snippets, and folders) after saving via
upsertSnippet, but the invalidation is only triggered if it's a new snippet that's not saved in the DB yet
Running a snippet
-
There's several safeguards in place before we run the query
- Check for destructive operations: Will open a confirmation modal before running the query
- Check for update statements without where clause: Will open a confirmation modal before running the query
- Append a preset limit to the query if it's a select: To prevent accidentally running an expensive query on the database. Users can explicitly opt out of this to set "No limit"
-
If the snippet's name is "Untitled query", we'll also trigger a non-blocking request to rename the snippet via AI. Snippet name will be updated whenever the request completes.
Renaming, Moving, Deleting, Sharing snippets
- These functionalities all call
upsertContentvia React Query directly without going through the Valtio store - We thereafter update the Valtio stores for the SQL Editor and Tabs as required if the upsert is successful
Possible areas to simplify, refactor, or improve
-
updateSnippetandsetSqlcould be consolidated insql-editor-v2.ts -
Refactor renaming a query to have optimistic rendering for consistency on how we update snippets in the
sql-editor-v2.ts -
Implement drag and drop functionality for snippets into folders
-
RenameQueryModalandMoveQueryModal, could callupdateSnippetinstead ofremoveSnippet+addSnippet?