Files
supabase/apps/studio/data/content/notebooks/notebook-cache.test.ts
Charis de3a8799d6 fix(studio): invalidate notebook caches after assistant create/update (#49415)
## Summary
- The assistant's `create_notebook`/`update_notebook` tools run entirely
server-side, so an open notebook tab's React Query cache and Valtio
store never learn a write happened — the tab keeps showing stale content
until a manual reload.
- Adds `collectNotebookCacheEffects`/`applyNotebookCacheEffects`
(`apps/studio/lib/ai/notebook-cache-invalidation.ts`), which scan
finished assistant messages for completed
`create_notebook`/`update_notebook` tool calls and evict the affected
notebook via `evictNotebookFromCaches`
(`apps/studio/data/content/notebooks/notebook-cache.ts`), plus
invalidate the nav list.
- Wired into `createChatInstance`'s `onFinish` in
`state/ai-assistant-state.tsx`, with per-chat dedupe so replayed history
isn't reprocessed.
- Removes the cache entry outright rather than invalidating it, since a
remounting `useNotebookQuery` would otherwise read the stale cached
value synchronously before its refetch lands.
- Explicitly skips eviction when the open tab has unsaved local edits,
so an assistant write can't silently discard them.

Related: [FE-4235](https://linear.app/supabase/issue/FE-4235)

**Out of scope:** this only protects the client-side cache/store from
being clobbered after the fact. Preventing the assistant's
`update_notebook` tool call itself from overwriting a user's unsaved
edits (a data-layer conflict, not a cache-freshness one) is tracked
separately in [FE-4255](https://linear.app/supabase/issue/FE-4255).

## Test plan
- [x] `pnpm test:studio -- notebook-cache notebook-cache-invalidation
ai-assistant-state.notebook-cache-invalidation
ExplorerNotebookTab.assistant-cache-invalidation
ExplorerNotebookTabCoordinator` — all passing
- [x] Reproduction-first component test
(`ExplorerNotebookTab.assistant-cache-invalidation.test.tsx`) — verified
it fails without the fix (stale content persists) and passes with it
- [x] Regression test for the dirty-notebook guard (an edited, unsaved
notebook is left untouched by an assistant write)
- [x] `pnpm typecheck --filter=studio` / `pnpm lint --filter=studio`
clean


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Bug Fixes**
* Notebook changes made through the AI assistant now appear correctly in
open notebook tabs and after reopening them.
* Saved notebook caches are refreshed after completed create or update
actions, preventing stale content from being displayed.
  * Unsaved notebook changes are preserved during cache cleanup.
  * Closing a notebook tab now consistently removes its cached content.

* **Tests**
* Added coverage for assistant-driven updates, remounts, duplicate
actions, project context changes, and cache behavior.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2026-08-25 14:15:27 +08:00

91 lines
2.7 KiB
TypeScript

import { QueryClient } from '@tanstack/react-query'
import { afterEach, describe, expect, it } from 'vitest'
import { evictNotebookFromCaches } from './notebook-cache'
import { contentKeys } from '@/data/content/keys'
import { notebooksState } from '@/state/notebooks/notebooks-state'
import type { Notebook } from '@/state/notebooks/types'
const PROJECT_REF = 'default'
const NOTEBOOK_ID = 'notebook-cache-test'
const NOTEBOOK: Notebook = {
id: NOTEBOOK_ID,
type: 'notebook',
name: 'Test notebook',
visibility: 'project',
favorite: false,
owner_id: 1,
project_id: 1,
content: { schema_version: 1, cells: [] },
}
const seedNotebook = (status: 'new' | 'saved') => {
delete notebooksState.notebooks[NOTEBOOK_ID]
if (status === 'new') {
notebooksState.addNotebook({ projectRef: PROJECT_REF, notebook: NOTEBOOK })
} else {
notebooksState.setNotebook({ projectRef: PROJECT_REF, notebook: NOTEBOOK })
}
}
const seedQueryData = (queryClient: QueryClient) =>
queryClient.setQueryData(contentKeys.resource(PROJECT_REF, NOTEBOOK_ID), { id: NOTEBOOK_ID })
afterEach(() => {
delete notebooksState.notebooks[NOTEBOOK_ID]
notebooksState.needsSaving.clear()
})
describe('evictNotebookFromCaches', () => {
it('removes a saved notebook from the store and drops its cache entry', async () => {
seedNotebook('saved')
const queryClient = new QueryClient()
seedQueryData(queryClient)
const evicted = await evictNotebookFromCaches({
queryClient,
projectRef: PROJECT_REF,
id: NOTEBOOK_ID,
})
expect(evicted).toBe(true)
expect(notebooksState.notebooks[NOTEBOOK_ID]).toBeUndefined()
expect(queryClient.getQueryData(contentKeys.resource(PROJECT_REF, NOTEBOOK_ID))).toBeUndefined()
})
it('leaves an unsaved notebook and its cache entry untouched', async () => {
seedNotebook('new')
const queryClient = new QueryClient()
seedQueryData(queryClient)
const evicted = await evictNotebookFromCaches({
queryClient,
projectRef: PROJECT_REF,
id: NOTEBOOK_ID,
})
expect(evicted).toBe(false)
expect(notebooksState.notebooks[NOTEBOOK_ID]).toBeDefined()
expect(queryClient.getQueryData(contentKeys.resource(PROJECT_REF, NOTEBOOK_ID))).toEqual({
id: NOTEBOOK_ID,
})
})
it('no-ops for an id not present in the store', async () => {
const queryClient = new QueryClient()
seedQueryData(queryClient)
const evicted = await evictNotebookFromCaches({
queryClient,
projectRef: PROJECT_REF,
id: NOTEBOOK_ID,
})
expect(evicted).toBe(false)
expect(queryClient.getQueryData(contentKeys.resource(PROJECT_REF, NOTEBOOK_ID))).toEqual({
id: NOTEBOOK_ID,
})
})
})