mirror of
https://github.com/supabase/supabase.git
synced 2026-10-18 07:39:07 +03:00
## What kind of change does this PR introduce? Accessibility cleanup (DEPR-628). ## What is the current behavior? Leftover call sites still use ad-hoc focus recipes (`ring-foreground-muted`, `outline-brand`, Dialog/Sheet `focus:` rings, etc.) instead of the shared utilities from #41575. ## What is the new behavior? Converts those leftovers across `packages/ui`, Studio, www, docs, and design-system to `focus-ring`, preferring `focus-visible`. Keeps documented exceptions (`group-focus-visible`, InputGroup `:has()`). ## To test Tab through controls (keyboard only). Expect a consistent offset ring on `:focus-visible`, not a green/brand/custom stack, and no ring animation. ### www (marketing) Preview: https://zone-www-dot-com-git-danny-depr-628-focus-ring-fbccf9-supabase.vercel.app - Global nav on `/`: Product, Developers, Solutions dropdowns; logo; hamburger + mobile menu - `/features`: view toggles and feature cards - `/company`: card links - `/changelog`: timeline / entry links - `/partners/catalog`: grid/list toggle and partner cards - `/pricing`: compute section expand control - Product / Modules / Solutions sticky navs on product pages (e.g. `/database`, `/storage`) - `/state-of-startups`: TwoOptionToggle if present ### docs Preview: https://docs-git-danny-depr-628-focus-ring-long-tail-supabase.vercel.app - Any guide page: top nav dropdowns and items - Narrow viewport: hamburger, then mobile menu links + close - Guide with PromptPanel / tabs: tab to prompt actions and tab list ### studio (dashboard) Preview: https://studio-staging-git-danny-depr-628-focus-ring-long-tail-supabase.vercel.app - Project home: Connect section tiles; drag-handle focus on sortable sections - Integrations marketplace (`/project/<ref>/integrations`): featured cards, list/grid toggle, list rows - Auth (`/project/<ref>/auth/oauth-apps`, `/project/<ref>/auth/providers`): open create/edit sheet, tab to close (X) - Database policies (`/project/<ref>/database/policies`): open policy editor sheet, tab to close - Storage policies (`/project/<ref>/storage/files/policies`): bucket section links; policy modal close - Query performance (`/project/<ref>/observability/query-performance`): info icon buttons on metrics - Replication pipeline detail (if available): slot lag / status info icons - Support (`/support/new`): attachment add/remove controls - Table editor: spreadsheet import preview checkboxes; row text/JSON editor TwoOptionToggle - Any Dialog/Sheet/toast close (X): ring on keyboard focus only, not mouse click ### design-system Preview: https://design-system-git-danny-depr-628-focus-ring-long-tail-supabase.vercel.app - Colour palette swatches (keyboard focus) - Form patterns sidepanel example: avatar / focusable control in the example ## Additional context - Linear: [DEPR-628](https://linear.app/supabase/issue/DEPR-628) - Follow-ups: form-group CSS (DEPR-629), Storage columns selection (DEPR-630), ESLint rule (DEPR-632) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Accessibility & Usability** * Standardized keyboard focus indicators across navigation, dialogs, forms, buttons, toggles, links, and tooltips using a consolidated focus style. * Improved toggle controls to use proper button semantics (instead of clickable text), including `aria-pressed`/disabled handling and better keyboard navigation. * **Visual Updates** * Harmonized hover/focus ring visuals across the design system, Studio, documentation, and marketing pages while preserving existing layout and interaction behavior. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
184 lines
8.4 KiB
TypeScript
184 lines
8.4 KiB
TypeScript
'use client'
|
|
|
|
import { useBreakpoint } from 'common'
|
|
import { ChevronRight, Sparkles } from 'lucide-react'
|
|
import Image from 'next/image'
|
|
import Link from 'next/link'
|
|
import React from 'react'
|
|
import { NavigationMenuLink } from 'ui'
|
|
import { TextLink } from 'ui-patterns/TextLink'
|
|
|
|
import MenuItem from './MenuItem'
|
|
import ComparisonsData from '@/data/Comparisons'
|
|
import CustomersData from '@/data/CustomerStories'
|
|
import MainProductsData from '@/data/MainProducts'
|
|
import ProductModulesData from '@/data/ProductModules'
|
|
|
|
export const ProductDropdown = () => {
|
|
const isTablet = useBreakpoint(1279)
|
|
|
|
return (
|
|
<div className="flex flex-col xl:flex-row">
|
|
<div className="flex flex-col">
|
|
<div className="flex flex-row py-6 px-6 gap-2">
|
|
<ul className="flex flex-col gap-4 w-[280px] xl:w-[250px]">
|
|
{Object.values(MainProductsData)
|
|
.filter((product) => product.name !== 'Vector')
|
|
.map((product) => (
|
|
<NavigationMenuLink key={product.name} asChild>
|
|
<MenuItem
|
|
title={product.name}
|
|
href={product.url}
|
|
description={product.description_short}
|
|
icon={product.icon}
|
|
className="h-fit p-0"
|
|
hasChevron
|
|
/>
|
|
</NavigationMenuLink>
|
|
))}
|
|
</ul>
|
|
<div className="flex flex-col gap-4 w-[250px]">
|
|
<div className="group flex items-center gap-1 text-foreground-lighter text-xs uppercase tracking-widest font-mono">
|
|
Modules
|
|
</div>
|
|
<ul className="flex flex-col gap-4">
|
|
{Object.values(ProductModulesData).map((productModule) => (
|
|
<NavigationMenuLink key={productModule.name} asChild>
|
|
<Link
|
|
href={productModule.url}
|
|
className="
|
|
h-fit group/menu-item
|
|
flex items-start gap-2
|
|
text-xs leading-none
|
|
text-foreground-light hover:text-foreground
|
|
no-underline select-none
|
|
focus-ring focus-visible:text-foreground
|
|
"
|
|
>
|
|
<div className="w-8 h-8 min-w-8 shrink-0 bg-background border flex items-center justify-center rounded-md">
|
|
<svg
|
|
className="h-4 w-4 group-hover/menu-item:text-foreground group-focus-visible/menu-item:text-foreground"
|
|
xmlns="http://www.w3.org/2000/svg"
|
|
fill="none"
|
|
viewBox="0 0 24 24"
|
|
aria-hidden="true"
|
|
>
|
|
<path
|
|
strokeLinecap="round"
|
|
strokeLinejoin="round"
|
|
strokeWidth="1.5"
|
|
d={productModule.icon}
|
|
stroke="currentColor"
|
|
/>
|
|
</svg>
|
|
</div>
|
|
<div className="flex flex-col justify-center">
|
|
<div className="flex items-center gap-1">
|
|
<p className="leading-snug text-foreground">{productModule.name}</p>
|
|
<ChevronRight
|
|
strokeWidth={2}
|
|
className="w-3 h-3 text-foreground transition-all will-change-transform -translate-x-1 opacity-0 group-hover/menu-item:translate-x-0 group-hover/menu-item:opacity-100"
|
|
/>
|
|
</div>
|
|
{productModule.description_short && (
|
|
<p className="line-clamp-2 leading-tight text-foreground-lighter group-hover/menu-item:text-foreground-light group-focus-visible/menu-item:text-foreground-light">
|
|
{productModule.description_short}
|
|
</p>
|
|
)}
|
|
</div>
|
|
</Link>
|
|
</NavigationMenuLink>
|
|
))}
|
|
</ul>
|
|
<div className="pt-4 border-t">
|
|
<Link
|
|
href="/features"
|
|
className="
|
|
h-fit group/menu-item
|
|
flex items-start gap-2
|
|
text-xs leading-none
|
|
text-foreground-light hover:text-foreground
|
|
no-underline select-none
|
|
focus-ring focus-visible:text-foreground
|
|
"
|
|
>
|
|
<div className="w-8 h-8 min-w-8 shrink-0 bg-background border flex items-center justify-center rounded-md">
|
|
<Sparkles size={16} strokeWidth={1.3} />
|
|
</div>
|
|
<div className="flex flex-col justify-center">
|
|
<div className="flex items-center gap-1">
|
|
<p className="leading-snug text-foreground">Features</p>
|
|
<ChevronRight
|
|
strokeWidth={2}
|
|
className="w-3 h-3 text-foreground transition-all will-change-transform -translate-x-1 opacity-0 group-hover/menu-item:translate-x-0 group-hover/menu-item:opacity-100"
|
|
/>
|
|
</div>
|
|
<span className="line-clamp-2 leading-tight text-foreground-lighter group-hover/menu-item:text-foreground-light group-focus-visible/menu-item:text-foreground-light">
|
|
Explore everything you can do with Supabase.
|
|
</span>
|
|
</div>
|
|
</Link>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
<div className="bg-surface-75 border-t xl:border-t-0 xl:border-l p-6 gap-8 flex flex-col w-full xl:w-[400px]">
|
|
<div className="col-span-3 flex flex-row gap-8 xl:w-auto">
|
|
<div>
|
|
<Link
|
|
href="/customers"
|
|
className="group flex items-center gap-1 text-foreground-lighter hover:text-foreground text-xs uppercase tracking-widest font-mono mb-4 focus-ring focus-visible:ring-offset-4 focus-visible:ring-offset-background-alternative rounded-xs focus-visible:text-foreground"
|
|
>
|
|
Customer Stories
|
|
<ChevronRight className="h-3 w-3 transition-transform will-change-transform -translate-x-1 group-hover:translate-x-0" />
|
|
</Link>
|
|
<ul className="flex flex-row gap-2">
|
|
{CustomersData.slice(0, isTablet ? 1 : 1).map((customer) => (
|
|
<li key={customer.organization}>
|
|
<Link
|
|
href={customer.url}
|
|
className="group flex items-center gap-3 focus-ring focus-visible:ring-offset-4 focus-visible:ring-offset-background-alternative rounded-sm"
|
|
>
|
|
<div className="relative rounded-md bg-background border group-hover:border-foreground-muted/50 h-14 w-28 xl:h-14 xl:w-20 shrink-0 overflow-auto">
|
|
<Image
|
|
src={`/${customer.imgUrl}`}
|
|
alt={customer.title}
|
|
fill
|
|
className="p-3! object-contain brightness-70 contrast-[.35] filter"
|
|
/>
|
|
</div>
|
|
<div className="flex flex-col">
|
|
<h4 className="text-light group-hover:text-foreground group-focus-visible:text-foreground text-normal mb-0 text-sm line-clamp-3 leading-tight">
|
|
{customer.title}
|
|
</h4>
|
|
</div>
|
|
</Link>
|
|
</li>
|
|
))}
|
|
</ul>
|
|
</div>
|
|
</div>
|
|
<div className="w-full col-span-2 grid grid-cols-4 xl:grid-cols-5 gap-6 xl:gap-2">
|
|
<div className="col-span-2 xl:col-span-3">
|
|
<p className="text-foreground-lighter text-xs uppercase tracking-widest font-mono mb-3">
|
|
{ComparisonsData.label}
|
|
</p>
|
|
<ul className="flex flex-col gap-2">
|
|
{ComparisonsData.comparisons.map((link) => (
|
|
<li key={link.text}>
|
|
<TextLink
|
|
chevronAnimation="fadeIn"
|
|
url={link.url}
|
|
label={link.text}
|
|
className="mt-0 hover:text-foreground focus-visible:text-foreground focus-visible:ring-offset-4 focus-visible:ring-offset-background-overlay"
|
|
/>
|
|
</li>
|
|
))}
|
|
</ul>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
)
|
|
}
|