mirror of
https://github.com/supabase/supabase.git
synced 2026-10-14 13:49:09 +03:00
## What kind of change does this PR introduce? Accessibility / lint hardening (Safari keyboard focus). ## What is the current behavior? `supabase/require-explicit-tabindex` is `'warn'`. Studio’s ratchet was at 0 but the rule was still ratcheted; www / docs / design-system still had raw `<button>` / `role="button"` call sites without an explicit `tabIndex`. [DEPR-627](https://linear.app/supabase/issue/DEPR-627) · follow-up to #47984 / #48040 ## What is the new behavior? - Shared config: `'supabase/require-explicit-tabindex': 'error'` - Swept www / docs / design-system (+ Studio test fixtures the ratchet skipped) - Removed the rule from the Studio ratchet + baselines ## To test Prefer **Safari**. This PR only adds explicit `tabIndex` to raw `<button>` / `role="button"` call sites — not links, and not controls that already go through `Button` from `ui`. ### Marketing (`www`) ([staging link](https://zone-www-dot-com-git-danny-depr-627-promote-req-7ae43c-supabase.vercel.app/)) - [x] Homepage frameworks / dashboard feature tabs — Tab through each tab button - [x] Product pages (e.g. `/auth`, `/database`) — section tab switchers - [x] Narrow viewport — open the hamburger; Tab through menu buttons - [x] `/partners/catalog` — filter / view controls - [x] Blog view toggle (list ↔ grid) ### Docs ([staging link](https://docs-git-danny-depr-627-promote-require-explici-25e46d-supabase.vercel.app/)) - [x] **Desktop (≥ lg):** top-right **⋯ menu** (hamburger icon) — opens a dropdown that includes Theme. Not a separate theme button. - [x] **Mobile (< lg):** top-right **hamburger** opens the sheet; close (X) is the raw button we tagged. Theme inside the sheet uses `ThemeToggle` / `DropdownMenuTrigger` from `ui` (already supposed to set `tabIndex`). - [x] **Code blocks** — copy / language controls - [x] **Is this helpful?** — X / check are `Button` from `ui` (should already Tab). After voting **while signed in**, the follow-up “What went well?” / “How can we improve?” text button is the raw one we tagged. - [x] **AI Tools → Copy as Markdown** (right rail on a guide) — this is the only GuidesSidebar control this PR changed. “On this page” TOC items are **links**, not covered by this lint. - [x] **Reference docs** (e.g. JS client reference) — section headers that expand/collapse in the left nav (`Collapsible.Trigger`) - [x] **Troubleshooting index** — type in the search field, then Tab to the **clear (X)** control ### Dashboard (`studio`) No production UI changes in this PR (tests + lint config only). Quick Safari smoke that prior tabindex work still holds: - [x] Project sidebar — Tab through primary nav links - [x] Settings → General — Tab through inputs / buttons - [x] Storage → Files — Tab a bucket row / file actions
130 lines
3.4 KiB
TypeScript
130 lines
3.4 KiB
TypeScript
import { AnimatePresence, motion, useAnimation } from 'framer-motion'
|
|
import { useEffect, useState, type ReactNode } from 'react'
|
|
import { cn } from 'ui'
|
|
|
|
interface TabProps {
|
|
label: ReactNode
|
|
isActive: boolean
|
|
onClick: VoidFunction
|
|
}
|
|
|
|
const Tab = ({ isActive, label, onClick }: TabProps) => (
|
|
<button
|
|
tabIndex={0}
|
|
onClick={onClick}
|
|
className={`text-left text-lg flex flex-col group gap-1 transition-opacity flex-1 ${
|
|
isActive ? 'opacity-100' : 'opacity-50'
|
|
}`}
|
|
aria-selected={isActive}
|
|
role="tab"
|
|
>
|
|
<div>{label}</div>
|
|
</button>
|
|
)
|
|
|
|
interface Tab {
|
|
label: ReactNode
|
|
paragraph?: string
|
|
panel: ReactNode
|
|
}
|
|
|
|
interface Props {
|
|
tabs: Tab[]
|
|
intervalDuration?: number
|
|
updateFrequency?: number
|
|
className?: string
|
|
}
|
|
|
|
const EnterpriseFormQuotes = ({
|
|
tabs,
|
|
intervalDuration = 25,
|
|
updateFrequency = 10,
|
|
className,
|
|
}: Props) => {
|
|
const [activeTab, setActiveTab] = useState(0)
|
|
const [progress, setProgress] = useState(0)
|
|
const [isPaused, setIsPaused] = useState(false)
|
|
const controls = useAnimation()
|
|
|
|
const restartInterval = (tabIndex: number) => {
|
|
setProgress(0)
|
|
setActiveTab(tabIndex)
|
|
}
|
|
|
|
const animation = {
|
|
width: '100%',
|
|
transition: { duration: intervalDuration, ease: 'linear' },
|
|
}
|
|
|
|
useEffect(() => {
|
|
const progressIncrement = (100 / intervalDuration) * (updateFrequency / 1000)
|
|
|
|
controls.start(animation)
|
|
|
|
const progressInterval = setInterval(() => {
|
|
if (isPaused) return setProgress(0)
|
|
setProgress((prevProgress) => (prevProgress + progressIncrement) % 101)
|
|
}, updateFrequency)
|
|
|
|
return () => {
|
|
clearInterval(progressInterval)
|
|
setProgress(0)
|
|
}
|
|
}, [activeTab, controls, isPaused])
|
|
|
|
useEffect(() => {
|
|
if (progress >= 100.9) {
|
|
setActiveTab((prevActiveTab) => (prevActiveTab === tabs.length - 1 ? 0 : prevActiveTab + 1))
|
|
}
|
|
}, [progress])
|
|
|
|
const handleTabClick = (tabIndex: number) => {
|
|
restartInterval(tabIndex)
|
|
}
|
|
|
|
return (
|
|
<div
|
|
className={cn('flex flex-col gap-6 w-full', className)}
|
|
onMouseEnter={() => setIsPaused(true)}
|
|
onMouseLeave={() => setIsPaused(false)}
|
|
>
|
|
{/* dynamic quote */}
|
|
<AnimatePresence mode="wait">
|
|
<motion.div
|
|
key={activeTab}
|
|
initial={{ opacity: 0 }}
|
|
animate={{ opacity: 1, transition: { duration: 0.1, delay: 0.2 } }}
|
|
exit={{ opacity: 0, transition: { duration: 0.05 } }}
|
|
className="text-foreground-lighter text-sm"
|
|
>
|
|
{tabs[activeTab]?.panel}
|
|
</motion.div>
|
|
</AnimatePresence>
|
|
{/* progress bar */}
|
|
<div className="relative w-full h-px bg-border-strong opacity-80 group-hover:opacity-100 rounded-full overflow-hidden">
|
|
<motion.div
|
|
className={cn(
|
|
'absolute motion-reduce:hidden inset-0 w-full right-full bg-brand h-full transition-all',
|
|
progress! > 99.7 ? 'opacity-0' : 'opacity-100'
|
|
)}
|
|
style={{ x: `${progress! - 100}%` }}
|
|
transition={{ duration: intervalDuration }}
|
|
/>
|
|
</div>
|
|
{/* tabs */}
|
|
<div className="w-full col-span-full flex gap-4 lg:gap-8 xl:gap-10" role="tablist">
|
|
{tabs.map((tab, index) => (
|
|
<Tab
|
|
key={index}
|
|
isActive={index === activeTab}
|
|
label={tab.label}
|
|
onClick={() => handleTabClick(index)}
|
|
/>
|
|
))}
|
|
</div>
|
|
</div>
|
|
)
|
|
}
|
|
|
|
export default EnterpriseFormQuotes
|