mirror of
https://github.com/supabase/supabase.git
synced 2026-10-09 19:35:06 +03:00
## Problem Our `<Button>` component breaks the default `button` contract by redefining the `type` prop to set its variant (`primary`, `default`, etc) instead of the button type (`submit`, `button`, etc). This is confusing and forces to write more code when using it with shadcn components that expect/inject the standard button props. ## Solution - rename the `type` prop to `variant` - rename the `htmlType` prop to `type` - propagate the changes where necessary - format code ## How to test As this is just prop renaming, if it builds it's ok --------- Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
49 lines
1.4 KiB
TypeScript
49 lines
1.4 KiB
TypeScript
import { ArrowDownIcon } from 'lucide-react'
|
|
import type { ComponentProps } from 'react'
|
|
import { useCallback } from 'react'
|
|
import { Button, cn } from 'ui'
|
|
import { StickToBottom, useStickToBottomContext } from 'use-stick-to-bottom'
|
|
|
|
type ConversationProps = ComponentProps<typeof StickToBottom>
|
|
type ConversationContentProps = ComponentProps<typeof StickToBottom.Content>
|
|
type ConversationScrollButtonProps = ComponentProps<typeof Button>
|
|
|
|
export const Conversation = ({ className, ...props }: ConversationProps) => (
|
|
<StickToBottom
|
|
className={cn('relative flex-1 overflow-y-auto', className)}
|
|
initial="smooth"
|
|
resize="smooth"
|
|
role="log"
|
|
{...props}
|
|
/>
|
|
)
|
|
|
|
export const ConversationContent = ({ className, ...props }: ConversationContentProps) => (
|
|
<StickToBottom.Content className={cn('p-4', className)} {...props} />
|
|
)
|
|
|
|
export const ConversationScrollButton = ({
|
|
className,
|
|
...props
|
|
}: ConversationScrollButtonProps) => {
|
|
const { isAtBottom, scrollToBottom } = useStickToBottomContext()
|
|
|
|
const handleScrollToBottom = useCallback(() => {
|
|
scrollToBottom()
|
|
}, [scrollToBottom])
|
|
|
|
return (
|
|
!isAtBottom && (
|
|
<Button
|
|
className={cn('absolute bottom-4 left-[50%] translate-x-[-50%] rounded-full', className)}
|
|
onClick={handleScrollToBottom}
|
|
size="tiny"
|
|
variant="default"
|
|
{...props}
|
|
>
|
|
<ArrowDownIcon className="size-4" />
|
|
</Button>
|
|
)
|
|
)
|
|
}
|